Commit Graph

27669 Commits

Author SHA1 Message Date
9538a32b5e Explicitly update beatmap info wedge on mod change
This used to already be the case prior to b419ea7, but in a very
roundabout way. Changes to the value of the star difficulty bindable -
including indirect changes via the set of active mods changing - would
trigger the wedge display to regenerate and load asynchronously.

b419ea7 accidentally broke this by moving down the bindable retrieval to
a lower level, at which point `WedgeInfoText` would only receive the set
of mods selected at the time at which a given beatmap was selected, and
not receive any further updates, breaking the BPM display updating in
real time (as `WedgeInfoText` could not be aware that rate-changing mods
were even in effect).

To resolve, explicitly reload the wedge's contents on mod changes.
2021-08-22 19:16:46 +02:00
e4a8f72167 Add failing test case 2021-08-22 19:16:43 +02:00
81e3c9d40f Update resources 2021-08-22 19:13:21 +09:00
956112eb10 Reword comment and remove brackets 2021-08-22 12:40:41 +03:00
9cd0a182f6 Add null check for Android ruleset loading 2021-08-22 00:38:48 -05:00
7ab12959a0 Merge branch 'master' into editor-regex 2021-08-21 19:57:26 +02:00
77f3668751 Merge branch 'master' into fix-screen-offsetting-on-scaling 2021-08-22 02:28:06 +09:00
9a6ff29951 Reword comment
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-08-21 15:39:57 +03:00
1729d43cec Add explanatory comment 2021-08-21 15:18:03 +03:00
df5354eba6 Merge branch 'master' into fix-setting-section-clickability 2021-08-21 14:25:28 +03:00
216ff07497 Merge branch 'master' into fix-setting-section-clickability 2021-08-21 14:11:55 +03:00
76e1d88028 Merge branch 'master' into gameplay-chat-mouse-cursor 2021-08-21 14:01:30 +03:00
ae47c5cdb3 Fix bottom area of a settings section not being clickable 2021-08-21 15:08:42 +09:00
15d443f6b7 Use the UI mouse cursor when hovering gameplay chat in an interactive state 2021-08-21 14:44:54 +09:00
36352d1de4 Improve highlighted chat username shadow effect 2021-08-21 14:34:35 +09:00
20f193c1c2 Fix screen offsetting not handling scaled game instances
By using `Content` instead, now the logic will get the X of the settings
overlay at the `Content` space, which can be scaled in the
`ScalingMode.Everything` mode.

And in the case of `ScalingMode.ExcludeOverlays`, a subcontainer
somewhere inside `Content` that's holding the screen stack would be scaled,
but `Content` won't be affected which is what we want in that case.
2021-08-21 04:16:12 +03:00
058d2d2a49 Use nekodex's regex from osu-web 2021-08-20 23:01:06 +03:00
8745fe9e34 Change editor timestamp regex to not match non-editor ones 2021-08-20 22:32:04 +03:00
d3dba296d6 Update resources 2021-08-20 23:47:35 +09:00
0c936aec4b Merge branch 'master' into temporary-directory-test-storage 2021-08-20 22:09:42 +09:00
0aea39f5f1 Merge branch 'master' into temporary-directory-test-storage 2021-08-20 20:41:54 +09:00
0a6b678059 Merge branch 'master' into settings-dim-other-sections 2021-08-20 20:22:22 +09:00
77149044a5 Allow intro screen to retrieve beatmap even if rulesets is not loaded 2021-08-20 19:43:48 +09:00
d304e283e4 Don't deselect online room when joined 2021-08-20 18:14:59 +09:00
591ba8cb09 Ensure the final scroll target is used when checking for whether too far down 2021-08-20 17:56:35 +09:00
03e6ca5ba9 Adjust scroll behaviour to feel better 2021-08-20 17:40:56 +09:00
2d19f37dc6 Add missing new method in UserTrackingScrollContainer for scrolling into view 2021-08-20 17:40:41 +09:00
139ff2d6e2 Only fade header in when hovering a section
Feels less like the controls are interactive when hovering this way.
2021-08-20 17:40:05 +09:00
c7266c74a0 Always prefer clicked section when present 2021-08-20 17:00:20 +09:00
cff7b1e98f Ensure the correct fade level is applied over all state changes 2021-08-20 17:00:08 +09:00
54bc532f0d Merge branch 'master' into fix-messagepack-union 2021-08-20 16:01:04 +09:00
659ec0c1b8 Merge pull request #14403 from Joehuu/fix-nub-glow
Fix nub glow color not having 0 alpha when being set
2021-08-20 15:07:30 +09:00
dcff30ed6e Merge branch 'master' into fix-login-as-guest 2021-08-20 14:06:28 +09:00
98357d51da Merge pull request #14323 from minetoblend/editor-seek
Prevent seeking before mp3 start time while editor is playing
2021-08-20 13:28:20 +09:00
284c871e39 Fix glow color potentially being set incorrectly when glowing
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-08-19 20:33:19 -07:00
da8eba9996 Return early to avoid updating state and failure count in fail cases 2021-08-20 12:11:41 +09:00
1e02d61b85 Fix nub glow color not having 0 alpha when being set 2021-08-19 20:06:49 -07:00
c95bf735fe Merge branch 'master' into multiplayer-chat 2021-08-20 11:54:42 +09:00
2825e15fd4 Update framework 2021-08-20 11:54:37 +09:00
7021133029 Merge branch 'master' into temporary-directory-test-storage 2021-08-20 11:54:33 +09:00
580136a5e9 Merge branch 'master' into fix-lounge-loading 2021-08-20 10:51:30 +09:00
143b8df1b2 Fix backwards warning text presence check 2021-08-19 22:40:35 +02:00
e25592f325 Merge branch 'master' into fix-lounge-loading 2021-08-19 20:01:47 +09:00
2b0f2a6db9 Merge pull request #14355 from frenzibyte/mod-settings-difficulty-cache
Update star difficulty bindables on mod settings change
2021-08-19 20:00:48 +09:00
a6b7ca1a4c Ensure all request failures are correctly handled during login 2021-08-19 19:55:14 +09:00
b09105e5a7 Merge pull request #14381 from smoogipoo/match-subscreen-redesign
Update layout of multiplayer room screens
2021-08-19 19:36:21 +09:00
a65cd36a5f Move some constants to consts 2021-08-19 19:19:46 +09:00
fcf7394d3c Merge pull request #14385 from rednir/limit-match-settings-textbox
Limit length of multiplayer match settings textboxes
2021-08-19 19:13:32 +09:00
8fce5911a9 Adjust spacing and padding of footer buttons 2021-08-19 19:08:46 +09:00
16aecfe934 Start free mod selection area hidden on screen display 2021-08-19 19:02:54 +09:00