Commit Graph

1982 Commits

Author SHA1 Message Date
8b04cd2cb0 Fix a potential null reference when loading carousel difficulties 2020-10-25 20:28:24 +09:00
8232bf1957 Merge pull request #10576 from Game4all/song-select-wedge-dynamic-star-rating 2020-10-23 15:39:02 +09:00
9753dab93b Remove IOnlineComponent and change existing components to use bindable flow 2020-10-22 14:19:12 +09:00
cf69eacae9 Make StarRatingDisplay dynamic. 2020-10-21 19:05:14 +02:00
670775cecb Make beatmap wedge difficulty indicator color update dynamically. 2020-10-21 18:57:48 +02:00
1fe987d4b3 Merge pull request #10497 from peppy/beatmap-carousel-less-diffcalc-stutter
Disable difficulty calculation for set-level difficulty icons
2020-10-20 14:57:34 +09:00
976f96b51d Merge branch 'master' into beatmap-carousel-refactor-less-alloc-overhead 2020-10-20 14:26:23 +09:00
13060b8575 Merge branch 'master' into beatmap-carousel-less-diffcalc-stutter 2020-10-20 14:26:16 +09:00
d5940193a2 Ensure visible items is greater than zero before trying to display a range 2020-10-19 19:55:20 +09:00
9106e97c37 Ensure max value in clamp is at least zero 2020-10-19 19:10:01 +09:00
1c2185e969 Replace comment with link to issue 2020-10-19 18:41:28 +09:00
044622a7a6 Fix out of bounds issues 2020-10-19 18:41:17 +09:00
467bb9b96f Merge branch 'master' into beatmap-carousel-refactor 2020-10-19 13:17:11 +09:00
bff3856c83 Account for panel height when removing as off-screen 2020-10-19 13:13:32 +09:00
ee0efa0b4c Fix off-by-one in display range retrieval logic 2020-10-19 13:05:42 +09:00
4590d9b93b Remove outdated comment logic 2020-10-19 13:04:12 +09:00
cc11283143 Use string.Starts-/EndsWith char overloads 2020-10-16 11:27:02 +02:00
88ffcb9234 Update EndsWith usages 2020-10-16 12:58:34 +09:00
30e1fce7a4 Reduce alloc overhead of DrawableCarouselBeatmapSet using new function-based ctor 2020-10-14 15:10:50 +09:00
07e6609e6d Disable difficulty calculation for set-level difficulty icons 2020-10-14 14:16:22 +09:00
e662dc5342 Add missing licence headers 2020-10-13 20:57:26 +09:00
8057ea1097 Fix formatting issues 2020-10-13 20:50:36 +09:00
3d416f4d64 Clean up beatmapSet resolution in DrawableCarouselBeatmapSet 2020-10-13 19:31:29 +09:00
75b6a5e17e Remove unnecessary hack (fixed via framework update) 2020-10-13 19:31:29 +09:00
5d11db7753 Locallise ChildItems to DrawableCarouselBeatmapSet for clarity 2020-10-13 19:31:29 +09:00
37daefc2b5 Remove outdated comment 2020-10-13 19:12:33 +09:00
8eca28e8bc Add comment about off-screen loading 2020-10-13 19:10:35 +09:00
834b0186f4 Adjust fade duration to be slightly shorter 2020-10-13 18:50:10 +09:00
2346644c04 Switch DelayedLoadUnloadWrappers to DelayedLoadWrappers
Due to pooling usage, there is no time we need to unload. Switching to
DelayedLoadWrapper cleans up the code and reduces overhead
substantially.
2020-10-13 18:47:40 +09:00
a1801f8ae4 Unmark todo for now 2020-10-13 18:47:36 +09:00
40a0ab7aaa Avoid allocating CarouselItems for bounds checks 2020-10-13 18:33:31 +09:00
4f4f222514 Remove unnecessary fade (already applied by base DrawableCarouselItem) 2020-10-13 18:28:28 +09:00
83358d487f Remove logging 2020-10-13 18:18:22 +09:00
3d9ea852ec Remove masking override (no longer needed as our size is now correct) 2020-10-13 18:14:23 +09:00
69650c16fc Simplify vertical position calculations by including spacing in height definition 2020-10-13 18:13:36 +09:00
b1ddb08a4e Fix right click context menus appearing in incorrect locations 2020-10-13 18:01:12 +09:00
d9a6a6b245 Split content out into own class 2020-10-13 18:01:12 +09:00
9b2ebb8f0f Fix main content DelayedLoadUnloadWrapper not getting a valid size before load 2020-10-13 17:45:41 +09:00
f3b937e358 Fix masking issues with certain aspect ratio displays 2020-10-13 17:37:33 +09:00
fdd4d95cdc Fix difficulties being at incorrect vertical positions after filter is applied 2020-10-13 17:37:33 +09:00
1f0aa974dd Fix failing tests 2020-10-13 17:37:33 +09:00
b536f571fd Move header height propagation to update for safety 2020-10-13 17:37:33 +09:00
ded09b78cb Avoid usage of AutoSize for DrawableCarouselItems in general 2020-10-13 17:37:33 +09:00
cecdf14f53 Avoid reconstructing beatmap difficulties that were recently displayed 2020-10-13 17:37:33 +09:00
1da49073ab Calculate content height automatically 2020-10-13 17:37:33 +09:00
c08b5e8d03 Align beatmap difficulties correctly 2020-10-13 17:37:33 +09:00
cfec4f4fc1 Extract header element from base DrawableCarouselItem class 2020-10-13 17:37:33 +09:00
2aad482545 Fix x offsets of difficulties not being updated 2020-10-13 17:37:33 +09:00
1b7e3397c6 Use expiry to avoid ToArray 2020-10-13 17:37:33 +09:00
075bf23714 Better track off-screen drawables (and return to pool less often) 2020-10-13 17:37:33 +09:00