Commit Graph

27830 Commits

Author SHA1 Message Date
4da2dca339 Apply the default SampleControlPoint if not externally provided
This is mostly to handle tests for now, as generally this should be
provided by an external source in all other cases.
2021-08-30 17:21:07 +09:00
d35c4da906 Add new control point to legacy regeneration logic 2021-08-30 17:14:53 +09:00
6ee4a6526c Don't block sample points from still being added to ControlPointInfo 2021-08-30 17:14:53 +09:00
6fd24a5d92 Remove redundant null coalesce 2021-08-30 17:14:53 +09:00
ccacf56dd8 Move to legacy namespace 2021-08-30 17:14:53 +09:00
7257aae7f2 Move samples to LegacyControlPointInfo 2021-08-30 17:14:53 +09:00
4dd60e3299 Merge branch 'master' into taiko-drum-refacor 2021-08-30 14:12:52 +09:00
7be825f470 Merge pull request #14488 from frenzibyte/multi-spectator-player-leaving
Gray out and stop player instances who quit during multi-spectator sessions
2021-08-30 12:04:19 +09:00
681a87d4ec Update framework 2021-08-28 07:08:06 +09:00
804ca88d63 Update framework 2021-08-27 19:52:45 +09:00
378734a7f8 Separate solo spectator player and "exit on restart" logic to own class 2021-08-27 13:24:37 +03:00
2b06dacd0e Change debounce back to using scheduler
Should better allow for adjusting in the future, as well.
2021-08-27 18:57:19 +09:00
33aa48bcf6 Merge branch 'master' into lobby-sounds 2021-08-27 18:46:12 +09:00
7d9bae4507 Update resources 2021-08-27 18:29:49 +09:00
a28bc9f6b2 Merge branch 'master' into path-control-point-bindable-removal 2021-08-27 09:37:37 +09:00
2ef2af17eb Merge branch 'master' into alternative-difficulty-bindable 2021-08-26 23:07:52 +02:00
d71dff4340 Merge branch 'master' into skip-overlay-optimisations 2021-08-26 22:38:17 +02:00
875ef3e68f Merge branch 'master' into fix-mania-editor 2021-08-26 21:00:20 +02:00
15aa0458bc Use PausableSkinnableSound instead 2021-08-26 17:15:36 +09:00
ec85d7f356 Remove unused helper method 2021-08-26 17:15:23 +09:00
982c4eff14 Merge branch 'master' into taiko-drum-refacor 2021-08-26 17:13:14 +09:00
2f26d270a3 Merge branch 'master' into score-processor-enum-getvalue-overhead-reduction 2021-08-26 09:55:09 +03:00
15812520bd Replace global editor test case with mania compose screen test scene 2021-08-26 09:45:01 +03:00
56baecdde4 Add missing interaction sfx to MatchTypePicker 2021-08-26 15:30:20 +09:00
e341f471b0 Add lobby sfx for join/leave/kick/ready/unready events 2021-08-26 15:29:22 +09:00
e633b2716d Fix regression in outro skip handling logic 2021-08-26 13:58:45 +09:00
e32933eb54 Avoid Enum.GetValues in each score population pass 2021-08-26 13:37:53 +09:00
f4199958d9 Avoid unnecessary array/LINQ operations when replay frames have no action changes 2021-08-26 13:03:50 +09:00
6dcd9427ac Remove bindable usage in PathControlPoint
This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.

I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.
2021-08-26 12:33:53 +09:00
b1a261c902 Avoid using scheduled delegates at all for skip overload input handling 2021-08-26 12:25:37 +09:00
956e3c554b Avoid skip overlay attempting to show when it is already invalid 2021-08-26 12:25:37 +09:00
b4d6495f99 Fix editor skin providing container not providing playable beatmap 2021-08-25 17:52:36 +03:00
f9b25a0159 Add test case for switching to each screen in editor test scenes 2021-08-25 17:52:35 +03:00
3ad0b529fb Make EditorScreen inherit from VisibilityContainer rather than unsafe transforms 2021-08-25 17:14:52 +03:00
196c74fce8 Gray out and remove player clock when users stop playing 2021-08-25 11:31:02 +03:00
599145b46a Stop clocks when removing them from sync manager 2021-08-25 11:31:02 +03:00
fd78d0440b Update missed conditional 2021-08-25 17:00:32 +09:00
ccfff50c6f Apply fixes in line with issues found during testing
I was trying to be too smart with caching, but if the `Play` method was
not called often enough it would have a recent reference. Unfortunately
this requires a separate query to `Entries`, but is also a special case
(no future hitobjects).

This also removes the time-based checks (result status alone should be
all we care about).
2021-08-25 16:56:44 +09:00
ef2b5e1c51 Tidy up variable names and unused resolved properties 2021-08-25 16:56:44 +09:00
a1936b141b Refactor base class to allow correct usage in taiko drum 2021-08-25 16:56:44 +09:00
681215e5b5 Rewrite object lookup to use previous entry regardless
This changes the fallback logic to always prefer the previous resolved
lifetime entry rather than fallback to the first entry ever. I think
this is more correct in all cases.

Also rewrites the inline comments to hopefully be easier to parse.
2021-08-25 16:56:44 +09:00
4a294d4de4 Optimise fallback logic to reduce lookups to bare minimum 2021-08-25 16:56:44 +09:00
6aa894e55e Split out separate component 2021-08-25 16:56:44 +09:00
351015357c Merge branch 'master' into user-events-in-participant-list 2021-08-25 14:39:26 +09:00
e1ab3434ed Add ability to handle user join/leave/kick events in MultiplayerComposites 2021-08-25 14:37:14 +09:00
ca527262e3 Merge branch 'master' into countdown-beatmap-info 2021-08-25 08:30:27 +03:00
84637b59ef Define DifficultyBindableWithCurrent and use in SliderControl 2021-08-25 07:40:41 +03:00
414457ba57 Add basic xmldoc explaining CountdownOffset 2021-08-25 13:24:52 +09:00
a6c2cbd2e5 Add countdown settings to beatmap info model 2021-08-24 21:55:10 +02:00
e503182a8d Merge branch 'master' into activity-on-multiplayer-screens 2021-08-24 18:50:55 +02:00