a01602e63c
Merge branch 'master' into combo-colour-brightness-limit
2022-11-02 12:09:27 +09:00
f014acfc8d
Fix DrawableHitObject.AccentColour not being updated if object entry is not attached
2022-11-01 19:34:53 +09:00
27af91003b
Merge branch 'master' into combo-colour-brightness-limit
2022-11-01 17:50:26 +09:00
42eafe318c
Remove various simple obsoletions
2022-10-28 13:20:58 +09:00
da93849b80
Rename some pieces and better document SampleBankInfo
2022-10-25 14:55:33 +09:00
8a88339e78
Allow combo colour normalisation to be disabled
2022-10-14 14:37:24 +09:00
15db65c037
Extract to struct, add dictionary term
2022-10-14 14:12:53 +09:00
4149235e63
Limit minimum brightness of combo colours
2022-10-13 14:05:33 +09:00
f060e6a780
Implement hold "sliding" samples in osu!mania
2022-10-11 16:31:37 +09:00
5a4196fd51
Make currentEffectPoint non-nullable
2022-10-10 15:34:29 +02:00
d389808427
Make effect point search more efficient
2022-10-10 14:00:26 +02:00
eae32ca483
Switch DefinitelyBigger to AlmostBigger to account for fp errors
2022-10-10 09:39:40 +02:00
63ffaa6929
Respect OmitFirstBarLine effect
2022-10-07 20:38:32 +02:00
903c8612c8
Move endTime to next timing point
2022-10-07 20:34:31 +02:00
0cffbb7562
Clamp LifetimeStart of HitObject's to their judgement windows
2022-09-27 16:54:24 +02:00
78625fda7d
Improve exception when attempting to call DrawableHitObject.ClearInternal
2022-09-22 14:44:03 +09:00
e56ea58e71
Fix up xmldoc
2022-09-15 16:06:21 +09:00
c847cc521e
Add some inline comments
2022-09-15 16:00:35 +09:00
68e4d22898
Precondition against entryMap intead of parentMap
2022-09-15 15:43:15 +09:00
31bc067dd1
Don't store nulls to parentMap
2022-09-15 15:38:44 +09:00
5dc0d32e42
Apply NRT to hitobject lifetime related classes
2022-09-14 15:24:20 +09:00
c59aa57450
Remove createLifetimeEntry from HitObjectEntryManager
2022-09-14 15:19:33 +09:00
47539e2129
Add doc comments to HitObjectEntryManager
2022-09-14 15:19:05 +09:00
bde390828b
Manage entries of nested hit objects in HitObjectEntryManager
...
- Fix nested hit objects are leaked when parent hit object is edited or deleted
2022-09-14 15:19:05 +09:00
a9eba27129
Factor out pooling logic from Playfield
2022-09-14 15:19:05 +09:00
105aa01e7d
Update usages of RemoveInternal
2022-08-29 15:57:40 +09:00
8f80a22ef9
Fix osu! and catch hitobjects no longer scaled to 1 by default
2022-07-19 07:00:13 +03:00
5ddb5a3d74
Introduce HitObjectProperty<T>
2022-07-19 05:39:10 +03:00
f71f6302fd
Remove unnecessary null casts
2022-06-24 14:50:11 +09:00
e0c82d11ab
Convert == usages to ReferenceEquals
2022-06-20 16:56:19 +09:00
fd9902e816
Manual #nullable processing
2022-06-17 16:38:35 +09:00
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
9259aa94f1
Fix Catmull slider parsing with duplicate initial point
2022-05-24 11:47:42 +09:00
731f0960ec
Don't merge adjacent legacy Catmull segments
2022-05-18 17:16:24 +09:00
10e41d018a
Fix toggling hit animations on the editor not applying immediately
2022-05-12 17:36:35 +09:00
977e6d8a80
Add xmldoc for IDistanceSnapProvider and related properties
2022-05-05 16:25:45 +09:00
59cf3ff50f
Move distancing methods from IPositionSnapProvider to IDistanceSnapProvider
2022-04-28 05:48:45 +03:00
c079a9cd32
Add comment regarding equality check importance in LegacyHitSampleInfo
2022-03-23 20:18:44 +09:00
997c091a8d
Revert "Remove IsLayered from LegacyHitSampleInfo comparison"
...
This reverts commit 4523393208
2022-03-23 20:15:17 +09:00
2ea9e5245c
Revert "Remove IsLayered from GetHasCode implementation"
...
This reverts commit 16ee6b5fc7
2022-03-23 20:15:13 +09:00
16ee6b5fc7
Remove IsLayered from GetHasCode implementation
2022-03-14 18:12:04 +09:00
4523393208
Remove IsLayered from LegacyHitSampleInfo comparison
...
The equality of samples is generally used to compare the sample
equality, not its full properties. For instance, we don't compare
`Volume` in the base implementation.
Having `IsLayered` here breaks actual usages of equality, ie. for
pooling purposes.
2022-03-14 17:19:48 +09:00
8676a2587c
Add the ability for HitObjects to specify auxiliary samples
2022-03-14 17:19:48 +09:00
735414bc49
Replace TimeSignatures enum with struct for storage of arbitrary meter
2022-01-22 20:50:31 +01:00
eb5f15a77e
Merge pull request #16420 from bdach/slider-paste-parsing-failures-2
...
Fix pasted sliders having sample points with time at infinity
2022-01-13 23:28:49 +09:00
5185f6010e
Fix missed identifier typos
2022-01-12 15:46:20 -08:00
afce976f08
Fix oversubscription to StartTimeBindable.ValueChanged
2022-01-12 19:29:49 +01:00
07fc772c24
Merge branch 'master' into slider-paste-parsing-failures-2
2022-01-12 19:06:36 +01:00
80ccff9068
Remove no longer necessary guards against default control points
...
The subscription in which the guards were present was moved from
constructor to `ApplyDefaults()`, and at that point neither the sample
control point or the difficulty point can be the default point, because
there are explicit paths that overwrite those with blank points in the
same methods, prior to the subscription's registration.
The only worry would be that someone would set the default point on the
object themselves, but at that point that is most likely programmer
error anyhow.
2022-01-11 22:14:47 +01:00
7a25fe79b7
Fix sample control point time being calculated before defaults applied
...
In editor contexts, the `StartTimeBindable` subscription in `HitObject`
was firing before defaults were applied, which in the case of sliders
manifested in an infinite end time. `ApplyDefaults()` also did not
always set the time of the control point to the correct value, which
matters when the beatmap is encoded.
Ensure that the control points receive the correct time values during
default application, and only register the `StartTimeBindable` change
callback after defaults have been successfully applied.
2022-01-11 21:38:59 +01:00
