Commit Graph

661 Commits

Author SHA1 Message Date
66e74da2b7 Fix regression in quick delete mouse action blocking 2021-04-13 13:03:14 +09:00
cc2acf5e54 Fix ctrl-dragging on an existing selection causing deselection of the hovered object 2021-04-12 19:05:23 +09:00
9d0839be8f Remove no longer necessary FinishTranforms call 2021-04-06 15:35:07 +09:00
316a557a99 Split select area background into own class to reduce hover state complexity 2021-04-06 15:34:34 +09:00
7d301a6336 Improve timeline hover display before time zero with a gradient fade 2021-04-06 14:34:16 +09:00
35dd1c68aa Fix drag/selection events not propagating correctly to TimelineBlueprintContainer when before time zero 2021-04-06 14:34:16 +09:00
8ff13845d1 Add marker showing where 00:00:000 is 2021-04-06 14:24:22 +09:00
d2ef0ba644 Merge branch 'master' into add-editor-nudging-support 2021-03-30 14:34:43 +09:00
1bb9f018a0 Merge branch 'master' into fix-timeline-depth-ordering 2021-03-29 20:47:47 +09:00
3cf6a3f56d Merge pull request #12076 from peppy/add-timeline-stacking-support
Implement editor timeline stacking support
2021-03-29 20:44:52 +09:00
690debe507 Merge pull request #12030 from LeNitrous/editor-platform-clipboard-copy 2021-03-29 19:31:16 +09:00
3909eda095 Avoid using a StringBuilder 2021-03-29 18:51:28 +09:00
90ab765cf5 Reorder methods and surround with region 2021-03-29 18:46:32 +09:00
cdb779f764 move copy logic inside ComposeScreen 2021-03-29 17:30:23 +08:00
21398e25b5 null check composer and ensure the correct start time from selected hit objects 2021-03-27 10:02:21 +08:00
c96321206a fix appveyor complaints 2021-03-26 16:17:24 +08:00
71a0616861 remove extra semi colons 2021-03-26 15:34:45 +08:00
374f8c5e22 move to compose namespace and add license header 2021-03-26 15:33:28 +08:00
cb48e5f158 Fix timeline not visually ordering hitobjects in a stable way 2021-03-26 16:33:18 +09:00
b8b7eb4c4b refactor logic to its own component and handle hit object to string conversion to its ruleset-specific composers 2021-03-26 15:25:20 +08:00
77969bb223 Merge branch 'master' into add-timeline-stacking-support 2021-03-26 16:17:10 +09:00
f6647de769 Add support for nudging objects in the editor using ctrl+arrow keys
Closes #12042.
2021-03-25 19:56:28 +09:00
8d4ff867bf Fix barlines showing up in the osu!mania editor's timeline 2021-03-25 16:30:31 +09:00
9fdd23b134 Fix various issues with stacking 2021-03-25 16:28:30 +09:00
bdc783b55f Merge branch 'master' into add-timeline-stacking-support 2021-03-25 15:28:30 +09:00
7b3336783f Stabilise ordering instead of simple reversing
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-03-25 15:24:59 +09:00
dd48b68f8a Ensure selected blueprints are given selection priority 2021-03-19 22:44:33 +01:00
71a361337d Add comment regarding usage of Reverse()
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2021-03-19 21:57:48 +09:00
9be7981e0d Adjust timeline ticks to be more visible 2021-03-19 19:45:00 +09:00
563a0584d5 Implement editor timeline stacking support 2021-03-19 18:48:51 +09:00
711d895a04 Merge pull request #8238 from voidedWarranties/editor-song-end 2021-03-19 16:32:23 +09:00
2e63c2ce20 Fix selection box operation hotkeys not registering in change handler
Could lead to crashes after reversing a note cluster and playing it
back.

The root cause of the crash was that the hotkey operations were not ran
inside of an editor change handler operation. This, in turn, caused the
autoplay replay to not be regenerated after flipping an object cluster,
therefore finally manifesting as a hard crash due to negative time
offsets appearing in judgement results, which interfered with the
default implementation of note lock.

Note that this incidentally also fixes the fact that selection box
hotkey operations (reverse and flip) did not handle undo/redo.
2021-03-17 22:17:42 +01:00
a691291ae8 Merge branch 'master' into editor-song-end 2021-03-17 18:18:19 +01:00
cd1c1bf534 Centralise cases of performing actions on the current selection
By moving this to a central location, we can avoid invoking the
EditorChangeHandler when there is no selection made. This helps
alleviate the issue pointed out in
https://github.com/ppy/osu/issues/11901, but not fix it completely.
2021-02-26 14:15:13 +09:00
e9730d4782 Move default sample addition to inside PlacementBlueprint
This isn't actually required to fix the behaviour but it does feel like
a better place to put this logic.
2021-02-11 17:16:18 +09:00
96652e07cd Merge branch 'master' into zero-spinner-slider 2021-02-05 09:40:55 -05:00
5061231e59 Switch to beat length 2021-02-05 09:39:14 -05:00
b489e92c9e Fix TimelineParts not using correct beatmap 2021-01-25 18:44:36 +09:00
04095cd5b9 Merge branch 'master' into fix-editor-scroll-interruption 2021-01-21 17:46:18 +09:00
9eb74e86ed Apply comment suggestion
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-01-21 17:40:15 +09:00
5ee3a5f230 Use AlmostEquals 2021-01-20 13:00:25 -05:00
ce3c2f07dc Fix zero length spinners and sliders 2021-01-20 12:19:52 -05:00
831c06a3c7 Expose and consume boolean covering whether an ongoing smooth seek is running 2021-01-15 16:14:38 +09:00
04fa32bc34 Rename and add xmldoc for smooth seeking method 2021-01-15 16:14:21 +09:00
ed78be825f Fix editor timeline not snapping on non-precise wheel scroll
For wheel input with precision, we still prefer exact tracking for now.
May change this in the future based on feedback from mappers, but it
makes little sense to do non-snapped scrolling when input is coming from
a non-precise source.
2021-01-15 15:47:42 +09:00
b7dd54847f Move resolved usage of WorkingBeatmap in editor components as local as possible to avoid misuse 2021-01-04 16:56:37 +09:00
423c6158e1 Highlight timeline drag area when hovered for better visibility 2020-12-21 18:10:11 +09:00
d1be7c23d9 Increase height of timeline drag area 2020-12-21 18:09:56 +09:00
d11d754715 Increase size of circle display on timeline 2020-12-21 18:09:37 +09:00
f1878eff63 Use yet another solution leveraging padding 2020-12-18 23:45:42 +01:00