Commit Graph

5935 Commits

Author SHA1 Message Date
04d6ca59a3 Merge branch 'master' into song-select-scroll-position-during-delete 2022-01-27 20:46:19 +01:00
e872877185 Merge pull request #16648 from peppy/fix-song-select-tests
Fix song select tests not waiting for beatmap imports to arrive
2022-01-27 23:00:58 +09:00
fae4f8bd8e Move nulling of previous songSelect to SetUpSteps instead 2022-01-27 21:59:44 +09:00
831fa44433 Fix song select tests not waiting for beatmap imports to arrive
After the change to realm, notification fires could take a frame or two.
We aren't accounting for this.

Fixes test failures like
https://github.com/ppy/osu/runs/4963255990?check_suite_focus=true
2022-01-27 19:35:42 +09:00
a5d422e82c Merge branch 'master' into ruleset-id-fixes 2022-01-27 17:07:18 +09:00
f2cecad83b Add failing test coverage showing carousel deletions don't keep scroll position 2022-01-27 16:52:02 +09:00
5288eedd31 Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID 2022-01-27 15:38:03 +09:00
e0616476e2 Fix test gameplay tests failing due to beatmap refetch on suspend 2022-01-26 21:15:49 +01:00
4382adad82 Add test coverage for editor changes not resetting after exit without save 2022-01-26 21:15:49 +01:00
cdca1285ab Merge branch 'master' into playlist-overlay-optimisations 2022-01-26 19:01:33 +09:00
a34b8fc4d0 Merge branch 'master' into expandable-controls 2022-01-26 10:36:22 +03:00
eb83b7fe0a Update existing implementation with changes 2022-01-26 10:18:17 +03:00
68ee80c5de Merge pull request #16623 from frenzibyte/refactor-editor-save-test
Refactor editor saving test scene for scalability
2022-01-26 15:40:39 +09:00
701f00a4b1 Merge pull request #16609 from peppy/fix-realm-related-failures
Fix some realm-related test failures
2022-01-26 15:31:18 +09:00
9532454e2a Remove ILive remnants 2022-01-26 15:12:07 +09:00
ba46827ac0 Merge branch 'master' into playlist-overlay-optimisations 2022-01-26 15:11:14 +09:00
064468faad Refactor editor saving test scene for scalability 2022-01-26 07:57:46 +03:00
cd71ec0edd Remove ILive<> interface (and use abstract Live<> instead) 2022-01-26 13:38:56 +09:00
dda513dd08 Change PlaylistOverlay to use ILive 2022-01-26 12:19:59 +09:00
bdf215c576 Merge branch 'master' into improve-timeline-zoom 2022-01-26 03:40:53 +09:00
5085eb6801 Ensure gameplay starts by dismissing any notifications in TestSceneChangeAndUseGameplayBindings 2022-01-26 03:39:01 +09:00
ad18bc4983 Update timeline selection test scene with zoom changes 2022-01-25 18:57:39 +03:00
5b82eaf112 Merge branch 'master' into fix-beat-divisor-not-saving 2022-01-25 23:29:37 +09:00
6c69df815a Update editor test scenes to set working beatmap properly 2022-01-25 15:56:27 +03:00
4d8c5ebb0c Merge branch 'master' into fix-beat-divisor-not-saving 2022-01-25 12:30:05 +03:00
b2b6672095 Add failing test asserts 2022-01-25 11:56:38 +03:00
c0ed308016 Use more correct method of deletion in TestScenePlaySongSelect 2022-01-25 17:55:39 +09:00
90a7dd7711 In gameplay bindings test, ensure a selection is made before attempting to enter gameplay 2022-01-25 17:55:33 +09:00
83b0e4572a Fix test failures 2022-01-25 16:51:21 +09:00
778d2a71b4 Remove Task from the inner-most Import method in RealmArchiveModelImporter
One of my pending work items for post-realm merge.

The lowest-level import task is no longer asynchronous, as we don't want
it to span multiple threads to allow easier interaction with realm.
Removing the `Task` spec simplifies a heap of usages.

Individual usages should decide whether they want to run the import
asynchronously, by either using an alternative override or spooling up a
thread themselves.
2022-01-25 15:30:29 +09:00
e23b10e6a5 Update remaining cases of clashing variable name in realm.Run(realm.. 2022-01-25 13:04:05 +09:00
3e5c9e8436 Fix cases of Access instead of Realm 2022-01-25 12:58:15 +09:00
f30894840c Update terminology to realm "instance" rather than "context"
This matches the terminology used by realm themselves, which feels
better.
2022-01-24 20:38:38 +09:00
6eb2c28e41 Rename RealmContextFactory to RealmAccess 2022-01-24 20:38:07 +09:00
d7db6fa918 Merge branch 'master' into custom-meter 2022-01-24 15:46:44 +09:00
6581e8c2d3 Merge pull request #16549 from Susko3/LoginPanel-flag
Hide the login panel when clicking the country flag
2022-01-24 15:38:50 +09:00
e236f5d604 Add failing test coverage for correct beatmap filename generation on save 2022-01-23 20:28:19 +01:00
1ea5a2e6a7 Fix incorrect assert step name 2022-01-23 10:11:12 +03:00
6b35c0fe01 Add test scene for ExpandingControlContainer 2022-01-23 05:41:16 +03:00
f39f2c93b5 Add control for arbitrary-numerator time signatures 2022-01-22 20:50:31 +01:00
735414bc49 Replace TimeSignatures enum with struct for storage of arbitrary meter 2022-01-22 20:50:31 +01:00
9b63f15e68 Add failing test 2022-01-21 13:58:30 +01:00
114c9e8c1f Update all usages of CreateContext to use either Run or Write 2022-01-21 17:27:08 +09:00
4f86a2cb61 Merge pull request #16525 from bdach/beatmap-listing-overflow-and-scrolling
Improve usability of expanded card content on beatmap listing
2022-01-20 14:14:44 +09:00
4cad5890c6 Add test coverage for news sidebar showing wrong headers 2022-01-19 23:12:35 +01:00
d925e44b40 Add test coverage for beatmap card expanded content clipping 2022-01-19 22:08:52 +01:00
581873f944 Merge pull request #16497 from peppy/top-local-rank-optimisation
Rewrite `TopLocalRank` to use realm subscriptions
2022-01-19 14:22:12 +09:00
3e5d29ed00 Merge pull request #16505 from peppy/remove-base-difficulty-usage
Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)
2022-01-19 13:53:55 +09:00
201f2d7813 Add comprehensive test coverage for TopLocalRank 2022-01-19 13:48:00 +09:00
f6f44029e8 Merge pull request #16507 from peppy/more-ingore-rules
Add some missing `IgnoredAttributes` to reduce automapper overhead
2022-01-19 12:26:37 +09:00