6f0e32826c
Standardise ordering/grouping of IRulesetInfo/RulesetInfos
2022-02-11 04:27:11 +03:00
eb25730b61
Revert "Merge pull request #16716 from peppy/carousel-less-invalidations"
...
This reverts commit 8d13e0514b95582a9023
2022-02-05 16:12:58 +09:00
0f48c0131c
Layer playback of beatmap-changed and random-beatmap samples
2022-02-04 19:57:54 +09:00
6d6327d3da
Fix test beatmap loading potentially performing selection before carousel itself is loaded
2022-02-03 18:40:16 +09:00
e65996efc3
Rename variable to match purpose better
2022-02-03 17:14:38 +09:00
4f3e55a0ce
Merge branch 'master' into songselect-random-sfx
2022-02-02 17:18:24 +09:00
6bc6675fa1
Adjust fade in times slightly
2022-01-31 14:46:20 +09:00
8917ab78f4
Reduce unnecessary container nesting and adjust empty state opacity slightly
2022-01-31 14:46:20 +09:00
2ee0db0ebf
Move fade in function local
2022-01-31 14:46:20 +09:00
c3e3b2019d
Reduce overhead of ApplyState by tracking previous values
...
Even with pooling applied, there are overheads involved with transforms
when quickly cycling through the carousel.
The main goal here is to reduce the transforms in cases the reuse is
still in the same state. Avoiding firing `FadeIn` and `FadeOut` are the
main areas of saving.
2022-01-31 14:46:20 +09:00
a06287e76a
Remove DrawableCarouselItem.Update updating of height
...
Marginal from a performance aspect, but reads better.
2022-01-31 14:46:20 +09:00
9c9fda84f3
Add schedule and cancellation check to score ordering step
2022-01-31 13:50:53 +09:00
f8939af5e6
Track loading via state as well
2022-01-31 01:12:03 +09:00
acc1199add
Consolidate flows of Set operations, either result or error
2022-01-30 16:16:00 +09:00
c401629dd8
Also refactor placeholder logic to make more sense
2022-01-30 10:50:32 +09:00
d0b74a91fb
Fix edge cases with score drawable loading
2022-01-29 23:58:57 +09:00
0293d95f82
Simplify IsOnlineScope usage
2022-01-29 23:58:57 +09:00
daea13f491
Simplify flow of cancellation token
2022-01-29 23:58:57 +09:00
3d59bab7c6
Remove fetch callback logic completely
2022-01-29 23:58:57 +09:00
aee93934d5
Rename methods to make more sense (and always run through AddOnce)
2022-01-29 23:58:57 +09:00
e7823982d8
Fix ruleset value not being transferred when FinaliseSelection is not called
2022-01-29 18:44:48 +09:00
f021a274d2
Merge pull request #16681 from peppy/fix-delete-local-scores
...
Fix delete local scores via "Clear all scores" button crashing the game
2022-01-28 17:01:31 +09:00
0d3ac4fd9c
Fix delete local scores crashing the game
2022-01-28 15:54:53 +09:00
b7d8c9bf06
Fix a couple of cases of incorrect equality checks in the case both values are null
2022-01-28 14:29:56 +09:00
f59828e2d9
Add audio feedback to song select 'random'
2022-01-28 13:43:37 +09:00
04d6ca59a3
Merge branch 'master' into song-select-scroll-position-during-delete
2022-01-27 20:46:19 +01:00
7af23328a4
Merge branch 'master' into ruleset-ordering-fix
2022-01-27 21:46:03 +09:00
3ae5973ab7
Fix compilation error due to commit split
2022-01-27 17:08:31 +09:00
449e9bcf5c
Ensure beatmap carousel scroll position is maintained during deletion operations
2022-01-27 16:52:02 +09:00
0a45aa80cb
Remove unnecessary double-schedule in UpdateBeatmapSet
2022-01-27 16:52:02 +09:00
5637fd64d6
Perform ordering using IComparable instead
2022-01-27 15:59:20 +09:00
5288eedd31
Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
2022-01-27 15:38:03 +09:00
f30d63107a
Add SortID to RulesetInfo to allow stable ordering of rulesets for display
2022-01-27 15:35:16 +09:00
f70e10e8a4
Fix ruleset filter matching using OnlineID instead of ShortName
2022-01-27 01:25:57 +09:00
873d367615
Fix custom rulesets not being able to convert maps
2022-01-26 15:51:39 +01:00
473c4d00ca
Fix grouped difficulty icons using incorrect lookup for ruleset grouping
2022-01-26 18:38:44 +09:00
d7342880f5
Update remaining cases of clashes with realm.Write and realm.RegisterForNotifications
2022-01-25 13:09:48 +09:00
e23b10e6a5
Update remaining cases of clashing variable name in realm.Run(realm..
2022-01-25 13:04:05 +09:00
6eb2c28e41
Rename RealmContextFactory to RealmAccess
2022-01-24 20:38:07 +09:00
40aa873190
Rename register methods to better explain their purpose
2022-01-24 14:37:36 +09:00
e9e3e024a1
Update all usages of QueryAsyncWithNotifications to use new Register pathway
2022-01-23 20:28:04 +09:00
61cef42be9
Proof of concept realm subscriptions via Register
2022-01-23 20:28:04 +09:00
1f157d729d
Update existing subscriptions to new style
...
Fix missing detach calls in `MusicController`
2022-01-21 20:05:03 +09:00
8f1dfa33a2
Merge branch 'master' into realm-context-use-update-when-feasible
2022-01-21 18:03:09 +09:00
114c9e8c1f
Update all usages of CreateContext to use either Run or Write
2022-01-21 17:27:08 +09:00
3bcdce128c
Use dictionary add for safety
2022-01-21 15:29:21 +09:00
ff4f40db8a
Merge branch 'master' into carousel-performance-n
2022-01-21 15:27:42 +09:00
c4f24ef96c
Merge pull request #16542 from peppy/carousel-search-performance-less-simple
...
Avoid performing full filter when updating carousel beatmap sets
2022-01-21 15:05:30 +09:00
bed7b69464
Apply NRT to CarouselGroup
2022-01-21 13:26:29 +09:00
5b24800b0e
Avoid applying filter in UpdateBeatmapSet flow
2022-01-21 13:26:25 +09:00
