Commit Graph

23594 Commits

Author SHA1 Message Date
a1c35677ef Add more xmldoc 2021-03-24 13:02:17 +09:00
e649a330a4 Implement SoloPlayer's request construction 2021-03-23 18:23:25 +09:00
242b847516 Add flow for allowing gameplay to continue even when an error occurs with token retrieval 2021-03-23 18:23:25 +09:00
3cd8bf2d7f Move token request construction to LoadAsyncComplete to better allow DI usage 2021-03-23 18:20:55 +09:00
571124669d Remove all references to "score submission" from Player 2021-03-23 18:20:55 +09:00
194b2d05d3 Update SoloPlayer to derive SubmittingPlayer 2021-03-23 18:20:55 +09:00
12f050264a Further split out a player class which submits to "rooms" 2021-03-23 18:20:55 +09:00
7045fce555 Move score submission logic in general out to its own Player type 2021-03-23 18:20:55 +09:00
6cb14e91c9 Make Player abstract and introduce SoloPlayer 2021-03-23 18:18:49 +09:00
5267fb74c4 Add submission requests 2021-03-23 18:18:49 +09:00
aeff9bd853 Add return bool to HandleRequest to better trigger failures 2021-03-23 18:17:29 +09:00
ce452565f4 Avoid firing any kind of failures after success 2021-03-23 17:50:31 +09:00
f5ba746ae5 Fail all API requests sent to DummyAPIAccess
Until now, API requests sent to dummy API were just lost in the void. In most cases this somehow worked as expected, but any logic which is waiting on a request to finish will potentially never get a response.

Going forward, I'm not 100% sure that every `Wait` on a web response will have local timeout logic (I think there is a certain amount of assumption that this is being managed for us by `APIAccess`), so I've made this change to better handle such cases going forward. Now, rather than nothing happening, requests will trigger a failure via the existing exception logic rather than silently pretending the request never arrived.
2021-03-23 17:37:45 +09:00
17a28f4f65 Merge pull request #12136 from peppy/remove-skin-sample-workarounds
Remove local workarounds to attempt to avoid crashes on skin change
2021-03-23 16:44:29 +09:00
d758343a45 Merge pull request #12149 from peppy/fix-score-token-data-type
Fix APIScoreToken's data type not matching server side
2021-03-23 14:54:02 +09:00
1171214541 Update framework 2021-03-23 14:51:22 +09:00
9c690f9545 Fix second usage 2021-03-23 14:08:00 +09:00
58c60100b4 Fix APIScoreToken's data type not matching server side 2021-03-23 14:04:47 +09:00
16b3f22caf Fix incorrect trash icon being used on deleted comments counter 2021-03-22 19:32:17 -07:00
073dba5330 Remove local workarounds to attempt to avoid crashes on skin change 2021-03-22 14:05:37 +09:00
9bc6cdf042 Fix singular format regression on forum post text 2021-03-21 11:19:07 -07:00
e31d583a7f Add comments count to user profile overlay 2021-03-21 11:16:59 -07:00
a16c0641b2 Revert EF Core to version 2.2
This reverts commit f3faad74d5, reversing
changes made to 712e7bc7bf.

Several issues arose after migrating to 5.0, including, but possibly not
limited to, performance regressions in song select, as well as failures
when attempting to save beatmaps after metadata changes in the editor.
2021-03-21 11:05:15 +01:00
86b569f5f7 Fix typo in identifier 2021-03-20 12:37:51 +01:00
d28bed6ed2 Schedule adding transforms on tablet changes
Fixes `InvalidThreadForMutationException`s that pop up when
disconnecting/reconnecting tablets during the game's operation. In those
cases the value change callback executes from  an OpenTabletDriver
thread.
2021-03-20 12:37:48 +01:00
b9b351311a Merge pull request #11824 from peppy/fix-unsafe-skinnable-sample-play
Fix playing skinned samples being unsafe during skin changes
2021-03-20 11:29:34 +09:00
ca943a897a Fix back to front initialisation order 2021-03-20 10:51:58 +09:00
dd48b68f8a Ensure selected blueprints are given selection priority 2021-03-19 22:44:33 +01:00
d54e9ab481 Merge pull request #12077 from peppy/tablet-configuration
Add tablet configuration section
2021-03-19 21:49:32 +09:00
5a6ff53837 Merge pull request #12073 from peppy/fix-crash-toggle-overlay-before-loaded
Avoid potential crash if an overlay is toggled before it has been loaded
2021-03-19 21:38:47 +09:00
e72205eea2 Merge pull request #12080 from peppy/add-25-playback-editor
Change editor speed adjust to adjust frequency (and restore 25% option)
2021-03-19 21:04:12 +09:00
68aaf90702 Fix disposal rather than performing some weird hack 2021-03-19 20:30:52 +09:00
f59327cc3e Merge branch 'master' into fix-unsafe-skinnable-sample-play 2021-03-19 20:29:44 +09:00
b2d8db3a92 Rename incorrect variable 2021-03-19 20:25:21 +09:00
63cbac3bd0 Ensure aspect ratio slider gets an initial value 2021-03-19 20:15:29 +09:00
6f32c302eb Add checkbox to optionally disable tablet handling 2021-03-19 20:13:51 +09:00
4da9089b00 Merge branch 'master' into tablet-configuration 2021-03-19 20:09:25 +09:00
095b7f8668 Rewrite code to account for non-loaded edge case 2021-03-19 20:09:12 +09:00
4795170c60 Add back the default json converter locally to ensure it's actually used 2021-03-19 20:07:13 +09:00
86b229b1c9 Increase maximum usable aspect ratio to account for ultrawide monitors 2021-03-19 20:05:18 +09:00
8955071703 Change editor speed adjust to adjust frequency 2021-03-19 20:01:45 +09:00
9be7981e0d Adjust timeline ticks to be more visible 2021-03-19 19:45:00 +09:00
c0c8b3e46c Fix regression meaning SkinnableSound initialisation may never happen 2021-03-19 19:22:50 +09:00
bd1e2da1c2 Always hide other overlays, even if the new one is not loaded 2021-03-19 19:09:39 +09:00
0736679016 Merge pull request #12072 from peppy/include-default-skin-in-random-rotation
Include the bundled skins when selecting a random skin
2021-03-19 19:08:42 +09:00
baf4e4e8f6 Merge branch 'master' into tablet-configuration 2021-03-19 19:06:58 +09:00
fefb007805 Remove no longer relevant comment 2021-03-19 19:01:32 +09:00
1e82033c84 Move bindings to LoadComplete to avoid cross-thread issues 2021-03-19 19:01:32 +09:00
b1c4ac9f42 Remove local implementation of Vector2Converter
This has been moved to framework in
https://github.com/ppy/osu-framework/pull/4285.
2021-03-19 19:01:32 +09:00
c624aa9397 Only update tablet values on commit 2021-03-19 19:01:32 +09:00