Commit Graph

3258 Commits

Author SHA1 Message Date
a249bb9e69 Merge branch 'master' into realm-key-binding-store 2021-05-25 17:18:33 +09:00
774611f142 Merge pull request #12933 from peppy/fix-scroll-wheel-gameplay-bindings
Disallow using scroll wheel for gameplay bindings
2021-05-25 16:04:18 +09:00
57640810b5 Ignore certain banned InputKeys for gameplay purposes 2021-05-24 18:40:40 +09:00
7a343c1576 Merge pull request #12915 from peppy/regenerate-replay-less
Ensure `RegenerateAutoplay` is only run once per frame
2021-05-24 17:25:42 +09:00
7494ddeef4 Fix DHOs not receiving initial skin changed events 2021-05-24 14:07:40 +09:00
bbfd7ea23f Ensure RegenerateAutoplay is only run once per frame 2021-05-23 21:20:08 +09:00
5ad41ded94 Merge branch 'master' into fix-dho-lmc 2021-05-21 19:11:57 +09:00
6beeb7f7c4 Rename SpectatorStreamingClient -> SpectatorClient 2021-05-20 15:55:07 +09:00
0489ae719d Don't couple PoolableDrawableWithLifetime lifetime with its entry
It turns out the incompatibility with `LifetimeManagementContainer` causes more issues than anticipated.
2021-05-20 14:56:15 +09:00
6c4709e7b4 Fix PlacementBlueprint using the wrong beatmap when applying defaults
Closes #12855.
2021-05-19 18:34:07 +09:00
ef81bdf63f Merge branch 'master' into always-use-lifetime-entry 2021-05-18 20:10:12 +09:00
84a1a86c63 Revert "Use entry to calculate lifetime in ScrollingHOC"
This reverts commit 632bb70e
2021-05-18 19:55:31 +09:00
2c65b8fa93 Revert "Fix uninitialized scrollLength value is used"
This reverts commit 73dfb04d
2021-05-18 19:55:25 +09:00
a96603f025 Merge pull request #12782 from smoogipoo/rework-hitobject-blueprints
Rename hitobject blueprints and tie them to HitObjects
2021-05-18 16:30:58 +09:00
882d54a8f8 Remove now unnecessary Apply() method 2021-05-18 14:26:26 +09:00
e621cfc4ea Add Apply() method for applying new DHOs 2021-05-18 14:14:10 +09:00
f1f3606fd0 Fix unresolved xmldocs 2021-05-18 13:11:58 +09:00
9d423245d8 Fix up xmldocs
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-05-18 13:02:23 +09:00
a32f1ef35a Merge pull request #12811 from PercyDan54/hidden-code-cleanup
Remove obsolete methods in `ModHidden` and apply few touches
2021-05-16 22:07:45 +09:00
bdcb1a624e Merge pull request #12759 from Naxesss/beatmap-verifier-context
Encapsulate check arguments in context object
2021-05-15 15:39:12 +09:00
166974506e Duplicate implementions 2021-05-15 11:55:50 +08:00
6e5c4ed7c6 Revert "Remove empty override"
This reverts commit a86a4bab91.
2021-05-15 11:45:14 +08:00
628e7a71ed Ignore possible nulls in Type.GetType() calls
They're mostly used in extensibility scenarios, so everything happens in
runtime. There is no better resolution than to crash with a null
reference exception.
2021-05-15 00:09:34 +02:00
a86a4bab91 Remove empty override 2021-05-14 21:55:32 +08:00
67dfeeb1b7 Cleanup code in ModHidden 2021-05-14 21:29:13 +08:00
fcb226bd20 Add local variable for regular access to HitObjects 2021-05-14 16:23:45 +09:00
a447f20095 Fix formatting of #nullable enable 2021-05-14 03:38:35 +02:00
90e0b3374e Add #nullable enable
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-05-14 03:34:50 +02:00
ffb6135a1b Rework hitobject blueprints to take in hitobject models 2021-05-13 19:53:32 +09:00
19800f5f7f Move IBeatmap arg into context 2021-05-13 11:24:22 +02:00
b37cb3bdbe Change interpreted difficulty from bindable to regular value
There's no reason for why checks would need this to be bindable. A 1-directional binding is more appropriate.
2021-05-13 09:00:30 +02:00
e7c7786db3 Merge branch 'master' into beatmap-verifier-context 2021-05-13 07:40:33 +02:00
5b71d8ca37 Merge pull request #12758 from Naxesss/verify-settings-ui
Add setting UI components to the verify screen
2021-05-13 14:35:35 +09:00
1b579dd838 Extract invariant instantiation info extension method 2021-05-12 23:23:51 +02:00
b7bc42e0d3 Rename "playableBeatmap" check arg to "beatmap"
The working beatmap is now in the context, so it's easier to distinguish beatmap type, hence no need for this prefix.
2021-05-12 02:34:16 +02:00
64d96b06a6 Add interpreted difficulty info to BeatmapVerifierContext
Enables checks to make use of the difficulty level as shown in the settings UI.
2021-05-12 02:30:21 +02:00
c13b93e6f1 Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.

See next commit for example.
2021-05-12 02:29:18 +02:00
75adec57eb Remove negligible default hidden TODO 2021-05-12 01:31:16 +02:00
2ecd638f7f Merge branch 'master' into skin-components-list 2021-05-10 18:13:10 +09:00
111b501ced Revert accidental removal of UTF-8 BOM 2021-05-07 18:04:38 +09:00
207f7f1e56 Rename FramedAutoGenerator<T> -> AutoGenerator<T> 2021-05-07 00:31:12 +09:00
ea35b72436 Remove unused IAutoGenerator interface 2021-05-06 22:57:07 +09:00
9be36230f9 Introduce AutoGenerator subclass for frame based replay generation 2021-05-06 21:59:11 +09:00
aff32b0d19 Merge branch 'master' into skin-components-list 2021-05-06 14:17:33 +09:00
aa42cf2fc0 Fix setting lifetime during KeepAlive is ignored 2021-05-04 16:56:48 +09:00
913fc8c3bc Revert the change of not adding non-pooled DHO to HOC until alive 2021-05-04 16:44:48 +09:00
36438175a0 Throw an exception if try to modify lifetime of PoolableDrawableWithLifetime without lifetime 2021-05-04 16:04:58 +09:00
943c497397 Return back removed using 2021-05-03 02:02:14 +03:00
b2130fc600 Fix replay frames sort instability 2021-05-03 01:58:44 +03:00
a551958eeb Move caching of IBeatmap to base DrawableRuleset 2021-05-01 21:32:45 +09:00