Commit Graph

1392 Commits

Author SHA1 Message Date
fcf767e28b Add contextmenu to beatmap external link 2022-07-25 04:07:33 -04:00
2dd99ef1fd Refactor FPSCounter to not use scheduled tasks
While on the surface this looks harmless (ignoring allocations),
`Scheduler` doesn't clear cancelled tasks until they reach their
execution time. This can cause an increase in time spent processing the
scheduler itself.

I don't think a per-frame updating component should use scheduled tasks
in this way in the first place, so I've just rewritten the logic to
avoid that overhead altogether.
2022-07-25 16:26:48 +09:00
4332e6cae9 Fix OsuSliderBar throwing on negative draw width 2022-07-24 08:34:24 +03:00
b9f5074c13 Merge branch 'fps-counter-no-rolling-counter' into fps-counter-cleanup 2022-07-22 02:22:01 +09:00
0eeafea500 Increase responsiveness to change slightly 2022-07-21 23:37:32 +09:00
c140601c2d Cleanup pass on FPSCounter 2022-07-21 23:02:31 +09:00
fc6445caea Rate limit updates for good measure 2022-07-21 22:55:45 +09:00
3d2603e0eb Remove unused classes 2022-07-21 22:51:35 +09:00
3fad481a96 Avoid using RollingCounter in fps counter
It wasn't made to be updated every frame, and it shows. Inaccurate for
reasons I'm not really interested in investigating, because I don't want
to incur the `Transorm` overhead in the first place for an fps counter.

Was only used originally out of convenience.
2022-07-21 22:50:02 +09:00
5db4d9437a Add missing using statement 2022-07-21 21:39:24 +09:00
6fac34c721 Merge pull request #19274 from peppy/fix-fps-counter-fps-inaccuracy
Fix draw FPS being inaccurate due to using `ElapsedFrameTime`
2022-07-21 20:55:14 +09:00
4c4939d18d Fix draw FPS being inaccurate due to using ElapsedFrameTime
Had a feeling this would be the case.

Basically, we're calculating on the update thread and checking the last
value of draw thread's `ElapsedFrameTime`. In the case that value is
spiky, a completely incorrect fps can be displayed.

I've left the spike display do use `ElapsedFrameTime`, as
`FramesPerSecond` is too averaged to see spikes.
2022-07-21 19:17:58 +09:00
fb728fbed1 Fix FPS counter not being wide enough to show large fps numbers 2022-07-21 18:56:39 +09:00
56106e43d2 Avoid div-by-zero 2022-07-21 13:06:43 +09:00
311a0a3de0 Always show counter temporarily when aim FPS changes 2022-07-21 12:57:40 +09:00
705ff06ea5 Better handle spikes and significant changes 2022-07-21 12:50:39 +09:00
285516b111 Fix isDisplayed never actually being set 2022-07-21 12:40:27 +09:00
728e22fbce Improve tooltip display when running single thread 2022-07-21 12:06:22 +09:00
e1a577ea48 Adjust spacing to make things feel more even
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-07-21 11:59:51 +09:00
57ecc3a6df Remove unnecessary negative spacing from thread names
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-07-21 11:59:26 +09:00
c7313b4198 Fix alignment glitching due to non-matching anchor/origin
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-07-21 11:58:28 +09:00
75453b78c0 Adjust colours and metrics 2022-07-21 00:09:46 +09:00
f54aff2ece Add global key binding for FPS toggle 2022-07-21 00:09:46 +09:00
0a1744faca Add to game and bind with configuration setting 2022-07-20 23:49:19 +09:00
0fb959a565 Stay displayed while hovering 2022-07-20 23:49:19 +09:00
03e644e548 Choose colours based on relative performance goals 2022-07-20 23:49:19 +09:00
0c3d43026d Add initial structure for fps counter 2022-07-20 23:49:19 +09:00
d6abdc597d correct label positioning 2022-07-11 17:12:41 -04:00
9bf91835b6 Merge pull request #18962 from peppy/slider-range-control
Move star difficulty filter to song select
2022-07-03 21:58:00 +09:00
b626135940 Fix dragging slider bars on nub not performing correctly relative movement 2022-07-02 17:49:38 +09:00
545df0a8e8 Display difficulty on nub 2022-07-01 15:17:26 +09:00
d54f7fc728 Move slider range control to song select 2022-07-01 14:41:36 +09:00
3785027284 Update OsuSliderBar colours to not use transparency 2022-07-01 14:41:36 +09:00
31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
f71f6302fd Remove unnecessary null casts 2022-06-24 14:50:11 +09:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
930ec2a197 Add specific samples for dialog 'Ok' and 'Cancel' buttons 2022-06-15 15:41:27 +09:00
396a566a0e Add some randomness to click samples 2022-06-03 22:33:11 +09:00
2878bb592f Use more appropriate sounds for certain components 2022-06-03 22:32:12 +09:00
365819865e Remove 'submit' sample usages 2022-06-03 22:31:35 +09:00
3847a586f1 Make GlobalAction.Back close all opened dropdown menus 2022-05-23 23:37:40 +02:00
21e1576b2f Fix appearance of sheared button borders after click
The border would previously get brighter after click, but then dim
instantly when the flash layer has fully faded out. The underlying issue
there is https://github.com/ppy/osu-framework/issues/5191, but
`ShearedButton` was placing the flashing layer incorrectly anyway, as
the intent was that it should also apply to the border.
2022-05-21 20:53:23 +02:00
a633501687 Change FilterTerms to use LocalisableString 2022-05-16 14:09:37 +09:00
8a559ff58a Merge pull request #18191 from frenzibyte/button-use-overlay-colour
Fix buttons no longer coloured using `OverlayColourProvider`
2022-05-10 12:14:10 +09:00
1fcfeac05f Fix RoundedButton not using its default background colour 2022-05-09 21:07:43 +03:00
ace25af949 Revert "Move default background colour specification to OsuButton"
This reverts commit 172524ff8a.
2022-05-09 20:55:26 +03:00
172524ff8a Move default background colour specification to OsuButton 2022-05-09 18:21:00 +03:00
70a90722e8 Fix dropdown item hover colour not being set in time
Turns out to be an osu!-side issue. The colour transform was being
shortcutted for the non-displayed case, which meant it was not in a good
state in time for the first hover.

Closes https://github.com/ppy/osu/issues/18163#issuecomment-1120747301
2022-05-09 19:49:45 +09:00
983eed32fc Reduce complexity of icon container nesting 2022-05-03 14:48:00 +09:00
b5ea26f2fa Fix incorrect shear masking on nested textbox 2022-05-03 14:45:17 +09:00