Commit Graph

26692 Commits

Author SHA1 Message Date
a3129ad00e Refactor BeatSyncedContainer to support GameplayClock 2021-07-15 14:37:13 +09:00
c0c14a6bda Merge pull request #13877 from bdach/osu-popover
Implement osu!-side popover
2021-07-14 23:52:56 +09:00
339fab75a8 Rename colour variable in line with other usages 2021-07-14 23:27:03 +09:00
c6116676eb Update framework 2021-07-14 23:23:48 +09:00
fdfd82aec4 Add elastic scale on appear 2021-07-14 23:23:44 +09:00
4b4c341fb8 Merge pull request #13884 from peppy/remove-read-from-difficulty
Remove `IApplicableToDifficulty.ReadFromDifficulty`
2021-07-14 13:10:34 +09:00
95d767bd0c Merge branch 'master' into fix-orange-hue 2021-07-14 12:32:45 +09:00
ed29646291 Remove IApplicableToDifficulty.ReadFromDifficulty
This was added specifically for `ModDifficultyAdjust`, but turned out to
be more of a headache than we expected. We have since removed usage and
would hope that this is not required by any other mods.

Opting for complete removal rather than obsoletion, as we discovered
this was already broken in multiple cases, with fixes being quite
logically complex.

If you happen to be a ruleset developer relying on this, open an issue
and we'll talk you through a better approach (or check what
`ModDifficultyAdjust` is doing now for an example).
2021-07-14 12:32:16 +09:00
48d5a3f94f Merge pull request #13866 from frenzibyte/remove-duplicates
Reference `OverlayColourProvider` static colours in `OsuColour`'s definitions xmldocs
2021-07-14 12:06:47 +09:00
80636be767 Link Lime1 and Orange1 to their OverlayColourProvider's alternative 2021-07-14 03:22:00 +03:00
b4961cd12e Revert "Remove duplicated colour definitions"
This reverts commit 9869986c59.
2021-07-14 03:18:13 +03:00
9bec53bfa8 Implement osu!-side popover 2021-07-14 01:05:06 +02:00
8d82412b39 Merge pull request #13851 from gagahpangeran/autolink-md
Add autolink support in osu markdown container
2021-07-13 19:40:53 +09:00
2436ebb6d3 Merge pull request #13874 from Naxesss/short-object-checks
Add object duration checks
2021-07-13 19:01:02 +09:00
4ce96109b7 Merge branch 'master' into fix-match-screen-buttons-no-user 2021-07-13 18:20:23 +09:00
0557761e51 Merge pull request #13862 from peppy/fix-multiplayer-create-game-failure-crash
Fix crash when multiplayer server join fails during game creation
2021-07-13 18:00:47 +09:00
e791669c40 Fix multiplayer screen buttons showing no text when local user not available 2021-07-13 17:59:58 +09:00
3a5912e35e Add new checks to verifiers 2021-07-13 10:53:25 +02:00
6da2a3d51f Add zero-length objects check and tests 2021-07-13 10:50:11 +02:00
60e17fc2b7 Fix disconnected-from-server multiplayer exit sequence being blocked by confirmation dialog 2021-07-13 17:12:35 +09:00
1c69da09d3 Merge branch 'master' into autolink-md 2021-07-13 15:04:36 +07:00
5cffaf4d3b Add extra explanatory comment to avoid any confusion 2021-07-13 14:34:56 +09:00
c7c691078a Merge branch 'master' into fix-multiplayer-create-game-failure-crash 2021-07-13 14:34:42 +09:00
35841fa4f7 Merge branch 'master' into fix-difficulty-bindable-bind-order 2021-07-13 13:42:53 +09:00
5cff379cd9 Merge pull request #13860 from smoogipoo/fix-bindable-ctor
Fix DifficultyBindable not binding correctly and not having default ctor
2021-07-13 13:42:44 +09:00
5af2190246 Merge branch 'master' into fix-bindable-ctor 2021-07-13 12:46:01 +09:00
ac15dae930 Update framework 2021-07-13 12:35:25 +09:00
351a46b379 Merge pull request #13823 from ekrctb/catch-editor-tests
Add some tests for catch editor blueprints
2021-07-13 08:27:41 +09:00
cce4a4dc31 Fix incorrect value copy order in BindTo() 2021-07-12 22:27:36 +02:00
821c1b5335 Update hue of green colour scheme 2021-07-12 19:11:40 +03:00
62a00a82de Revert completely irrelevant changes
This reverts commit b2b966463a.
2021-07-12 19:11:28 +03:00
b2b966463a Update hue of green colour scheme 2021-07-12 19:05:36 +03:00
c96a76df67 Update specified link 2021-07-12 18:21:10 +03:00
1437772711 Update hue of orange colour scheme 2021-07-12 18:11:51 +03:00
9869986c59 Remove duplicated colour definitions 2021-07-12 17:55:29 +03:00
1deaefacb7 Add "basic" lime colour theme 2021-07-12 17:53:15 +03:00
c6bd58ea4b Exit match sub screen when a room goes away
Closes #13847.

I think we can probably get some test coverage of this if required, but
needs a bit of thought (basically an error needs to be thrown during the
multiplayer client portion of the join procedure, after `CurrentRoom` is
non-null but before the join completes).

Manual testing on password branch (#13861) is possible since it
currently errors due to missing method on the live/dev servers.

- Create game, which will fail with `MethodNotExists`.
- Note the fields on the settings screen are emptied.
- Fill fields again and press create game (crash).
2021-07-12 19:20:41 +09:00
4b393209ec Implement UnbindFrom() 2021-07-12 17:33:29 +09:00
242982730f Fix incorrect DifficultyBindable binding implementation 2021-07-12 17:09:09 +09:00
36dd2c36de Merge pull request #13859 from peppy/update-realm-win-81-fix
Update realm libraries to fix windows 8.1 incompatibility
2021-07-12 16:40:35 +09:00
d5d7dd0e74 Merge pull request #13701 from frenzibyte/consume-bindable-current-factory
Fix `RestoreDefaultValueButton` not behaving correctly on number types
2021-07-12 14:49:00 +09:00
f548ba4f69 Update realm libraries to fix windows 8.1 incompatibility 2021-07-12 14:07:17 +09:00
0c52b26d23 Merge pull request #13824 from peppy/da-mod-refactor
Refactor `ModDifficultyAdjust` to more elegantly track user override status
2021-07-12 12:03:45 +09:00
a6258d705e Make CurrentNumber internal 2021-07-12 11:26:30 +09:00
32b4f5fbd6 Do not store direct references to original bindable
`DifficultyAdjustSettingsControl` and its inner `SliderControl` were
holding different references to `DifficultyBindable`s from the
difficulty adjust mod, therefore leading to bindings being lost to the
framework-side automatic unbind logic if the mod was toggled off and
back on in rapid succession.

Resolve by adding a shadowed implementation of `GetBoundCopy()` and
using it to isolate the controls from the mod bindable.
2021-07-11 15:28:13 +02:00
f21ea3b790 Update player test scene Ruleset bindable from creation method 2021-07-11 03:46:19 +03:00
07ede7a147 Disallow custom rulesets from score submission 2021-07-11 03:34:57 +03:00
c44558e3c8 Add back LoadComplete override 2021-07-10 17:57:52 +03:00
1bd5b1a8b9 Merge branch 'master' into fix-access-denied-test-failures 2021-07-10 13:00:27 +02:00
e4f13e311e override add auto link in text flow container 2021-07-10 17:58:00 +07:00