Commit Graph

36718 Commits

Author SHA1 Message Date
9a4f0cad2c Fix incorrect domain root being used for recent activity entries on profile overlay
Closes https://github.com/ppy/osu/issues/21980.
2023-01-01 17:48:05 +08:00
87250ad847 Add search keywords for beatmap colours / hitsound overrides 2023-01-01 14:32:28 +08:00
0d70f2c0fd Use alternative workaround 2022-12-30 09:08:17 +01:00
f625c5d744 Fix gradient showing when toggling toolbar with mouse above window 2022-12-29 23:35:45 +01:00
bf975eb48a Fix toolbar gradient not showing when mouse is hovered over buttons 2022-12-29 23:03:53 +01:00
ccf713c885 Fix incorrect hard link validity check in stable import screen 2022-12-29 23:18:12 +08:00
0fcf10e10a Also support hard links on macOS 2022-12-29 22:35:13 +08:00
f9f6918fc3 Merge branch 'master' into add_linux_hardlink 2022-12-29 21:29:57 +08:00
c5f7da9a4e Fix hover propagating through toolbar buttons
Closes #21920.

Weirdly enough this was semeingly fixed once before in ancient times in
3891f467a3, but then unfixed again in
566e09083f. The second change is no longer
needed since the toolbar became opaque in #9447.
2022-12-29 13:19:14 +01:00
74bc5d4666 Disable naming rule inspection on struct stat definition 2022-12-28 22:38:42 +01:00
10c11e974d Fix broken spacing 2022-12-28 22:24:21 +01:00
49b0ec9ddb Fix broken condition 2022-12-28 22:24:18 +01:00
8d79fa93ac Implement GetFileLinkCount() for Linux 2022-12-28 22:14:56 +01:00
d4b3965967 Change warning message about file duplication
- It was being glued in an ugly way that would have prevented sanely
  localising it.

- Even on Linux, the filesystem (whichever one the user has chosen out
  of the multitude available) still needs to support hard links for them
  to have a chance of working.
2022-12-28 22:04:08 +01:00
04d4b4a6ce Rename and xmldoc hard link creation method 2022-12-28 22:04:05 +01:00
cadd487c75 Use switch statement in AttemptHardLink() 2022-12-28 21:20:49 +01:00
2c346eae0d Revert inlining of hard link creation into condition
Just feels bad. Mixing data access with actual underlying logic.
2022-12-28 21:19:28 +01:00
d63be3ff17 Change name of variable 2022-12-28 15:02:44 +01:00
c6da7248ba Remove unnecessary directive 2022-12-28 14:40:32 +01:00
53bca947d1 Move duplicated code into its own method 2022-12-28 14:34:27 +01:00
f32564652b Mention the filesystem should be NTFS on Windows 2022-12-28 14:33:38 +01:00
5c5e84f931 Fix formatiing 2022-12-28 14:06:50 +01:00
ea8beffa61 Merge pull request #21871 from bdach/solo-statistics-watcher-reliability
Improve reliability of solo statistics watcher
2022-12-28 21:05:38 +08:00
16165b1f67 Remove blank line 2022-12-28 13:58:52 +01:00
e4c060fc3a Merge pull request #21854 from peppy/fix-website-root
Fix `osu.ppy.sh` links no longer opening in-game
2022-12-28 13:43:24 +01:00
b2aa2e1602 Add hardlink support for Linux 2022-12-28 13:32:49 +01:00
4b71ccf315 Merge pull request #21879 from frenzibyte/first-object-visbility-keywords
Add keywords to ease search of "first object visibility" setting
2022-12-28 12:15:34 +01:00
b4c5e18da0 Add keywords to ease search of "first object visibility" setting 2022-12-28 13:23:50 +03:00
3c0b8af8f1 Allow unsubscribing from solo statistics updates
This is more of a safety item. To avoid potential duplicate key in
dictionary errors (and also avoid being slightly memory-leaky), allow
`SoloStatisticsWatcher` consumers to dispose of the subscriptions they
take out.
2022-12-28 08:07:48 +01:00
04f9a354c3 Convert SoloResultsScreen to NRT 2022-12-28 07:54:36 +01:00
a0a26b1e8c Ignore statistics update subscriptions with invalid score ID
If score submission fails, the score will not receive a correct online
ID from web, but will still be passed on to the solo statistics watcher
on the results screen. This could lead to the watcher subscribing to
changes with score ID equal to the default of -1. If this happened more
than once, that would cause a crash due to duplicate keys in the
`callbacks` dictionary.

Closes #21837.
2022-12-28 07:54:01 +01:00
e9d32fca18 Fix various failures in initial statistics fetch
- If the local user is restricted, then attempting to fetch their data
  from the `/users` endpoint would result in an empty response.

- Even if the user was successfully fetched, their `RulesetsStatistics`
  may not be populated (and instead be `null`). Curiously this was not
  picked up by static analysis until the first issue was fixed.

Closes #21839.
2022-12-28 07:31:36 +01:00
0d78bc2248 Fix osu.ppy.sh links no longer opening in-game
Addresses https://github.com/ppy/osu/discussions/21838.
2022-12-28 06:42:35 +08:00
e90619244d Fix incorrect accuracy display on overall ranking view 2022-12-27 19:51:51 +01:00
ae2058b55e Merge branch 'master' into split_trimentries 2022-12-27 18:07:36 +01:00
1a4489edb2 Move version pinning of system packages to osu.Game 2022-12-27 14:58:18 +03:00
61029b126d Add link to hard link explanation wiki page 2022-12-27 17:56:23 +08:00
b3e44f20bc Use new lazer API endpoint
This is a temporary change to target the new experimental/next deploy.
The main change that should result from this is having the user profile
show the pp^next values from the new domain.
2022-12-27 17:20:40 +08:00
182f36c434 Use StringSplitOptions.TrimEntries for string.Split() when possible 2022-12-27 09:41:58 +01:00
df6f2ad0a1 Merge pull request #21804 from bdach/hide-global-rankings-when-presenting-scores
Only show global rankings on solo results screen when progressing from gameplay
2022-12-27 16:39:26 +08:00
777ffcf805 Highlight "open" option on external link button context menu 2022-12-26 20:47:24 -08:00
01cf96e240 Only show global rankings on results screen when progressing from gameplay 2022-12-26 23:35:45 +01:00
cb2b0d4178 Remove redundant type specs 2022-12-26 23:12:53 +01:00
fcbb21c75e Fix typo 2022-12-26 20:38:35 +01:00
c7ca4bbba5 Use generic Enum methods 2022-12-26 20:36:39 +01:00
e416bdd06b Merge branch 'master' into remove_obsolete_star_colours 2022-12-26 16:35:47 +01:00
fbff5d8d69 Remove obsoleted "ForDifficultyRating" method 2022-12-26 16:16:52 +01:00
5dd03c6c60 Update framework 2022-12-26 21:53:52 +08:00
786d94c149 Merge pull request #21792 from Joehuu/fix-parameters-inspection
Fix parameters with the same default value inspection
2022-12-26 15:41:54 +09:00
09cc41604f Merge branch 'master' into score-stats-on-results 2022-12-26 13:37:36 +08:00