Commit Graph

26849 Commits

Author SHA1 Message Date
a5736085a9 Ensure externally run operations on LoungeSubScreen are run after load is completed 2021-07-23 02:23:37 +09:00
ec3ce57bb9 Fix song select background not showing in multiplayer/playlists
The screen was now being loaded against incorrect dependencies. I'm not
sure why I thought it wasn't possible to just do the `Push` in
`LoadComplete` as it seems to work without issue this time...

Closes #13974.
2021-07-22 14:33:08 +09:00
ea4f9b2ac7 Localise beatmap online status pill. 2021-07-21 13:15:07 +02:00
032ced5d16 Localise beatmap explicit content pill. 2021-07-21 13:05:01 +02:00
fe9e72d767 Merge pull request #13959 from smoogipoo/fix-beatmaplisting-null-cursor
Fix beatmap listing continually paginating when no more beatmaps are available
2021-07-21 19:55:40 +09:00
4c63e8e036 Merge pull request #13964 from peppy/fix-mod-overflow
Fix mod display overflowing on contracted results panels
2021-07-21 18:52:00 +09:00
adda96ac86 Merge pull request #13962 from ekrctb/platform-action
Adapt to framework `PlatformAction` type change
2021-07-21 18:17:38 +09:00
a261f1ef8f Merge pull request #13960 from ekrctb/selection-box-can-flip
Allow specifying different value of scaling and flipping support for a selection box
2021-07-21 18:05:18 +09:00
b390018e64 Merge branch 'master' into fix-mod-overflow 2021-07-21 17:26:47 +09:00
b556d6d382 Merge pull request #13963 from peppy/tidy-mod-display
Tidy up `ModDisplay`
2021-07-21 17:26:39 +09:00
173334383f Update framework 2021-07-21 16:56:09 +09:00
b910c21230 Add ModFlowDisplay and consume in ContractedPanelMiddleContent 2021-07-21 16:53:04 +09:00
b65e607941 Add test covering mod displays with too many mods 2021-07-21 16:43:41 +09:00
5bee06fd5f Remove forgotten AutoSize specification 2021-07-21 16:43:29 +09:00
396ad79d50 Remove unnecessary UnbindAll call 2021-07-21 16:43:08 +09:00
a63065dbe9 Tidy up ModDisplay 2021-07-21 16:38:25 +09:00
1bac471b49 Adapt to PlatformAction type change 2021-07-21 16:12:53 +09:00
bcd1a3c232 Use existing bool 2021-07-21 16:04:07 +09:00
1bff4373b3 Allow specifying flipping support of selection box different from scaling 2021-07-21 15:59:45 +09:00
0118c3638c Fix beatmap listing continually paginating for null cursors 2021-07-21 15:59:02 +09:00
3121836741 Merge pull request #13942 from peppy/fix-autoplay-results-timestamp
Avoid showing time of play on results screen when autoplay
2021-07-21 15:37:31 +09:00
747c475b95 Merge pull request #13932 from peppy/fix-multiple-request-completion-states
Fix API request potentially firing failed events after completion
2021-07-21 15:11:03 +09:00
59dd3452fe Merge pull request #13954 from bdach/user-profile-beatmap-api-adjustments
Adjust user beatmap section naming on profile overlay to match web
2021-07-21 08:21:10 +09:00
db9cf443c7 Allow confirming room password by pressing Enter 2021-07-21 00:04:51 +02:00
1e634d9db0 Adjust user beatmap sections on profile overlay to match web 2021-07-20 21:55:17 +02:00
738d321788 Merge pull request #13946 from peppy/fix-online-play-sub-screens-not-async-loaded
Fix `OnlinePlayScreen` sub-screens not loaded asynchronously
2021-07-20 19:51:13 +09:00
d066ebcd70 Merge pull request #12682 from frenzibyte/refactor-combo-colour-retrieval
Refactor combo colours retrieval to use skin config lookups instead
2021-07-20 19:47:57 +09:00
8e1f8c28bd Use default value to denote no play date, rather than null 2021-07-20 19:05:08 +09:00
1a8ab77f21 Revert nullability change 2021-07-20 19:03:29 +09:00
15127f972e Merge branch 'master' into fix-online-play-sub-screens-not-async-loaded 2021-07-20 18:47:41 +09:00
d87ea741ed Fix OnlinePlayScreen sub-screens not loaded asynchronously 2021-07-20 16:38:39 +09:00
1af230c48c Merge branch 'master' into refactor-combo-colour-retrieval 2021-07-20 10:08:25 +03:00
fe414b942f Ensure online play subscreen is loaded before forwarding OnExiting
Closes https://github.com/ppy/osu-framework/issues/4619 (actually not a
framework issue; the framework correctly guards against this scenario,
see
4e29504384/osu.Framework/Screens/ScreenStack.cs (L277)).

Added the assertions to be very explicit about the nested stack's state
at this point. Both of those events can only be triggered if the stack
has a loaded screen (as far as I can tell), making this check
unnecessary in those cases.
2021-07-20 15:51:34 +09:00
662822a40c Avoid showing time of play on results screen when autoplay
Closes https://github.com/ppy/osu/issues/13940.
2021-07-20 15:19:44 +09:00
6cc81c24b4 Merge pull request #13785 from ekrctb/dependency-providing-container
Add a convenient way to provide ad-hoc dependency to children in visual test
2021-07-20 14:18:17 +09:00
9ea1f5900a Don't consider version suffixes when checking for updates
This is just to make life easier for me with deploys for now.
2021-07-20 01:05:37 +09:00
e77597c2b6 Merge pull request #13921 from Game4all/localise-profile-overlay
Localise user profile overlay
2021-07-20 00:37:01 +09:00
844152e1b1 Merge pull request #13861 from peppy/add-password-support
Add multiplayer room password support
2021-07-19 23:32:28 +09:00
6e104fe084 Merge pull request #13894 from peppy/fix-beat-synced-container-alt
Fix multiple issues with `BeatSyncedContainer`
2021-07-19 23:19:20 +09:00
6a55cb9df0 Revert unintended change
It's a deeper issue with ScreenStack (see:
https://github.com/ppy/osu-framework/issues/4619).
2021-07-19 22:52:07 +09:00
57a99886d5 Fix password icon not disappearing when no password 2021-07-19 22:31:01 +09:00
892d858d5f Fix compile error 2021-07-19 22:23:31 +09:00
b7c2d6b1ab Merge branch 'master' into add-password-support 2021-07-19 22:23:09 +09:00
5ef1fe6948 Merge branch 'master' into fix-replay-date 2021-07-19 21:58:37 +09:00
f3bcaf7f11 Merge pull request #13929 from peppy/i-deep-cloneable
Create a deep clone of score for score submission purposes
2021-07-19 21:58:27 +09:00
0a43e54dfc Fix request failing due to parameters 2021-07-19 21:24:22 +09:00
a001e4aa16 Fix web request failing if password is null 2021-07-19 20:57:16 +09:00
3168a927dc Fix possible exception 2021-07-19 20:50:30 +09:00
80c2b1449b Fix API request potentially firing failed events after completion
Specifically, `Cancel()` calls were not thread safe. Due to a series of
events, `ListPollingComponent` could call `Cancel` from a non-update
thread, leading to a race condition where both a `Success` and `Fail`
event can be fired.

This is intended to be the simplest fix possible, locking and guarding
specifically on the callbacks. Further work could be done in the future
to improve the flow surrounding `pendingFailure`, potentially reducing
redundant work and cleaning up the code, but that's not happening here.

Closes https://github.com/ppy/osu/issues/13632.
2021-07-19 20:27:01 +09:00
2eec524f27 Fix password not copied from multiplayer client 2021-07-19 20:20:08 +09:00