a8c9ad73c1
Make UR Counter isValid into a bindable boolean
2021-11-07 18:06:13 -07:00
cc0bcf6b2c
Clean up judgement checks and clean up setter/getter for UR counter Text
2021-11-07 17:44:50 -07:00
77e853ce25
Optimized UR Counter and removed redundant code
2021-11-05 12:16:58 -06:00
8bfcb89221
Fixed issue where UR counter was always invalid
2021-11-04 21:24:25 -06:00
0ffd41bb70
Slight logical error in the setValid method
2021-11-04 14:32:28 -06:00
8923561b05
Removed Unnessicary class in the Test file, and optimized UR counter
2021-11-04 14:27:48 -06:00
a76878e053
A bit more formatting
2021-11-04 09:52:16 -06:00
c568888500
Edited to remove unessicary blank lines
2021-11-04 09:47:52 -06:00
9aa3021bbc
Added Unstable Rate Counter as a skinable element
2021-11-03 22:22:44 -06:00
8d40d55d93
Update framework
2021-11-03 17:09:49 +09:00
d85224d7ad
Merge branch 'master' into localisable-text-flow
2021-11-03 17:09:46 +09:00
900549a771
Merge pull request #15398 from bdach/beatmap-card-basics
...
Add basic elements of new beatmap cards
2021-11-03 15:35:29 +09:00
cf7545e36c
Merge branch 'master' into beatmap-card-basics
2021-11-03 00:11:03 +01:00
1813681fac
Move private method below protected
2021-11-03 00:10:50 +01:00
75e89f17ad
Rewrite BeatmapCardContentBackground
2021-11-03 00:07:03 +01:00
494d582830
Fix PlaylistItem attempting to read from OsuColour dependency too early
2021-11-02 23:19:45 +01:00
195a141625
Fix score tracker not tracking non-online scores correctly
2021-11-02 22:51:25 +01:00
e4e8390a8a
Update ScreenEntry colour usage to update correctly on language change
2021-11-02 21:42:03 +01:00
d218e7d935
Remove manual romanisation handling in PlaylistItem
2021-11-02 21:42:02 +01:00
ed00cd9fc5
Remove simple localisable .ToString() calls
2021-11-02 21:42:02 +01:00
11de924704
Use LocalisableStrings where possible to leverage localisable text flow
2021-11-02 21:42:02 +01:00
ad98ab0a26
Fix drawable room playlist item assuming single sprite text
2021-11-02 21:42:02 +01:00
b95c95527e
Accept LocalisableStrings in LinkFlowContainer
2021-11-02 21:42:01 +01:00
98367fc482
Update usages of GetLocalised{-> Bindable}String
2021-11-02 21:42:01 +01:00
47914c49ba
Fix missed null consideration
2021-11-03 04:54:36 +09:00
fe9b8f3274
Merge pull request #15432 from peppy/fix-beatmap-availability-potentially-wrong
...
Fix multiplayer potentially getting incorrect beatmap availability state after changing beatmaps
2021-11-03 04:54:22 +09:00
5ea901da2e
Merge pull request #15429 from peppy/fix-beatmap-download-notifications
...
Fix beatmap download notifications not showing beatmap name correctly
2021-11-03 04:36:59 +09:00
a97e5fbd89
Merge pull request #15431 from peppy/fix-unauth-api-requests
...
Fix unauthenticated API requests no longer working
2021-11-03 04:35:48 +09:00
85037dfb70
Fix multiplayer potentially getting incorrect beatmap availability state after changing beatmaps
2021-11-03 04:32:21 +09:00
cb5c6e1924
Merge pull request #15427 from peppy/fix-multiplayer-panel-star-rating-display
...
Fix multiplayer panels not correctly showing star rating
2021-11-03 04:21:01 +09:00
f67f42dc5b
Merge pull request #15430 from bdach/fix-multi-submission
...
Fix multiplayer score submission not working
2021-11-03 04:10:23 +09:00
51e92e1b2d
Check for null/empty instead
2021-11-03 04:09:31 +09:00
8d0b32981f
Fix unauthenticated API requests no longer working
2021-11-03 03:30:15 +09:00
392559ae3e
Fix beatmap download notifications not showing beatmap name correctly
2021-11-03 03:23:41 +09:00
c028275d6c
Fix multiplayer score submission not working
2021-11-02 19:16:44 +01:00
6efd3d3115
Don't perform background difficulty calculation for multiplayer panels
...
There are cases these are shown in a long list. They shouldn't be
running calculations.
2021-11-03 03:12:52 +09:00
08b0ffad50
Fix incorrect check for local beatmap in BeatmapDifficultyCache
...
This was correct in the WIP branch I have, but pulled out alone (where
usages of `ToBeatmapInfo` still exist) it was not enough.
2021-11-03 03:12:52 +09:00
c85a4dca28
Fix crash when attempting to view global leaderboards
2021-11-03 02:47:33 +09:00
73b09f3b3d
Merge pull request #15409 from smoogipoo/fix-pp-counter-rate-adjust
...
Fix PP counter showing incorrect values with rate adjustment mods
2021-11-03 00:06:13 +09:00
81aaef719f
Add xmldoc to CalculateTimed()
2021-11-02 17:55:00 +09:00
168a7a588b
Add xmldoc to ctor also
2021-11-02 17:19:14 +09:00
efba7a9c4d
Missed hyphen
2021-11-02 17:18:02 +09:00
0cdd2898fe
Expose non-adjusted time from CalculateTimed()
2021-11-02 17:17:14 +09:00
135df0e190
Avoid adding null users to RecentParticipants
2021-11-02 17:13:37 +09:00
1bfa1365a0
Rename "null user" tests to better explain purpose
2021-11-02 17:13:37 +09:00
b0bd39fc49
Fix multiplayer room participants display not updating as new users join/leave
...
Can add tests on request, but not sure the code around this area is here
to stay permanently. Should be pretty low risk.
- Closes https://github.com/ppy/osu/issues/14788 .
2021-11-02 17:13:37 +09:00
eaeee80a26
Fix PP counter showing incorrect values with rate adjustment mods
2021-11-02 16:55:20 +09:00
6f941a8916
Merge pull request #15405 from peppy/legacy-decoder-default-section
...
Default legacy decoder to `General` section, rather than none
2021-11-02 15:42:25 +09:00
1e9211c00b
Use explicit type
2021-11-02 15:41:25 +09:00
5d784b2ef8
Perform a consistency check by decoding the newly written skin.ini during ComputeHash
...
As this has regressed twice now, let's play it safe and bail rather than
stack overflowing. Note that as all the underlying issues that could
trigger this have been fixed, no additional tests have been added. To
test, comment out `SkinManager.cs` line 228-229 to cause a failure. The
new logic will kick in and show a log output message, but all tests will
still (correctly) pass.
2021-11-02 14:11:25 +09:00
