Commit Graph

367 Commits

Author SHA1 Message Date
17fa2426d4 Merge branch 'master' into legacy-skin-resource-improvements 2021-05-31 19:36:09 +09:00
b16d10bd95 Provide game-wide resources via IStorageResourceProvider 2021-05-31 18:57:47 +09:00
675fe37446 Change check order around to ensure re-fetches which return no results don't nullref 2021-05-31 18:35:18 +09:00
06bd696cc2 Remove previous consumption logic in GetWorkingBeatmap
This should not be required since the introduction of `workingCache`,
which does the same thing in a more global way.
2021-05-31 14:11:58 +09:00
ab077c6656 Merge branch 'master' into non-nullable-beatmapset-files 2021-05-31 00:10:03 +02:00
78213e09d4 Merge branch 'master' into editor-exit-stability 2021-05-30 23:03:50 +02:00
8652ac05db Merge branch 'editor-exit-stability' into non-nullable-beatmapset-files 2021-05-28 18:58:35 +09:00
ee5eb9576f Fix completely wrong conditional logic 2021-05-28 18:38:50 +09:00
581a86b91a Revert "Revert "Fix editor tests failing due to empty files being specified""
This reverts commit 1af684c4b2.
2021-05-28 14:33:06 +09:00
41733af0ed Revert "Revert "Make BeatmapSetInfo.Files non-nullable""
This reverts commit 9c4f39e968.
2021-05-28 14:33:05 +09:00
b349ff8693 Revert "Add temporary accounting for tests with null files"
This reverts commit e52c0a34f8.
2021-05-28 14:33:04 +09:00
e52c0a34f8 Add temporary accounting for tests with null files 2021-05-28 14:31:26 +09:00
9c4f39e968 Revert "Make BeatmapSetInfo.Files non-nullable"
This reverts commit c24712642c.
2021-05-28 14:15:28 +09:00
1af684c4b2 Revert "Fix editor tests failing due to empty files being specified"
This reverts commit fdbd421040.
2021-05-28 14:15:28 +09:00
4f6de6fdc6 Implement GetSkin() for other working beatmaps 2021-05-21 20:21:29 +03:00
c24712642c Make BeatmapSetInfo.Files non-nullable 2021-05-20 17:39:52 +09:00
fdbd421040 Fix editor tests failing due to empty files being specified 2021-05-20 17:09:55 +09:00
7980bdd384 Revert incorrectly changed requery code 2021-05-20 15:41:58 +09:00
a639132825 Avoid doing any re-fetch on beatmap from test scenes 2021-05-19 17:58:28 +09:00
400f8b3938 Add GetStream to IWorkingBeatmap
This is necessary to obtain the filesize of the audio and background files.
2021-04-17 17:47:13 +02:00
a16c0641b2 Revert EF Core to version 2.2
This reverts commit f3faad74d5, reversing
changes made to 712e7bc7bf.

Several issues arose after migrating to 5.0, including, but possibly not
limited to, performance regressions in song select, as well as failures
when attempting to save beatmaps after metadata changes in the editor.
2021-03-21 11:05:15 +01:00
eda891223c Start the editor with empty artist/creator/difficulty name fields 2021-03-17 16:47:12 +09:00
0a1e325fc7 Extract requerying of navigational properties from DbContext 2021-03-14 19:34:53 +03:00
47b80d2474 Workaround InvalidOperation exceptions 2021-03-11 20:51:54 +03:00
b1cd01ceb8 Apply ConfigureAwait changes to game side 2021-03-08 14:36:35 +09:00
103dd4a6ce Remove WorkingBeatmap's finalizer 2021-03-02 16:14:43 +09:00
a080a9bdbc Merge pull request #11603 from Game4all/handle-stable-imports-custom-songs-folder
Handle beatmap import from a stable installation with a custom Songs directory
2021-02-12 21:42:36 +09:00
5f23bd7259 Revert most of the changes to ArchiveModeManager by using better code 2021-02-12 12:48:32 +09:00
383c40b992 Address remaining reviews suggestions. 2021-01-26 20:35:42 +01:00
9f9206726a Fix typos. 2021-01-26 18:11:54 +01:00
51d4da565c Fix ArchiveModelManagers lookup paths. 2021-01-24 22:25:49 +01:00
24e991a5ef Actually return beat length and not BPM 2021-01-15 14:35:09 +09:00
c6e9a6cd5a Make most common BPM more accurate 2021-01-15 14:28:49 +09:00
a97a2b2a66 Add nullability to BeatmapManager's GameHost reference 2020-12-22 12:03:25 +09:00
10c2745682 Add region specifications around implicit interface implementations 2020-12-22 12:01:09 +09:00
a5bcf1dc20 Expose resources to skin via interface (and share common pieces with beatmap) 2020-12-21 15:18:52 +09:00
0ffbe12fcc Expose resources to beatmaps in a saner way 2020-12-21 14:22:34 +09:00
7c804be4d3 Rename textureStore to make its purpose more clear 2020-12-21 14:06:33 +09:00
dfbc0965e4 Merge branch 'master' into peppy/skinnable-health-display 2020-10-16 23:17:17 +09:00
e89c5c3b3c Add dynamic compile exceptions to fix skin test scenes 2020-10-16 17:08:46 +09:00
88ffcb9234 Update EndsWith usages 2020-10-16 12:58:34 +09:00
50eca202f4 User IEnumerable for HandledExtensions 2020-10-02 16:17:10 +09:00
50ba320a51 Expand available file operations in ArchiveModelManager 2020-09-25 13:16:30 +09:00
5b93752065 Merge pull request #10103 from smoogipoo/disable-online-lookups-tests
Disable online beatmap lookups in tests
2020-09-09 21:21:04 +09:00
aeae009512 Disable online beatmap lookups in tests 2020-09-09 20:12:40 +09:00
2cd07b2d3c Fix editor crash on saving more than once
I'm fixing this in the simplest way possible as this kind of issue is
specific to EF core, which may cease to exist quite soon. Turns out the
re-retrieval of the beatmap set causes concurrency confusion and wasn't
actually needed in my final iteration of the new beatmap logic.
2020-09-09 12:48:12 +09:00
9ab6d584d3 Merge branch 'master' into editor-new-beatmap 2020-09-07 14:30:41 +09:00
e17ccdfe9f Merge branch 'master' into combo-colors 2020-09-07 13:55:41 +09:00
fba253f131 Take user argument in CreateNew method parameters 2020-09-04 13:17:43 +09:00
d32b77f045 Add missing extension to filename
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2020-09-03 21:33:25 +09:00