Commit Graph

2170 Commits

Author SHA1 Message Date
eb0f30c641 Use scroll speed localisation in one more usage 2023-01-16 13:28:45 +09:00
d19b35bd5f Rename ambiguous translation keys 2023-01-16 13:18:49 +09:00
6f84641596 Localise osu!mania settings 2023-01-15 23:30:20 +03:00
f03677f394 Remove HP drain from mania 2023-01-11 13:01:18 +09:00
98483d2a1b Merge pull request #21638 from Mogiiii/touchscreen-control-disable-mouse
Disable touchscreen controls responding to mouse in scrolling gamemodes
2023-01-06 20:39:09 +08:00
5e9fb1063a Move judgement text creation to base class and tidy things up 2022-12-24 12:22:36 +08:00
03603f8b54 Don't show great or higher judgements when using argon "pro" skin 2022-12-24 03:35:44 +08:00
727ac00f6d Combine base class for JudgementPiece 2022-12-24 03:32:13 +08:00
08d2fbeb8e Use new ArgumentNullException.ThrowIfNull throw-helper API 2022-12-22 21:27:59 +01:00
0a49c8c5d6 Add missing unsubscriptions in multiple mania components 2022-12-21 20:22:40 +01:00
d6cae991da Update netstandard2.1 references to net6.0 2022-12-16 17:16:13 +09:00
ee945c9b58 disable mouse input to touchscreen controls 2022-12-14 10:34:21 -05:00
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
57723107dd Fix osu!mania hold notes occasionally getting in a visually incorrect hit state
To correctly end a mania hold note, `endHold()` needs to be called. This
was not happening in a very specific scenario:

- The hold note's head is not hit
- The user pressed the column's key within the hold note's tail's window,
  but does so to hit the next object (a note in proximity to the hold note's tail).
- The hit policy forces a miss on the hold note, but `endHold()` is not called
- `CheckForResult` is not called after this point due to `Judged` being `true`.

Closes #21311.
2022-11-22 16:15:34 +09:00
b404b87f68 Realign white line on argon hold note ends to match hit target 2022-11-21 18:26:53 +09:00
1aa0e40f2f Add "Component" prefix to lookup naming 2022-11-09 17:46:43 +09:00
c908969d9b Rename ISkinComponent to ISkinLookup 2022-11-09 17:46:43 +09:00
a6165ea78a Apply nullability to osu!mania skinning classes 2022-11-09 13:58:58 +09:00
37407293aa Adjust target and hold off mod multipliers 2022-11-01 17:57:20 +09:00
92ab39f5c2 Fix hold note disappear instantly 2022-10-25 19:16:23 +09:00
8bf4ca4b53 Add legacy skin fallback when beatmap skin is providing resources 2022-10-12 17:47:20 +09:00
b444f0fd0b Merge pull request #20714 from frenzibyte/improve-flashlight-on-break
Improve flashlight display on break periods
2022-10-12 13:10:12 +09:00
a5948e7680 Merge pull request #20704 from ekrctb/scrolling-drag-box
Anchor editor drag box on time (catch, mania)
2022-10-12 11:48:05 +09:00
84fdd2e107 Improve flashlight display on break periods 2022-10-11 17:16:57 +03:00
ac2c986ff5 Merge pull request #20679 from peppy/remove-duplicated-colour
Remove duplicated colour in osu!mania argon skin column colouring
2022-10-11 17:44:34 +09:00
f41b79688f Avoid casting by accepting all Playfields but throwing on a bad choice 2022-10-11 16:54:41 +09:00
f060e6a780 Implement hold "sliding" samples in osu!mania 2022-10-11 16:31:37 +09:00
6ab29a62d0 Anchor drag box on time (catch, mania)
Not done for taiko because I cannot figure out how it should work with the overlapping scroll algorithm.
2022-10-11 14:23:17 +09:00
ed2b39a220 Remove whitespace 2022-10-11 13:53:18 +09:00
cc54fc5c1b rename method to reflect being a method 2022-10-10 13:52:01 -04:00
430eb44446 slight formatting 2022-10-10 13:45:16 -04:00
32adc1ec14 Fix division by 0 2022-10-10 13:36:52 -04:00
0b5f8e1c93 Remove duplicated colour in osu!mania argon skin column colouring
There will probably be more change to colours, but let's just fix this
for now.
2022-10-10 13:12:30 +09:00
15a7fb044d Merge pull request #20600 from peppy/fix-mania-rewinding
Fix osu!mania key / stage lighting / explosions not working well with rewind
2022-10-07 21:42:39 +09:00
e1e12f41e9 Add more comprehensive inline comment 2022-10-07 21:00:11 +09:00
d63f196626 Merge branch 'master' into fix-mania-rewinding 2022-10-07 20:45:56 +09:00
588713497d Attempt to make hold notes more legible at low background dims 2022-10-07 20:43:26 +09:00
589b764b77 Final tweaks because I don't know when to stop 2022-10-07 20:30:38 +09:00
d5490523ea Adjust hold notes further 2022-10-07 20:05:13 +09:00
8101eea50d Fix first glow of key area elements not working due to missing type 2022-10-07 20:05:13 +09:00
c518fbf44a Adjust argon hold bodies to better define away from the stage background 2022-10-07 20:05:13 +09:00
08c3f3ae6d Adjust lighting and timing of key area in general 2022-10-07 20:05:13 +09:00
551b7f0d1c Fix corner radius visible below hit target line 2022-10-07 20:05:13 +09:00
e4657a7a3d Fix argon key area lighting being hidden by other columns in one direction 2022-10-07 20:05:13 +09:00
12e9686092 Increase column spacing 2022-10-07 20:05:13 +09:00
f9b4f491a6 Increase overall corner radius slightly 2022-10-07 20:05:13 +09:00
58eaa18725 Add transparency to column backgrounds 2022-10-07 20:05:13 +09:00
b5746f5f20 Merge pull request #20602 from peppy/mania-fix-object-colouring
Fix osu!mania not colours not always updating when switching skins
2022-10-07 19:22:55 +09:00
52ad766f86 Remove manual binding of nested objects in DrawableManiaHitObject
This is now handled by `Column` itself. Leaving the logic here as well
will cause a circular bindable flow and stack overflow.
2022-10-07 18:25:55 +09:00
4b772643e9 Use bindable flow for transfer of accent colour from columns to hit objects
This fixes the case where changing a skin during gameplay runtime does
not correctly convey colour information to off-screen `DrawableHitObject`s.
2022-10-07 18:25:08 +09:00