cad18ebc58
Reword comment to better explain what we are guarding against
2022-07-12 16:46:19 +09:00
cafe30fc4d
Fix potential crash during shutdown sequence if intro playback was aborted
...
Fixes one of the audio related `ObjectDisposedException`s
(https://sentry.ppy.sh/organizations/ppy/issues/92/events/12f282f048cb4a4fae85810e8a70b68d/?project=2&query=is%3Aunresolved&sort=freq&statsPeriod=7d ).
Ran into this while testing locally. See
`IntroScreen.ensureEventuallyArrivingAtMenu` for the related cause of
this happening (forced continuing to next screen if the intro doesn't
load in time).
2022-07-12 15:20:30 +09:00
1e159eb328
Add back fade to black duration
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com >
2022-07-08 10:43:50 +09:00
07a08d28c6
Rename parameter and default to 0
2022-07-07 23:31:06 +03:00
15d070668d
Move intro screen background to base implementation and use colour fading
2022-07-08 02:12:01 +09:00
216150b52d
Avoid always loading new background at MainMenu
...
This was meant to be an optimisation to allow the background to load
while the intro is playing, but as the current default intro loads a
background itself, this was rarely the case and also counter-productive
as it would bypass the equality check and start a second load sequence.
2022-07-08 02:12:01 +09:00
4c3789ec5d
Split into a function
2022-07-05 11:15:37 +02:00
bb0f212448
Trigger the initial cookie with midi and joysticks
2022-07-05 00:38:18 +02:00
e3eba58cb6
Catch in triangles intro
2022-06-29 13:37:42 +03:00
50c1c066de
Add various logging of global WorkingBeatmap state changes
2022-06-27 18:41:31 +09:00
31a447fda0
Update parameter discards
2022-06-24 21:26:19 +09:00
a6c8a832aa
Remove Import(ArchiveReader) and redirect existing usages to Import(ImportTask)
2022-06-20 15:14:57 +09:00
4bc26dbb48
Merge pull request #18743 from smoogipoo/nullable-by-default
...
Enable NRT by default
2022-06-17 23:18:35 +09:00
1900480d51
Inline animation method
2022-06-17 17:06:06 +09:00
e51babdb96
Change heart animation flow to be more correct
2022-06-17 17:01:11 +09:00
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
89533fa33d
Fix Disclaimer screen handling user change events after initial display
...
Unnecessary overhead, but also should resolve a production hard crash.
2022-06-16 15:40:20 +09:00
7ac5019c08
Fix intro screens playing exit sounds
2022-06-15 17:37:30 +09:00
6b744a14b0
Move 'back' sample playback from OnResuming to OnExiting
2022-06-15 15:41:28 +09:00
363e7a6f53
Simplify toolbar hiding logic in FirstRunSetupOverlay
...
Rather than fiddling around with the activation modes, this seems like a
much cleaner way to make things work.
Closes https://github.com/ppy/osu/issues/18277 .
2022-05-19 16:42:48 +09:00
22e9620211
Don't block clicks when dragging osu! logo
2022-04-29 12:09:11 +09:00
32ad216669
Allow dragging the osu! logo
...
Logic borrowed from `NowPlayingOverlay`.
2022-04-28 22:58:34 +09:00
e89441951c
Allow any key to trigger the initial osu! cookie
2022-04-23 18:33:43 +02:00
8c6864727e
Merge branch 'master' into first-run-setup
2022-04-21 22:14:57 +02:00
832d37b2c2
Update screen transition events to use new event args
2022-04-22 00:52:44 +09:00
7d8cf1bbb6
Merge branch 'master' into first-run-setup
2022-04-21 15:49:39 +09:00
d46329f55a
Remove unused dependency
2022-04-20 12:51:55 +09:00
f5863c2030
remove unused import
2022-04-20 13:40:02 +10:00
4f80651606
implement 2a3a0c1 for playlists as well
2022-04-20 10:33:06 +10:00
2a3a0c1cd3
remove notification on trying to multi when logged out
...
fixes #17877
2022-04-19 18:44:20 +10:00
c4bade0995
Expose MainMenu buttons
2022-04-19 16:36:39 +09:00
bb8b94f8ad
Merge branch 'master' into i-notification-overlay
2022-04-19 06:03:56 +09:00
94e892df1c
Merge pull request #17862 from peppy/i-dialog-overlay
...
Split out `IDialogOverlay` to allow for easier testing
2022-04-19 05:24:05 +09:00
043599081b
Split out INotificationOverlay to allow for easier testing
2022-04-18 20:14:01 +09:00
e315313266
Split out IDialogOverlay to allow for easier testing
2022-04-18 18:36:26 +09:00
2202863e1a
Split out IPerformFromScreenRunner to allow for easier testing
2022-04-18 17:49:28 +09:00
ef5ed262ca
Add pitch randomisation to the OsuLogo hover sample
2022-04-15 20:38:47 +09:00
8e6c015856
Use a fallback sample when a MainMenuButton doesn't provide a click sample
2022-04-15 20:38:30 +09:00
c42ef43faa
Ensure intro beatmap has protected flag set
...
In cases this isn't set, the beatmap has likely entered a bad state.
Closes https://github.com/ppy/osu/issues/17659 .
2022-04-06 16:46:53 +09:00
36c02573a8
Fix osu! logo being clicked when exiting via cmd-q on initial state
2022-03-30 21:26:30 -07:00
6384531317
Fix LogoVisualisation draw thread safety
2022-03-27 01:43:47 +09:00
416b57ea69
Fix main menu buttons handling keys when super (cmd) is held
2022-03-25 15:13:22 +09:00
816fcae3a1
Rename Button to MainMenuButton to differentiate better
2022-03-25 15:12:39 +09:00
8cbc8b944f
Rescope scheduling and improve comment
2022-03-10 17:25:13 +03:00
2c1589e068
Add skinning support for "seeya" sample
2022-03-10 05:52:45 +03:00
b8ee786d77
Add skinning support for "welcome" sample
2022-03-10 05:52:45 +03:00
b38de6e580
Add skinning support for welcome sprite text
2022-03-10 05:52:43 +03:00
7854a0a913
Use double instead of float for UIHoldActivationDelay configuration value
...
All times use double, so let's also use double here.
2022-03-04 12:22:56 +09:00
33a87976a8
Rewrite to read better
...
Co-authored-by: Dean Herbert <pe@ppy.sh >
2022-02-24 21:11:49 +01:00
6f29cbccd1
Remove unused using
2022-02-24 10:36:10 +01:00
