Commit Graph

33569 Commits

Author SHA1 Message Date
abe947bcb0 Update outdated xmldoc comments 2022-06-15 15:31:45 +09:00
19543685ff Merge branch 'master' into quick-import-only-on-batch 2022-06-15 15:27:06 +09:00
d3feb07bc1 Split zoom updating to named method with value as optional 2022-06-15 07:57:16 +03:00
268a7e1334 Fix ZoomableScrollContainer attempting to update zoom with overlapping range 2022-06-15 05:43:41 +03:00
36599d1174 Merge branch 'master' into fix-hit-error-when-not-visible 2022-06-14 22:47:11 +03:00
49ec2572b8 Allow scrolling overflow of ruleset buttons in the toolbar 2022-06-15 01:43:10 +09:00
d89c11e49e Allow Toolbar to block scroll input from passing through 2022-06-14 19:10:13 +03:00
6be4209458 Fix AlwaysPresent specification in wrong container 2022-06-15 01:04:43 +09:00
88d5e074a8 Rename lowPriority to batchImport 2022-06-15 00:46:00 +09:00
f11fe54385 Remove custom hash function flow 2022-06-15 00:42:30 +09:00
2f8290831a Skip quick import clause when importing a single item
Closes https://github.com/ppy/osu/issues/18600.
2022-06-15 00:26:34 +09:00
7affef75b0 Remove unused Import method in SkinManager 2022-06-15 00:26:34 +09:00
cf2238f683 Merge pull request #18688 from peppy/too-many-import-methods
Various clean-up on model managers / importer classes
2022-06-15 00:12:33 +09:00
cc7943dfb1 Merge pull request #18687 from peppy/editor-repeat-behaviour-change-collapsing
Fix timing adjustment repeat buttons firing one change per repeat invocation
2022-06-14 20:24:13 +09:00
94ba71aa13 Remove one more usage of lowPriority 2022-06-14 20:21:28 +09:00
6250caca29 Remove duplicate implementation of same thing 2022-06-14 20:01:11 +09:00
e96c5ce703 Move and correct xmldoc to interfaces 2022-06-14 20:00:16 +09:00
84e526a2d9 Move methods around to make more sense 2022-06-14 20:00:08 +09:00
9f599a5ab4 Remove unused lowPriority flag from one Import method 2022-06-14 19:52:30 +09:00
ca0765a932 Tidy up various delegation implementations 2022-06-14 19:46:59 +09:00
d73c0ca659 Remove unused methods from IModelImporter
All the xmldoc is already present in `RealmArchiveModelImporter` so
nothing is lost here.
2022-06-14 19:42:11 +09:00
c30644328c Fix timing adjustment repeat buttons firing one change per repeat invocation 2022-06-14 19:21:02 +09:00
aeca138930 Fix ctrl-z in editor also seeking to start in addition to undo 2022-06-14 18:48:57 +09:00
a20e43c2ae Ensure containers which are being used to hide HUD elements still update for now
I don't think this is necessarily a final solution (as this means all
HUD elements are adding overhead even when not visible), but this will
make the implementations much easier for the time being.

I've checked and can't notice any perceivable overhead in profiling so
we should be fine for now.
2022-06-14 18:22:25 +09:00
bd9ea9bd6f Revert most unnecessary changes
Turns out `AlwaysPresent` at top level is actually enough.

This reverts commit 86163d2225.
2022-06-13 23:58:14 +09:00
336df62a1f Remove unnecessary file existence check
This is not required due to `createFileInfos` always being run before we
get to this point (I believe this was added after the initial code to
check existence was added).

This flow is covered in
`BeatmapImportTests.TestImportThenReimportAfterMissingFiles`, which
still passes with the change.

While this check isn't doing any harm, as I'm going through the flow for
import-skipping, less checks are appreciated.
2022-06-13 18:57:30 +09:00
b88461b3c9 Merge pull request #18671 from peppy/latency-scrolling-gameplay
Add scrolling gameplay visualisation mode to latency certifier
2022-06-13 18:46:46 +09:00
7ac8ba0a74 Merge pull request #18368 from apollo-dw/dho
Move object history in difficulty calculation to the object itself
2022-06-13 17:31:08 +09:00
f997886142 Add scrolling gameplay visualisation mode to latency certifier 2022-06-13 17:18:32 +09:00
86163d2225 Fix hit error meters not updating visual state when hidden
It is an expectation of users that when the HUD is shown after a period
of being hidden, it will visually reflect the state based on recent
judgements.

To achieve this, I've added `AlwaysPresent` and moved the transform
application to the meter level, rather than at a child level. If this is
seen as a bad direction, `AlwaysPresent` can be applied to the drawable
children and the transforms can be moved back.

Also of note, `ColourHitErrorMeter` is pretty weird. The flow class
could potentially be removed and reduce `AlwaysPresent` usage by one.
Can do that refactor as part of this PR if preferred.

Closes #18624.
2022-06-13 16:38:57 +09:00
17eaf7bb5c Add failing test coverage showing hit meters don't update when not visible 2022-06-13 16:36:22 +09:00
77fcf35d1d Remove unlimited frame limiter warning
This should not be required now that we have a 1,000 Hz limiter in
place.
2022-06-13 15:40:27 +09:00
dfc643fd8c Match family string via GetFamilyString() 2022-06-13 12:35:10 +09:00
3aec0fe9b6 Fix torus alternate not mapping "medium" weight to "regular" 2022-06-13 04:45:07 +03:00
7971355660 Fix torus "medium" weight not mapped to "regular" when using With 2022-06-13 04:44:44 +03:00
051aa8f028 Mark family strings as verbatim 2022-06-13 04:43:14 +03:00
12ff98001d Merge pull request #18635 from peppy/latency-comparer-more-modes
Add multiple display modes (including circle gameplay) to latency certification
2022-06-12 00:59:36 +09:00
486f762f44 Fix inspection by removing unstable rate code 2022-06-12 00:13:36 +09:00
af353c37c0 Don't show UR for now 2022-06-11 23:54:11 +09:00
52c8cea27d Update spectator/multiplayer endpoint in line with new deployment 2022-06-11 22:31:01 +09:00
419b5791c9 Move circle duration to constant 2022-06-11 16:08:24 +03:00
8d53ed64a3 Fix mode cycling and add test coverage 2022-06-11 21:36:43 +09:00
0c333e5c08 Link directly to methodology section
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-06-11 21:34:00 +09:00
c697dc90e4 Hide settings at results screen 2022-06-11 21:32:02 +09:00
d130e7ebff Remove ScrollingGameplay class for now 2022-06-11 21:30:33 +09:00
68da9f0386 Add explicit precision for BPM adjustment
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-06-11 21:27:44 +09:00
06f070c3ec Fix latency certifier potentially reporting infinite mouse polling rate 2022-06-11 14:58:16 +03:00
8562641560 Update framework 2022-06-11 12:48:31 +09:00
096d6df868 Fix regression in testing and setting logic 2022-06-10 20:33:21 +09:00
8ce545ff9d Fix visuals in circle gameplay and greedy hover 2022-06-10 20:25:33 +09:00