Commit Graph

59233 Commits

Author SHA1 Message Date
1acc536248 Move DrawableRuleset.Audio to a less generic level 2023-02-21 19:03:52 +09:00
af062e7a68 Change placeComponent to only add to selection, not clear an existing selection 2023-02-21 14:11:18 +09:00
9321ec29dc Update slider sample source asserts to match expected behaviour
As pointed out in review, if the current time is after the end of the
slider, the correct hit object to use for sample retrieval is the object
itself, not any nested object.
2023-02-21 14:04:38 +09:00
e686b4393e Add wait steps to ensure frame-stable clock has caught up before checking state 2023-02-21 14:04:19 +09:00
5ba6059911 Merge branch 'master' into fix-taiko-drum-nested-sample-detection 2023-02-21 13:58:15 +09:00
ee87a29376 Merge pull request #22543 from Cwazywierdo/hitcircle-late-miss-fade
Fix hit circle late-miss fading differences compared to stable
2023-02-21 13:56:57 +09:00
0d229d959b Remove unnecessary TriggerChange call 2023-02-21 13:50:19 +09:00
6799492596 Merge branch 'master' into skin-editor-layer-select 2023-02-20 21:33:48 +01:00
8818341047 Merge pull request #22673 from peppy/skin-per-ruleset-layouts
Add support for per-ruleset skin layouts
2023-02-20 21:33:28 +01:00
86a7f4dfd0 Do not serialise SkinLayoutInfo.AllDrawables
- It is entirely derived from `SkinLayoutInfo.DrawableInfo`, which is
  the actual primary thing we want to serialise.
- It will never get read out from any serialised files anyway (corollary
  of the previous point - it is a get-only property derived from another).
- It is only used in tests.

All of the three reasons above make serialising the property out to skin
files nothing more than a waste of space.
2023-02-20 20:37:48 +01:00
c9999bdeb1 Merge branch 'master' into skin-per-ruleset-layouts 2023-02-20 20:14:38 +01:00
43724472c4 Clarify comment to avoid playing pronoun game 2023-02-20 20:09:24 +01:00
6382314af1 Merge pull request #22697 from ggliv/tablet-area-drag
Allow tablet area to be dragged
2023-02-20 23:37:25 +09:00
43d33d45ca Only add valid placed components to selected collection on paste 2023-02-20 20:02:43 +09:00
b68562b033 Make placeComponent resilient to missing dependencies 2023-02-20 20:00:12 +09:00
a9c7edd087 Remove copy pasted comment 2023-02-20 19:57:16 +09:00
7a585e1fa1 Merge pull request #22669 from EVAST9919/mod-overlay-triangles
Add triangles animation to mod select overlay headers
2023-02-20 19:54:21 +09:00
ec12186d63 Remove unnecesasry null check on content 2023-02-20 19:53:04 +09:00
18700b4daa Add note about skin migrations being on read and remove an older deprecation notice 2023-02-20 19:51:54 +09:00
1629c86b5d Mark constant identifier as non-localisable
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-02-20 19:48:39 +09:00
0ddda018fd Add xmldoc for SkinComponentsContainerLookup.Ruleset
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-02-20 19:48:18 +09:00
5f7a6d13c3 Remove unused GetSerialisableIdentifier for now 2023-02-20 19:47:17 +09:00
c86c1a9029 allow tablet area to be dragged 2023-02-20 00:06:20 -05:00
b5dda407a8 Merge pull request #22291 from ekrctb/revert-result-in-playfield
Move judgement result revert logic to Playfield
2023-02-19 17:06:08 +01:00
8a488ebccc Actually simplify condition 2023-02-19 16:39:35 +01:00
0611fd4035 Add coverage for classic/hidden interactions 2023-02-19 16:39:25 +01:00
3183f5cee2 Merge branch 'master' into revert-result-in-playfield 2023-02-19 16:33:10 +01:00
2cda7fced3 Merge pull request #22670 from peppy/blueprint-improve-visuals
Improve the appearance of skin blueprints
2023-02-19 16:31:29 +01:00
1ba1298850 Merge branch 'master' into blueprint-improve-visuals 2023-02-19 15:55:30 +01:00
d7381b762c Also tween origin position 2023-02-19 23:52:21 +09:00
cff57d7ee9 Merge pull request #22686 from MaxKruse/fix-automatic-seeking
Add toggle to disable automatic seeking to object after placement
2023-02-19 23:38:23 +09:00
d9ca7102f0 Use more generic wording for future-proofing 2023-02-19 15:06:40 +01:00
8b25598d82 Rename moved test method to describe its purpose better 2023-02-19 13:54:48 +01:00
80ee917c77 Rewrite test cases
- Depend less on arbitrary timings
- Remove unnecessary seeks
- Change method name to make more sense
- Use nunit style assertions
2023-02-19 13:37:06 +01:00
80b329f069 Rename test scene to match contents
It does not only test "placement before track start" anymore.
2023-02-19 13:16:40 +01:00
aac32a2c9f Combine config and time checks into one
Functionally equivalent right now, but the combined variant is more
localised to what it actually needs to do, and less error-prone if
any new code gets appended to the method.
2023-02-19 13:14:51 +01:00
723a043c43 naming change from Hitobject to HitObject 2023-02-19 10:18:22 +01:00
f3522c4162 change bindable seekToHitObject to private 2023-02-19 10:18:02 +01:00
025061ba66 fix formating in SeekOnNote test 2023-02-19 10:17:33 +01:00
58d64cdbd0 Clarify usingHiddenFading logic 2023-02-18 17:33:33 -06:00
55e9a71f38 Add test for seeking setting in mania placement test 2023-02-18 20:42:13 +01:00
ddd37bb319 Add setting to disable automatic seeking after object placement 2023-02-18 19:43:45 +01:00
79e1dbfb6d Merge pull request #22671 from peppy/blueprint-labels-while-hovering
Only show skin blueprint labels when selected or hovering
2023-02-18 16:29:37 +01:00
ea04c487f2 Merge branch 'master' into blueprint-labels-while-hovering 2023-02-18 15:57:30 +01:00
ff5de04fb1 Merge pull request #22675 from cdwcgt/CompletionText-LocalisableString
Make `CompletionText` in `ProgressNotification` a `LocalisableString`
2023-02-18 14:25:21 +01:00
15d209d17e Merge branch 'master' into CompletionText-LocalisableString 2023-02-18 13:50:58 +01:00
6b1c8195bc Merge pull request #22672 from peppy/skin-editor-improve-toolbox-hover
Improve the feel of hovering components in the skin editor toolbox
2023-02-18 10:34:28 +01:00
fbea3e312f Merge branch 'master' into skin-editor-improve-toolbox-hover 2023-02-18 10:02:02 +01:00
704dddf14b Merge branch 'master' into skin-editor-clipboard 2023-02-17 22:59:18 +01:00
6b9472c367 Merge branch 'master' into skin-per-ruleset-layouts 2023-02-17 22:58:38 +01:00