Commit Graph

6968 Commits

Author SHA1 Message Date
ad5ef52922 Add test coverage of resuming after pause not skipping forward in time 2022-08-29 19:02:01 +09:00
f2378d3fde Merge branch 'master' into carousel-maintain-selection-over-update 2022-08-29 11:23:22 +03:00
e8ae6840ea Add test coverage of selection being retained 2022-08-29 15:23:34 +09:00
289b6f1a58 Merge pull request #19924 from peppy/fix-playlist-overlay-test-failures
Fix intermittent test failures in `TestScenePlaylistOverlay`
2022-08-26 23:36:16 +09:00
1fd1672d89 Merge branch 'master' into mod-validation-tests 2022-08-26 15:00:07 +03:00
6dc859973b Merge branch 'master' into fix-playlist-overlay-test-failures 2022-08-26 20:25:53 +09:00
5ef8e26ebe Fix check not accounting for mods not existing in certain rulesets
Also check all instances, rather than first.
2022-08-26 19:59:26 +09:00
580754833f Merge branch 'master' into mod-validation-tests 2022-08-26 19:48:42 +09:00
9050f54681 Split out test assertion methods to read better 2022-08-26 16:56:03 +09:00
a8c699610a Fix lead in tests not waiting for player to start running
The tests are only meant to ensure that gameplay eventually starts.

The case where failures can occur is where the master clock is behind
the player clock (due to being in lead-in time). Because the test is
running in real-time, it can take arbitrary amounts of time to catch up.

If it took too long, the test would fail.
2022-08-25 18:00:14 +09:00
ddb434f47a Rename asserts to method names to make it easier to track in logs 2022-08-25 17:30:13 +09:00
a5c61d9a52 Improve understandability of TestMostInSyncUserIsAudioSource 2022-08-25 16:47:33 +09:00
3a17c6df08 Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-25 16:24:55 +09:00
1032b2a68c Fix some BeatmapCarousel tests not correctly reinitialising local data per run
Closes https://github.com/ppy/osu/issues/19949.
2022-08-25 14:03:26 +09:00
ddccf4defe Remove dollar sign 2022-08-24 17:17:59 +09:00
27b57947e4 Rename PlayerArea.GameplayClock to SpectatorPlayerClock for clarity 2022-08-24 17:13:14 +09:00
5f01f461b3 Ensure elapsed time is always non-zero when advancing SpectatorPlayerClock 2022-08-24 17:13:14 +09:00
5079e0d83d Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-24 16:52:10 +09:00
995e6664b6 Rename spectator clock sync classes 2022-08-24 15:13:08 +09:00
ec61a94dc9 Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-23 17:36:06 +09:00
9a579871c0 Remove pointless initial import 2022-08-23 17:33:53 +09:00
a62deae3cc Use local realm rather than fetching from dependencies 2022-08-23 17:33:53 +09:00
690e048864 Ensure all initial imports are completed before running playlist overlay tests steps 2022-08-23 17:33:53 +09:00
058d67f8e8 Merge pull request #19695 from naoei/ruleset-localization
Change most ruleset-accessible string types to Localisable strings
2022-08-22 16:13:23 +09:00
0815b01b75 Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation
Fix selecting preset containing Difficulty Adjust automatically opening customisation panel
2022-08-22 15:44:00 +09:00
Nao
189a407cb1 Merge branch 'master' into ruleset-localization 2022-08-20 21:39:10 -04:00
15d49b0357 Update TestSceneSpectator to user new assert style 2022-08-19 01:46:19 +09:00
cc86909633 Increase lenience on TestSceneLeadIn tests
I've gone through these in detail and can't find an issue with the
actual flow of things. For whatever reason, the new structure has a
slightly higher delay, likely due to performing less `Seek` calls
(previously a `Seek` was called after the clock start which may have
been making this more accurate on the first `Player.Update`).

I don't think it really matters that this is slightly off, but we'll see
how this plays out.
2022-08-19 01:39:00 +09:00
2eba8650ca Update TestSceneLeadIn to use new assert style 2022-08-18 19:26:19 +09:00
728cd96508 Update TestSceneLeadIn to use new assert style 2022-08-18 18:54:10 +09:00
fa167b1d12 Merge pull request #19779 from peppy/no-gameplay-clock
Remove all remaining usage of `GameplayClock`
2022-08-18 18:52:57 +09:00
e7ddbc41c8 Merge branch 'master' into no-gameplay-clock 2022-08-17 22:21:10 +09:00
553ae4781f Remove unnecessary local implementation in TestScenePlaybackControl 2022-08-17 19:21:54 +09:00
4ef4d66f49 Add some extra initial state checks to TestSceneEditorSeekSnapping 2022-08-17 19:21:46 +09:00
3a0017c87b Fix flaky quick retry test 2022-08-17 17:09:44 +09:00
20256aad11 Merge branch 'master' into no-gameplay-clock 2022-08-17 15:21:20 +09:00
24fd411720 Merge pull request #19594 from BlauFx/improve_retry_behaviour
Skip song intro on quick restart
2022-08-16 20:18:12 +09:00
9a1a7bae89 Make test actually test things 2022-08-16 14:40:02 +09:00
6761f869f9 Modify flow to avoid weird bindable and value resetting 2022-08-16 14:17:35 +09:00
a15e6f19aa Fix running TestScenePlayerLoader interactively leaving volume in a bad state 2022-08-16 13:40:46 +09:00
c9baadcf88 Merge branch 'master' into improve_retry_behaviour 2022-08-16 13:06:04 +09:00
a494e55d93 Adjust test scene to reflect new behaviour 2022-08-15 20:43:19 +02:00
f0ad31b650 Add failing test case 2022-08-15 20:38:22 +02:00
5ff2e41a55 Add preset column to mod select test scene 2022-08-15 18:38:37 +02:00
704568ae3b Remove remaining usage of GameplayClock 2022-08-15 20:22:36 +09:00
87760bbc06 Fix IsCatchingUp not being in correct state 2022-08-15 20:17:48 +09:00
04d88b8216 Use constraint based assertions in TestSceneFrameStabilityContainer 2022-08-15 19:19:19 +09:00
27569e2ed5 Remove FrameStableClock (and redirect usages to FrameStabilityContainer) 2022-08-15 19:19:19 +09:00
f81c7644b4 Make GameplayClockContainer also an IGameplayClock and expose to remaining tests 2022-08-15 18:30:53 +09:00
c8764cb333 Move all usage of GameplayClock to IGameplayClock 2022-08-15 18:30:53 +09:00