bbcc149e2e
During import if files are found to be missing, ensure they are restored
...
This is one step closer to sanity in terms of physical files. As per the
comment I have left in place, we really should be checking file sizes or
hashes, but to keep things simple and fast I've opted to just cover the
"missing file" scenario for now.
Ran into this when testing against a foreign `client.realm` by:
- Noticing a beatmap doesn't load
- Deleting said beatmap
- Downloading via beatmap overlay
- Beatmap is restored but still doesn't work
Note that I've kept the logic where this will undelete an existing
import rather than create one from fresh, as I think that is beneficial
to the user (ie. it will still keep any linked scores on restore).
2022-01-25 13:44:54 +09:00
d7342880f5
Update remaining cases of clashes with realm.Write and realm.RegisterForNotifications
2022-01-25 13:09:48 +09:00
e23b10e6a5
Update remaining cases of clashing variable name in realm.Run(realm..
2022-01-25 13:04:05 +09:00
3e5c9e8436
Fix cases of Access instead of Realm
2022-01-25 12:58:15 +09:00
2d34831b5f
Fix TestMigration failing due to changes in realm migration logic
...
Fixes failures as seen at https://github.com/ppy/osu/runs/4927916031?check_suite_focus=true .
2022-01-25 12:54:40 +09:00
f30894840c
Update terminology to realm "instance" rather than "context"
...
This matches the terminology used by realm themselves, which feels
better.
2022-01-24 20:38:38 +09:00
6eb2c28e41
Rename RealmContextFactory to RealmAccess
2022-01-24 20:38:07 +09:00
9ff9611296
Merge branch 'master' into realm-stable-subscriptions
2022-01-24 18:25:47 +09:00
d7db6fa918
Merge branch 'master' into custom-meter
2022-01-24 15:46:44 +09:00
6581e8c2d3
Merge pull request #16549 from Susko3/LoginPanel-flag
...
Hide the login panel when clicking the country flag
2022-01-24 15:38:50 +09:00
40aa873190
Rename register methods to better explain their purpose
2022-01-24 14:37:36 +09:00
e236f5d604
Add failing test coverage for correct beatmap filename generation on save
2022-01-23 20:28:19 +01:00
0709a2ac9b
Add test coverage of realm subscription scenarios
2022-01-23 20:28:13 +09:00
db86394355
Fix TestResources returning a test BeatmapSetInfo that can't be laoded directly into realm
2022-01-23 20:28:04 +09:00
1ea5a2e6a7
Fix incorrect assert step name
2022-01-23 10:11:12 +03:00
f39f2c93b5
Add control for arbitrary-numerator time signatures
2022-01-22 20:50:31 +01:00
735414bc49
Replace TimeSignatures enum with struct for storage of arbitrary meter
2022-01-22 20:50:31 +01:00
6a076a684e
Merge branch 'realm-context-use-update-when-feasible' into realm-stable-subscriptions
2022-01-22 13:14:25 +09:00
c9db0181d0
Attempt to fix test failures on windows due to context being held open
2022-01-22 12:24:05 +09:00
9b63f15e68
Add failing test
2022-01-21 13:58:30 +01:00
1f157d729d
Update existing subscriptions to new style
...
Fix missing detach calls in `MusicController`
2022-01-21 20:05:03 +09:00
114c9e8c1f
Update all usages of CreateContext to use either Run or Write
2022-01-21 17:27:08 +09:00
70cc03fe43
Avoid constructor overhead for realm RealmKeyBinding parameterless constructor
2022-01-20 17:29:07 +09:00
7509b31176
Merge pull request #16519 from peppy/fix-legacy-score-import-classic-mod
...
Fix legacy score imports not correctly getting classic mod assigned
2022-01-20 14:28:29 +09:00
4f86a2cb61
Merge pull request #16525 from bdach/beatmap-listing-overflow-and-scrolling
...
Improve usability of expanded card content on beatmap listing
2022-01-20 14:14:44 +09:00
4cad5890c6
Add test coverage for news sidebar showing wrong headers
2022-01-19 23:12:35 +01:00
d925e44b40
Add test coverage for beatmap card expanded content clipping
2022-01-19 22:08:52 +01:00
fea4400c03
Remove unused using directive
2022-01-19 18:49:37 +01:00
a002dacdce
Add test coverage of various ScoreInfo mod set operations
2022-01-19 14:34:27 +09:00
bb6f40d16e
Add test coverage of all mod storages containing classic mod post-import
2022-01-19 14:34:27 +09:00
581873f944
Merge pull request #16497 from peppy/top-local-rank-optimisation
...
Rewrite `TopLocalRank` to use realm subscriptions
2022-01-19 14:22:12 +09:00
3e5d29ed00
Merge pull request #16505 from peppy/remove-base-difficulty-usage
...
Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)
2022-01-19 13:53:55 +09:00
201f2d7813
Add comprehensive test coverage for TopLocalRank
2022-01-19 13:48:00 +09:00
2556f1cb87
Merge branch 'master' into optimise-set-detach-part-2
2022-01-19 13:20:38 +09:00
f6f44029e8
Merge pull request #16507 from peppy/more-ingore-rules
...
Add some missing `IgnoredAttributes` to reduce automapper overhead
2022-01-19 12:26:37 +09:00
7df18c7767
Merge branch 'master' into playlist-test-coverage
2022-01-18 20:17:48 +01:00
96d07e20ed
Revert nunit test adaptor version bump until console output bug is resolved
...
Tests have started to output too much log content, causing viewing CI
failures to be painfully impossible. Roll back for now.
Fix may be related to
https://github.com/nunit/nunit3-vs-adapter/issues/941 , although we don't
use filter.
2022-01-19 02:18:58 +09:00
1db2135d70
Update tests to match new behaviour
2022-01-19 01:05:47 +09:00
67bf95bc91
Remove all usage of AuthorString
2022-01-18 23:30:40 +09:00
7f65f3a47f
Remove all usage of BaseDifficulty (and access Difficulty instead)
2022-01-18 22:57:39 +09:00
02baad30d7
Merge branch 'master' into global-bindable-thread-safety
2022-01-18 18:12:00 +09:00
73a1f27ce5
Merge branch 'master' into realm-integration/score-and-beatmaps
2022-01-18 17:31:37 +09:00
3e9e7a8fb6
Fix PLaylistsResultsScreen tests falling over due to missing beatmap
2022-01-18 16:48:27 +09:00
8978b88f69
Add test coverage of startup ruleset being non-default
2022-01-18 16:22:15 +09:00
b4fdd8a986
Merge pull request #16489 from peppy/aggregate-score-tests
...
Add test coverage of aggregate scores displaying correctly at multiplayer/playlists screens
2022-01-18 16:03:06 +09:00
7084183d6c
Fix test beatmaps created without hash being populated
2022-01-18 15:43:02 +09:00
1b62a685f3
Merge branch 'master' into realm-integration/score-and-beatmaps
2022-01-18 15:07:59 +09:00
d26f4d50bd
Add test coverage of aggregate room scores displaying correctly
2022-01-18 14:00:12 +09:00
c3d3c03f0f
Fix TestScenePlaylistsScreen crashing on entering room
2022-01-18 13:42:41 +09:00
da9a60a695
Update broken test scenes to match new OsuTestScene logic
2022-01-18 13:41:50 +09:00
