658e0edc3e
Handle other button clicks in HoverClickSounds
...
As suggested in review, remove previously introduced HoverMouseUpSounds
and instead change effect playing logic in HoverClickSounds by moving it
out of OnClick() to OnMouseUp().
Users of the class can either use the existing constructor to play
the effect only on left click or use the newly introduced constructor
with the MouseButton[] parameter to specify which button clicks should
trigger the sound.
2019-08-31 20:16:16 +02:00
a1c72db5f6
Fix inconsistent sound effects on mod buttons
...
Because HoverClickSounds.OnClick() does not fire upon right clicking
on mod buttons, the sound effects that play on left and right click
were inconsistent. Introduce HoverMouseUpSounds drawable that allows
to play the click sound effect upon mouse up events for an arbitrary
set of mouse buttons and use it on mod buttons.
2019-08-31 17:01:12 +02:00
5695bb670e
change back to queuing
2019-08-31 10:55:05 -04:00
1b4ae5a4a4
Spelling fixes
2019-08-31 10:55:05 -04:00
691b89ae19
Merge pull request #5911 from peppy/fix-skin-configuration-fallback
...
Fix ruleset skins incorrectly providing configuration defaults
2019-08-31 21:50:14 +09:00
cbbc6aad6e
Make method static
2019-08-31 21:32:02 +09:00
d2a3e0581b
Fix legacy decoder using wrong configuration
2019-08-31 13:27:03 +09:00
12eeec36fc
Fix ruleset skins incorrectly providing configuration defaults
2019-08-31 12:33:29 +09:00
1ddf292ad6
Fix vertical alignment of hit error display ticks
...
Wasn't correctly centered before.
2019-08-31 12:20:50 +09:00
8f5dc06d55
Merge remote-tracking branch 'upstream/master' into accuracy-bar
2019-08-30 20:18:25 +09:00
f1db6c7039
Fix likely nullref
2019-08-30 20:18:21 +09:00
fc813347ac
Make JudgementLine private
2019-08-30 19:54:36 +09:00
dfccc60361
Reorder HitErrorDisplay
2019-08-30 19:53:38 +09:00
fab12fa9cd
Centre align the icons
...
Seems to look better this way.
2019-08-30 19:53:38 +09:00
665fc95d49
Handle no hitobjects / no hitwindows (osu!catch)
2019-08-30 19:37:20 +09:00
394208afc5
Merge remote-tracking branch 'upstream/master' into accuracy-bar
2019-08-30 19:27:35 +09:00
ff599ba623
Merge branch 'master' into add-ruleset-legacy-skin
2019-08-30 19:23:34 +09:00
80671cefd7
Final visual polish
2019-08-30 19:14:07 +09:00
c3abf0ccb7
Improve visuals
2019-08-30 18:50:38 +09:00
171f88da40
Bump ppy.osu.Framework from 2019.830.0 to 2019.830.1
...
Bumps [ppy.osu.Framework](https://github.com/ppy/osu-framework ) from 2019.830.0 to 2019.830.1.
- [Release notes](https://github.com/ppy/osu-framework/releases )
- [Commits](https://github.com/ppy/osu-framework/compare/2019.830.0...2019.830.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-08-30 09:47:18 +00:00
8fc177b743
Fix namespacing and hitwindow source
2019-08-30 18:46:42 +09:00
741bd0a5cf
Fix incorrect colour sizes and simplify alignment specification
2019-08-30 18:35:17 +09:00
40729356fa
Move beat divisor colour retrieval to BindableBeatDivisor
2019-08-30 17:34:58 +09:00
54696eef39
Reverse display, add animation and reduce width
2019-08-30 17:06:23 +09:00
a73d672c2f
Tidy up judgement line logic (and fix it displaying at the wrong place)
2019-08-30 16:40:39 +09:00
72dbeaec16
Fix the comment
2019-08-30 10:26:11 +03:00
71c844facd
Remove unwanted spacings
2019-08-30 10:22:49 +03:00
b03b520818
Move Absing from the APIKudosuHistory
2019-08-30 10:13:21 +03:00
b7a75ef5e1
Merge remote-tracking branch 'refs/remotes/ppy/master' into kudosu-info
2019-08-30 10:09:00 +03:00
6640161bc1
Simplify event propagation
2019-08-30 15:51:36 +09:00
bdbfa7bd2f
Fix class naming
2019-08-30 15:32:47 +09:00
3aa2ece49b
Merge branch 'iskincomponent' into play-to-gameplay
2019-08-30 15:29:55 +09:00
fe90e194e3
Remove redundant qualifier
2019-08-30 15:29:44 +09:00
835ee0aa2f
Code quality fixes
2019-08-30 15:29:13 +09:00
1d77e3764d
Merge branch 'master' into accuracy-bar
2019-08-30 15:21:32 +09:00
70e417533f
Update naming
2019-08-30 15:13:29 +09:00
a7c94c3883
Simplify hit result lookups
2019-08-30 15:12:03 +09:00
a15828ab25
Introduce the concept of SkinComponents
...
Removes reliance on string lookups and better defines elements for introduction into database
2019-08-30 14:55:52 +09:00
8f9fe99237
Move SliderFollowCircle implementation
2019-08-30 14:40:36 +09:00
71192791d5
Merge remote-tracking branch 'upstream/master' into add-ruleset-legacy-skin
2019-08-30 14:12:56 +09:00
c389a5c798
Move remaining osu-specific implementations to OsuLegacySkin
2019-08-30 13:42:29 +09:00
7bba8ca14b
Split out nested classes
2019-08-30 13:04:11 +09:00
84e4748268
Remove duplicate getAnimation function and improve namespacing
2019-08-30 12:59:58 +09:00
dc1046bf0c
Merge remote-tracking branch 'upstream/master' into add-ruleset-legacy-skin
2019-08-30 12:53:05 +09:00
9c622680e3
Update framework
2019-08-30 12:35:53 +09:00
8fe37d0c43
Update resources
2019-08-30 12:35:44 +09:00
d17cfe20c2
Merge remote-tracking branch 'upstream/master' into add-legacy-default
2019-08-30 11:54:49 +09:00
bfbec067b1
Remove remnants of user skin PR
2019-08-30 11:54:36 +09:00
3f500131d4
Add basic xmldoc
2019-08-30 11:33:50 +09:00
06224a7d4e
Fix build issue
2019-08-29 15:38:33 +03:00
