Commit Graph

1290 Commits

Author SHA1 Message Date
3c2e2f29bc Remove unused using statement 2020-10-27 13:17:44 +09:00
27c1a4c4d3 Move right-click deletion logic to be handled at a SelectionBlueprint level 2020-10-27 12:53:54 +09:00
e1f578c590 Change editor timing screen seek behaviour to only occur on clicking table rows
Previously it would react to any selection changed event, which could in
lude time changes (which is done by removing then adding the
ControlPointGroup).

Closes #10590.
2020-10-27 12:28:12 +09:00
3f8c4c57d0 Fix code style issues & restructure 2020-10-26 22:16:28 +01:00
255bb9d100 fixed issue with returns 2020-10-26 14:52:59 -05:00
ccaf6560ec formatting 2020-10-26 14:30:37 -05:00
1239670566 moved right click shift delete functionality to HandleSelectionRequested + reduced func size 2020-10-26 14:28:53 -05:00
ead3c19567 added function so circle is deleted when shift+right click 2020-10-26 13:40:42 -05:00
704f8cc4f2 Fix selection box wandering off into the distance 2020-10-26 18:45:03 +01:00
8273715bde Merge pull request #9484 from FlashyReese/visible-playfield-boundary 2020-10-20 19:43:41 +09:00
22bde43106 Merge branch 'master' into visible-playfield-boundary 2020-10-19 18:05:28 +09:00
79a17b2371 Reapply waveform colour fix 2020-10-19 16:57:08 +09:00
829241a9f0 Merge pull request #10521 from peppy/fix-editor-seek-interval-when-playing
Fix editor not seeking by full beat when track is playing
2020-10-16 13:55:03 +09:00
aea31d1582 Fix editor not seeking by full beat when track is playing
This is expected behaviour as my osu-stable, and I still stand behind
the reasoning behind it.

Closes #10519.
2020-10-16 13:07:00 +09:00
88f74921fb Update with new r# inspections 2020-10-16 12:49:39 +09:00
b0f8a7794a Make SelectionHandler require EditorBeatmap presence 2020-10-09 21:44:10 +09:00
681e88af40 Merge branch 'master' into editor-fix-button-states-after-paste 2020-10-09 20:51:09 +09:00
ecfb7e94c5 Merge branch 'master' into fix-editor-batch-handling 2020-10-09 20:06:06 +09:00
07f19342d1 Merge pull request #10428 from peppy/editor-reset-newcombo-on-placement
Reset new combo button state after successful placement
2020-10-09 19:48:47 +09:00
bcc096ee49 Merge pull request #10446 from peppy/fix-timeline-tick-bar-lines
Fix bar lines ("down beat" as people call it) showing up too often in timeline
2020-10-09 19:24:29 +09:00
62690e4873 Merge pull request #10432 from peppy/editor-reverse-pattern
Add "reverse pattern" support to editor selection handler
2020-10-09 19:19:24 +09:00
3838f405dd Fix missed usages 2020-10-09 18:50:05 +09:00
edaf6db5c6 Reference EditorBeatmap directly for selected objects 2020-10-09 18:44:23 +09:00
21c6242f90 Fix bar lines ("down beat" as people call it) showing up too often in timeline 2020-10-09 18:35:44 +09:00
a1226ccaa2 Merge pull request #10440 from peppy/fix-editor-song-after-exit
Fix editor playing deleted beatmap's track on exit-without-save
2020-10-09 17:58:31 +09:00
5d888f687a Account for the width of points so they don't suddenly appear at timeline edges 2020-10-09 16:49:51 +09:00
ceb1494c33 Only run regeneration when passing a new min/max tick boundary 2020-10-09 16:47:29 +09:00
017a8ce496 Only recalculate when display actually changes 2020-10-09 15:57:31 +09:00
9baf704942 Add local pooling to TimelineTickDisplay 2020-10-09 15:48:24 +09:00
68039cff40 Set beatmap to sane default on exiting editor 2020-10-09 13:12:48 +09:00
825e10ec8c Add reverse handler button to selection box 2020-10-09 06:32:23 +09:00
eacc7dca9a Fix SliderPath not handling Clear correctly 2020-10-09 06:31:59 +09:00
85b33fffd0 Fix incorrect comments 2020-10-09 05:14:44 +09:00
5966205037 Fix ternary button states not updating correctly after a paste operation 2020-10-09 04:31:45 +09:00
e7eda19b07 Reset new combo button state after successful placement 2020-10-09 03:31:01 +09:00
4ccd751604 Further simplify non-transactional change logic 2020-10-08 18:42:53 +09:00
3114174e09 Add missing non-transactional SaveState calls 2020-10-08 18:41:03 +09:00
afed832b19 Tidy up EditorBeatmap slightly 2020-10-08 18:06:49 +09:00
1027b608ff Copy list content before firing events to avoid pollution 2020-10-08 18:04:07 +09:00
38babf3de5 Update usages of ChangeHandler to EditorBeatmap where relevant 2020-10-08 18:04:07 +09:00
b2d93f799f Hook ChangeHandler to transactional events rather than individual ones 2020-10-08 18:04:07 +09:00
0781fbd443 Make EditorBeatmap implement TransactionalCommitComponent 2020-10-08 18:04:07 +09:00
a9bca671d0 Make component and add hooking events 2020-10-08 18:04:07 +09:00
ce04daf053 Split transaction handling code out into base class 2020-10-08 18:04:07 +09:00
ef092de9ba Add missing UpdateHitObject calls and move local to usages (not via bindables) 2020-10-08 18:04:07 +09:00
ac44f6f679 Ensure control point group exists after move
If the control point group moved was empty, it would not be created due
to a lack of ControlPointInfo.Add() calls.
2020-10-07 23:10:28 +02:00
b1029a124c Move event subscription to LoadComplete
Prevents attempting to read from the `colours` field before it is
actually injected.
2020-10-07 22:57:20 +02:00
f206ea96ce Merge pull request #10391 from peppy/editor-setup-screen-difficulty-adjust
Add difficulty adjustment settings to editor setup screen
2020-10-07 16:33:10 +09:00
a6d1484ad5 Add arbirary precision specification for now 2020-10-07 14:26:01 +09:00
2ef5a34ace Merge branch 'master' into editor-beatmap-batch-change-support 2020-10-07 14:08:49 +09:00