Commit Graph

27851 Commits

Author SHA1 Message Date
b1a261c902 Avoid using scheduled delegates at all for skip overload input handling 2021-08-26 12:25:37 +09:00
956e3c554b Avoid skip overlay attempting to show when it is already invalid 2021-08-26 12:25:37 +09:00
b4d6495f99 Fix editor skin providing container not providing playable beatmap 2021-08-25 17:52:36 +03:00
f9b25a0159 Add test case for switching to each screen in editor test scenes 2021-08-25 17:52:35 +03:00
3ad0b529fb Make EditorScreen inherit from VisibilityContainer rather than unsafe transforms 2021-08-25 17:14:52 +03:00
196c74fce8 Gray out and remove player clock when users stop playing 2021-08-25 11:31:02 +03:00
599145b46a Stop clocks when removing them from sync manager 2021-08-25 11:31:02 +03:00
fd78d0440b Update missed conditional 2021-08-25 17:00:32 +09:00
ccfff50c6f Apply fixes in line with issues found during testing
I was trying to be too smart with caching, but if the `Play` method was
not called often enough it would have a recent reference. Unfortunately
this requires a separate query to `Entries`, but is also a special case
(no future hitobjects).

This also removes the time-based checks (result status alone should be
all we care about).
2021-08-25 16:56:44 +09:00
ef2b5e1c51 Tidy up variable names and unused resolved properties 2021-08-25 16:56:44 +09:00
a1936b141b Refactor base class to allow correct usage in taiko drum 2021-08-25 16:56:44 +09:00
681215e5b5 Rewrite object lookup to use previous entry regardless
This changes the fallback logic to always prefer the previous resolved
lifetime entry rather than fallback to the first entry ever. I think
this is more correct in all cases.

Also rewrites the inline comments to hopefully be easier to parse.
2021-08-25 16:56:44 +09:00
4a294d4de4 Optimise fallback logic to reduce lookups to bare minimum 2021-08-25 16:56:44 +09:00
6aa894e55e Split out separate component 2021-08-25 16:56:44 +09:00
351015357c Merge branch 'master' into user-events-in-participant-list 2021-08-25 14:39:26 +09:00
e1ab3434ed Add ability to handle user join/leave/kick events in MultiplayerComposites 2021-08-25 14:37:14 +09:00
ca527262e3 Merge branch 'master' into countdown-beatmap-info 2021-08-25 08:30:27 +03:00
84637b59ef Define DifficultyBindableWithCurrent and use in SliderControl 2021-08-25 07:40:41 +03:00
414457ba57 Add basic xmldoc explaining CountdownOffset 2021-08-25 13:24:52 +09:00
a6c2cbd2e5 Add countdown settings to beatmap info model 2021-08-24 21:55:10 +02:00
e503182a8d Merge branch 'master' into activity-on-multiplayer-screens 2021-08-24 18:50:55 +02:00
568a8ee97e Merge branch 'master' into fix-hud-test-failure-2 2021-08-24 16:54:48 +09:00
3f0f820653 Add comment explaining reasoning for override 2021-08-24 16:54:19 +09:00
08f757a584 Merge pull request #14474 from smoogipoo/fix-multi-crash
Fix crash when entering multiplayer gameplay
2021-08-24 16:20:18 +09:00
6a916a264f Merge pull request #14441 from Henry-YSLin/mod-incompatibility-ui
Show mods that are incompatible with the current selection
2021-08-24 16:16:35 +09:00
ea98ce1b39 Merge pull request #14465 from peppy/improve-stable-skin-import
Improve skin stable import behaviour to better handle similar skins
2021-08-24 16:08:15 +09:00
9f17c38e36 Fix hud overlay components being blocked from load 2021-08-24 15:18:27 +09:00
a5f6c287ea Split out pinned comment content to only be constructed when required 2021-08-24 14:43:28 +09:00
8cd972a9fe Merge branch 'master' into pinned-comment 2021-08-24 14:37:31 +09:00
16ddbcd208 Don't bind to RoomId where it's expected to be constant 2021-08-24 14:25:40 +09:00
c3b7ce0b05 Remove stray newline 2021-08-24 14:02:50 +09:00
afd01d22d6 Adjust visuals of incompatible icon and move to own class 2021-08-24 14:01:49 +09:00
847726547a Move mod value change callback inside wedge info text component 2021-08-24 07:53:49 +03:00
bf0a1167ec Improve update flow and ensure selected mods is read from local context 2021-08-24 13:35:39 +09:00
de0de451fe Refactor to remove resolved dependency 2021-08-24 13:29:19 +09:00
df170afbc4 Fix multiplayer crashing when entering gameplay 2021-08-24 13:22:06 +09:00
956c1cc216 Merge branch 'master' into activity-on-multiplayer-screens 2021-08-24 12:33:34 +09:00
dfd61e413a Merge branch 'master' into difficulty-cache-difficulty-adjust 2021-08-24 12:08:52 +09:00
3c9718339c Merge pull request #14444 from frenzibyte/decouple-ruleset-bindables
Decouple rankings overlay's ruleset selector from the game-wide ruleset bindable
2021-08-24 11:58:13 +09:00
b8fe03b77f Use Mod.Equals for comparison 2021-08-24 09:50:09 +08:00
6e3d05c7ce Display an icon to signify incompatibility instead of a red tint 2021-08-24 09:42:53 +08:00
13a24ed36f Merge branch 'master' into update-section-selection-childcount 2021-08-23 20:43:46 +03:00
ccf337bdc2 Merge branch 'master' into editor-setup-file-selector-popovers 2021-08-23 18:28:44 +02:00
6bea744e34 invalidate scroll position 2021-08-23 17:13:25 +01:00
20222f09c4 oops redundant default value 2021-08-23 16:55:31 +01:00
9a507ed273 update selected section on children count change 2021-08-23 16:27:29 +01:00
bd42d7aada Hide popover on file selection 2021-08-23 18:01:01 +03:00
a2484692b3 Change brackets to square 2021-08-23 20:37:19 +09:00
7b3f7cc7c1 Change skin import to also include directory names in the skin name where appropriate 2021-08-23 20:24:00 +09:00
fed0e15cea Fix typo in ArchiveModelManager 2021-08-23 20:23:46 +09:00