Commit Graph

10805 Commits

Author SHA1 Message Date
b7f7174055 Refactor BeatmapSetOverlay to use chained bindables instead of accessors to distribute changes 2019-02-28 18:46:28 +09:00
99812bd448 Apply suggestions from code review
Co-Authored-By: nyquillerium <nyquill@ppy.sh>
2019-02-28 18:25:58 +09:00
a37445a938 Merge branch 'master' into better-mp-songselect-deletion-handling 2019-02-28 17:35:08 +09:00
921346d303 Rename a few more members 2019-02-28 17:27:28 +09:00
b2872b47d0 Merge branch 'master' into UserDimLogic 2019-02-28 17:18:04 +09:00
951b95ff78 Fix potential race condition 2019-02-28 17:17:57 +09:00
9f9b2b1902 Remove redundant setters 2019-02-28 17:13:25 +09:00
4c8aa65200 private + renaming 2019-02-28 17:02:45 +09:00
69b1c76dce Actually implement blurring fix 2019-02-28 16:51:17 +09:00
93a4229ba6 Merge pull request #4357 from Joehuu/toquantity-1
Use ToQuantity instead for words with number prefixes
2019-02-28 16:37:36 +09:00
8cf83e2f4a Fix the check of beatmapset local availability 2019-02-28 16:14:50 +09:00
3a1066ff02 Merge branch 'master' into toquantity-1 2019-02-28 15:57:51 +09:00
6e821a426d Fix restoration of enabled mods when cancelling song select 2019-02-28 15:06:11 +09:00
cf2feec7df Fix multiplayer enabled mods check 2019-02-28 15:02:22 +09:00
2241e1af9d Use ToQuantity for words with number prefixes 2019-02-27 21:55:45 -08:00
2dbf7d122c Merge branch 'master' into use-pattern-matching 2019-02-28 14:53:07 +09:00
99e2e6cf1c Align text 2019-02-28 14:46:52 +09:00
774116923b A few fixes 2019-02-28 14:45:59 +09:00
e2c6a8bc07 Use pattern matching wherever possible 2019-02-28 14:35:00 +09:00
0788a7e9f1 Merge branch 'master' into more-inspections 2019-02-28 14:32:57 +09:00
42be7857d1 Use expression body for property get/set where possible 2019-02-28 13:58:19 +09:00
26d53d06a9 Fix remaining issues 2019-02-28 13:31:40 +09:00
ce17e37c74 Conditionally add some UI elements only on desktop
Prevents crashes from trying to access features that are not applicable to mobile.
2019-02-28 13:10:53 +09:00
3e1f283281 Merge remote-tracking branch 'upstream/master' into more-inspections 2019-02-28 13:09:18 +09:00
83e9dfda75 Merge branch 'master' into fix-osugame-test-case 2019-02-28 12:33:00 +09:00
43b02212ce Add disposal check in single file load path 2019-02-28 12:24:56 +09:00
76ec5868da Merge branch 'master' into fix-square-graph-overhead 2019-02-28 12:23:37 +09:00
0faf83f7d1 Fix nullref in tests 2019-02-27 23:30:13 +09:00
42442edf5a Update framework 2019-02-27 22:41:46 +09:00
d3a304c233 Merge branch 'master' into fix-home-button-cancel-2 2019-02-27 22:02:37 +09:00
53865c6857 Merge branch 'master' into better-mp-songselect-deletion-handling 2019-02-27 21:55:22 +09:00
ccb00b932b Merge branch 'master' into fix-nasty-unbind 2019-02-27 21:44:54 +09:00
c8793911a8 Enable more stringent inspectcode style inspections 2019-02-27 21:25:40 +09:00
7fa4262207 Clear delegate list rather than relying on unbinds 2019-02-27 21:04:47 +09:00
5c6db17865 Merge remote-tracking branch 'upstream/master' into fix-square-graph-overhead 2019-02-27 21:02:28 +09:00
d2c2e41e0c Merge branch 'master' into excess-skin-change 2019-02-27 20:30:18 +09:00
3af7d4939c Add debounce testing 2019-02-27 19:11:09 +09:00
43a1df6e5c Inline cancellation token source creation 2019-02-27 18:58:53 +09:00
6f5d4ce2e2 Debounce SquareGraph some more 2019-02-27 18:58:45 +09:00
8c4a59e57e Fix SquareGraph more 2019-02-27 18:58:34 +09:00
9473b53226 Avoid redundant (synchronous) skin change 2019-02-27 18:53:01 +09:00
882fff1631 Assert storyboard visibilty at both steps of toggle 2019-02-27 17:56:44 +09:00
99d8d39ea1 Merge branch 'master' into fix-crossthread 2019-02-27 17:46:12 +09:00
1006c539be Fix looping not being checked 2019-02-27 17:03:09 +09:00
14ffd9efe8 Add fake storyboard to visually assess storyboard dim 2019-02-27 17:02:04 +09:00
30815ace62 Fix crossthread operations due to Track.Completed 2019-02-27 16:52:34 +09:00
f66fefb818 Adjust comment + accessibility 2019-02-27 16:30:10 +09:00
c59d84fd21 Add sanity check to prevent TimeshiftPlayer from starting with incorrect beatmap/ruleset/mods 2019-02-27 16:21:14 +09:00
a3f71d69a9 Ensure ruleset and mods are set correctly when leaving MatchSongSelect 2019-02-27 16:16:13 +09:00
7c2ffb1826 Fix MatchSongSelect not handling beatmapset deletions 2019-02-27 14:34:39 +09:00