Commit Graph

610 Commits

Author SHA1 Message Date
ba99f1288c Update IBeatSnapProvider documentation to mention the pre-divided BeatSnap 2022-12-02 17:57:15 +09:00
6a61e70766 Expose Ruleset from HitObjectComposer instead 2022-11-30 12:17:58 +01:00
4215f4f5d7 Merge branch 'master' into Editor-DrawableRuleset-Dependencies 2022-11-30 17:42:46 +09:00
93ba84e5ff Fix code style 2022-11-27 21:48:44 +01:00
70c320b2e8 Provide ruleset dependencies only to Compose Placement Blueprints 2022-11-27 21:43:33 +01:00
894ef15e79 Merge branch 'master' into update-framework 2022-11-26 16:19:36 +01:00
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
76e9382e0b Fix triangles showing on ExpandableButtons when in contracted state 2022-11-25 20:18:35 +09:00
65e5c9a3ae Dispose DrawableRulesetDependencies in HitObjectComposer 2022-11-25 08:27:22 +01:00
7b620392fe Provide DrawableRulesetDependencies from HitObjectComposer 2022-11-24 13:13:45 +01:00
ada039151b Add the ability to toggle off hit marker displays in the editor 2022-11-08 18:07:06 +09:00
e02c477008 Merge pull request #21017 from andy840119/remove-nullable-disable-in-the-checks
Remove nullable disable in the checks.
2022-11-06 18:39:03 +09:00
29bc653d24 Remove incorrect double multiplication and add missing test coverage 2022-11-01 17:17:54 +09:00
2a88409dfe Fix time snap of sliders not matching when SV is not 1.0x
This regressed with https://github.com/ppy/osu/pull/20850 because the
function was used in other places which expect it to factor slider
velocity into the equation.

Rather than reverting, I've added a new argument, as based on the method
naming alone it was hard to discern whether SV should actually be
considered.

The reason for the change in #20850 was to avoid the SV coming in from a
reference object which may not have a correct SV in the first place. In
such cases, passing `false` to the function will give the expected
behaviour.
2022-11-01 15:12:58 +09:00
a1a9238bd1 Use empty string instead of null because issue template not accept null. 2022-10-30 16:31:07 +08:00
505ec800da File name should be nullable. 2022-10-30 16:29:54 +08:00
db48a57fa7 Remove nullable disable annotation in some checks class. 2022-10-30 16:28:49 +08:00
24c27e62f6 Remove nullable disable annotation in the issue and issue template-related class. 2022-10-30 16:25:15 +08:00
6b53ea3400 Enable distance snapping when DS value is changed via user interaction 2022-10-26 13:37:01 +09:00
7d59bc6e2f Merge branch 'grid-momentary-shortcuts' into read-current-distance-snap 2022-10-26 13:28:04 +09:00
54ae16badc Move distance snap toggle button implementation to DistancedHitObjectComposer 2022-10-26 13:27:23 +09:00
8d9a85e9e5 Fix typos in xmldoc
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-10-26 13:14:12 +09:00
48057412f5 Merge branch 'master' into grid-momentary-shortcuts 2022-10-25 22:17:08 +02:00
2b850694fa Merge branch 'allow-distance-grid-snap' into grid-momentary-shortcuts 2022-10-25 14:10:45 +09:00
d0e6bda9ef Stop HitObjectComposer from handling Shift+Number keys 2022-10-24 15:19:36 +09:00
f516e32949 Improve UI a bit 2022-10-21 23:35:53 +09:00
bb921ff9a7 Fix incorrect current DS value when inside a slider 2022-10-21 23:35:47 +09:00
f6de366766 Combine display and button into one control 2022-10-21 23:21:07 +09:00
645a84b1d6 Display current distance snap and add button to update to use it 2022-10-21 22:58:36 +09:00
7dc03097ff Change distance snap to never account for slider velocity
This is a nuanced detail that was implemented incorrectly from the
outset. When mapping, generally a mapper chooses the distance spacing
with no regard to the SV. It has always been common to have a lower
or higher distance spacing than SV, but with the way the lazer editor
has worked, the SV was multiplied into the distance snap grid display,
incorectly changing its spacing depending on the "reference object"
(which is usually the previous hitobject chronologically).
2022-10-21 21:51:24 +09:00
6cdfddea62 Always enable distance spacing when adusting distance space multiplier 2022-10-21 16:10:55 +09:00
860214c22a Adjust paddings to feel better now that backgrounds are visible of toolboxes 2022-10-18 14:38:45 +09:00
6a7f6c76ff Fix osu! editor padding being applied to toolboxes
The result of https://github.com/ppy/osu/pull/20739 and https://github.com/ppy/osu/pull/20738 having unintended side effects when applied together.
2022-10-18 14:32:00 +09:00
ccbac08985 Merge pull request #20593 from ekrctb/catch-editor-height
Allow arbitrary height catch editor
2022-10-18 12:10:49 +09:00
32c3e35762 Change background colour to a lighter tint to avoid clash with slider bars 2022-10-14 19:38:27 +09:00
4d99c7002b Add background behind editor toolbox groups 2022-10-13 16:36:19 +09:00
9247ff3e0a Allow changing scrolling speed in catch editor
Scroll speed is not saved and doesn't affect gameplay.
It is purely a feature for a better visualization.
It is currently bind to scroll speed increase/decrease.
Default F3/F4 crashes with editor shortcuts so it has to be changed.
2022-10-06 18:06:16 +09:00
ac99c1ad69 Migrate the majority of existing file lookups to use new extension methods 2022-08-10 16:01:16 +09:00
31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
26c5b59f6d Replace usages of string.To{Lower,Upper}() 2022-06-24 11:57:45 +02:00
bd5037fcad Fix new hitobject placements not taking on the existing sample settings
Similar to velocity / difficulty points, a user expectation is that
volume and sample settings will be transferred to newly placed objects
from the most recent one.

Closes https://github.com/ppy/osu/issues/18742.
2022-06-18 13:49:59 +09:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
e511c1dfff Merge branch 'master' into use-normalised-precise-scrolling 2022-05-27 16:55:13 +02:00
17206bbebf Update screen padding and colouring to better match new designs 2022-05-24 18:43:22 +09:00
88217e0c98 Adjust ScrollDelta usages to account for normalised IsPrecise values 2022-05-23 20:22:27 +02:00
64a371638e Merge pull request #18236 from peppy/snap-unification
Add `enum` to snap method as alternative to multiple nested invocations
2022-05-20 11:35:05 +09:00
b3d6f76cfa Add "None" snap type to fix flags not working correctly 2022-05-19 15:57:17 +09:00
c63e65c677 Don't hide SelectionBlueprints themselves, only their children 2022-05-12 19:26:13 +09:00
c0abce918f Add enum to snap method as alternative to mutliple nested invocations 2022-05-12 16:19:07 +09:00
144d33f0d2 Merge branch 'master' into distance-snapping-test 2022-05-06 17:29:27 +03:00