Commit Graph

55 Commits

Author SHA1 Message Date
d6656047e3 Fix beatmap statistics with value of zero not displaying correctly at song select
Closes #13307.
2021-06-03 01:58:51 +09:00
c1f27ba938 Merge branch 'master' into fix-song-select-star-rating-display-zero-flashing 2021-02-25 22:13:48 +09:00
9f3ceb99eb Fix the star rating display at song select flashing to zero when changing mods
Due to the use of bindable flow provided by `BeatmapDifficultyCache` in
this usage, the display would briefly flash to zero while difficulty
calculation was still running (as there is no way for a consumer of the
provided bindable to know whether the returned 0 is an actual 0 SR or a
"pending" calculation).

While I hope to fix this by making the bindable flow return nullable
values, I think this particular use case works better with non-bindable
flow so have switched across to that.
2021-02-25 16:05:13 +09:00
1fd76ea3fb Apply changes to UI components overriding functions with changing signatures 2021-02-22 19:01:42 +09:00
eaa7b4cb93 Rename second usage variable name to match 2021-02-11 14:54:50 +09:00
6fff7c39da Ensure tracker is disposed 2021-02-10 20:09:45 +09:00
393cd6c74a Add helper class for tracking changes to mod settings 2021-02-10 19:40:07 +09:00
5113d4af8f Rename BeatmapDifficultyManager to BeatmapDifficultyCache 2020-11-06 13:14:29 +09:00
cc6ae8e3bd Fix crash if only one count list is received from API 2020-08-24 20:41:31 +02:00
877b985e90 Remove local cancellation token 2020-07-24 16:11:28 +09:00
b10b99a670 Change method signatures to remove tracked/untracked 2020-07-24 13:52:43 +09:00
107b5ca4f2 Add support for bindable retrieval 2020-07-21 23:13:04 +09:00
24f14751ce Update beatmap details SR on ruleset/mod changes 2020-07-16 21:08:08 +09:00
0e2ccac33b Add spaces to comments 2020-05-04 18:36:24 -07:00
64a9b9c6fb Remove redundant using directives 2020-02-16 21:52:08 +01:00
4d180a685a Adjust font sizes and spacing in BeatmapSetOverlay 2020-02-16 21:43:33 +01:00
0bfadfbbf1 Apply precision when comparing adjusted values
In some cases, applying the Difficulty Adjust mod without actually
changing any of the settings previously caused the bar in song select
beatmap details to appear red/blue instead of staying white.

This was caused by not accounting for floating-point imprecisions when
determining bar colour in AdvancedStats. To resolve, first check
equality with tolerance, and only then apply blue/red colours if that
equality check does not hold.
2020-02-01 16:16:15 +01:00
a74d22d9e5 Extract beatmap stats test to separate scene 2020-02-01 15:50:33 +01:00
12ff51f686 Fix key count being incorrectly adjusted by hard/easy mods 2020-01-28 17:21:50 +09:00
b5ac707c6c Remove unnecessary directive 2020-01-12 21:09:48 +01:00
aa2645502c Fix adjusted value always being 0 2020-01-12 20:43:48 +01:00
a6bdf04f6b Remove unused using 2019-12-20 18:36:39 +09:00
822903d5db Update song select statistics when mod changes settings 2019-12-20 18:01:35 +09:00
6683460240 Merge branch 'master' into update-beatmap-settings 2019-12-18 17:59:27 +09:00
8e651962c7 Fix incorrectly binding inside BDL load() 2019-12-18 17:41:30 +09:00
ada2ae2b2c Use tuple to avoid potential for incorrect display 2019-12-18 17:12:41 +09:00
e87aa281bf Don't clone beatmap unnecessarily 2019-12-18 17:00:35 +09:00
ecfc6dfa3d CA1825: use Array.Empty. 2019-12-17 12:59:48 +08:00
3945e7403a improve tests and refactor AdvancedStats 2019-12-13 09:39:54 +08:00
ec5b506960 apply mod difficulty settings during song select 2019-12-12 23:41:46 +08:00
fccdbffa93 Use MathF instead of Math- functions when possible
MathF-functions are faster than the Math-counterpart and it looks cleaner, so use MathF when we cast to float or int anyway.
2019-11-25 00:45:42 +01:00
6cab517b2d .NET Standard 2.1 implements Math.Clamp , use it instead of MathHelper.Clamp from osuTK. 2019-11-20 13:37:47 +01:00
0a79b444d9 Move metrics to beatmap set 2019-06-13 16:52:49 +09:00
0788a7e9f1 Merge branch 'master' into more-inspections 2019-02-28 14:32:57 +09:00
42be7857d1 Use expression body for property get/set where possible 2019-02-28 13:58:19 +09:00
26d53d06a9 Fix remaining issues 2019-02-28 13:31:40 +09:00
a2aa3ec5cb Adjust sprite texts in-line with framework changes 2019-02-20 15:03:20 +09:00
8617aaa2a7 Update licence header (and remove year) 2019-01-24 17:43:03 +09:00
f27bd3ef3e OpenTK -> osuTK 2018-11-20 17:14:59 +09:00
1be2571d33 Make BeatmapSetOverlay accept nulls everywhere 2018-04-18 16:08:45 +09:00
32a74f95a5 Normalize all the line endings 2018-04-13 18:26:38 +09:00
37d393bca0 Update licence headers 2018-01-05 20:21:19 +09:00
d955229ee5 Handle user rating metrics when no maps by using more linq. 2017-11-25 21:29:23 +08:00
dbb03bcff2 Handle the case where a map hasn't been rated yet 2017-11-23 23:30:57 +09:00
d93911ae97 Improve user ratings calculations to make more sense
Closes #1552.
2017-11-23 18:10:08 +09:00
ea2fa5fa00 Fix wrong ratings calculations 2017-11-15 09:48:40 +03:00
5d5ea5fb2e Fix all remaining db structure issues 2017-10-19 14:05:11 +09:00
b178be21d1 Let's not rename columns yet 2017-10-14 14:30:58 +09:00
887aa7496b Rework EF Core usage in model classes 2017-10-06 00:23:26 +03:00
6a4198d0d6 Initial EF Core commit 2017-10-04 22:52:12 +03:00