Commit Graph

42994 Commits

Author SHA1 Message Date
3f34981664 Fix incorrect spinner top offset calculation with clarification 2021-03-11 05:40:20 +03:00
f6baf49ad6 Merge pull request #11989 from peppy/fix-ios-builds
Fix iOS release build crashes
2021-03-09 18:34:32 +09:00
4e8bcc9265 Fix SPM counter decreasing after spinner has already been completed 2021-03-09 16:54:46 +09:00
5a6864eb78 Fix SPM counter immediately disappearing on completion of spinners 2021-03-09 16:54:46 +09:00
8aaba32431 Fix storyboard commands occurring before the earliest point of visibility delaying gameplay
In osu-stable, storyboard intros start from the first command, but in
the case of storyboard drawables which have an initial hidden state, all
commands before the time at which they become visible (ie. the first
command where `Alpha` increases to a non-zero value) are ignored.

This brings lazer in line with that behaviour. It also removes several
unnecessary LINQ calls.

Note that the alpha check being done in its own pass is important, as
it must be the "minimum present alpha across all command groups,
including loops". This is what makes the implementation slightly
complex.

Closes #11981.
2021-03-09 15:55:12 +09:00
a5b3ac7ef8 Add failing test covering alpha commands proceeding non-alpha (but ignored) commands 2021-03-09 15:54:11 +09:00
296afd2d17 Merge pull request #11971 from bdach/taiko-judgement-pooling
Enable pooling for taiko judgements
2021-03-09 15:17:24 +09:00
0549395869 Inline "legacy coordinates container" and add "spinner Y centre" const 2021-03-09 08:55:32 +03:00
dc9028d24a Update framework 2021-03-09 14:27:29 +09:00
bb79da1aac Correct playfield shift counteract comment
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-03-09 00:34:00 +03:00
9b5d11f2a5 Merge pull request #11958 from bdach/ruleset-filter-v3
Allow rulesets to specify custom song select filtering criteria
2021-03-08 23:23:24 +09:00
d90cf532ea Merge pull request #11986 from peppy/configure-await-false
Use ConfigureAwait(false) for all async calls
2021-03-08 22:58:10 +09:00
ff2327ffac Merge branch 'master' into configure-await-false 2021-03-08 22:24:29 +09:00
f15ee813c2 Merge pull request #11985 from peppy/ios-signalr-workaround
Fix multiplayer/spectator not working on iOS
2021-03-08 16:32:51 +09:00
02194a93cb Apply missing additions to android project 2021-03-08 15:22:03 +09:00
6cb0db9c33 Apply override rules to iOS/Android test projects 2021-03-08 14:54:49 +09:00
d2bc48e576 Exclude tests from ConfigureAwait rule 2021-03-08 14:36:35 +09:00
b1cd01ceb8 Apply ConfigureAwait changes to game side 2021-03-08 14:36:35 +09:00
765cc5cf37 Remove iOS multiplayer blocking code 2021-03-08 14:35:22 +09:00
7763e1dbe1 Apply workaround for runtime iOS failures
See https://github.com/mono/mono/issues/20805#issuecomment-791440473.
2021-03-08 14:35:22 +09:00
85bad1ab89 Merge pull request #11934 from ppy/dependabot/nuget/Microsoft.Extensions.Configuration.Abstractions-5.0.0
Bump Microsoft.Extensions.Configuration.Abstractions from 2.2.0 to 5.0.0
2021-03-08 14:07:43 +09:00
ef88cbd9f4 Merge pull request #11984 from peppy/intro-triangles-background-access
Fix potential cross-thread drawable mutation in IntroTriangles
2021-03-08 14:06:26 +09:00
f46880f68a Merge branch 'master' into intro-triangles-background-access 2021-03-08 13:31:09 +09:00
74fc5d5b8c Fix potential cross-thread drawable mutation in IntroTriangles 2021-03-08 13:30:07 +09:00
d961d110bf Bump Microsoft.Extensions.Configuration.Abstractions from 2.2.0 to 5.0.0
Bumps [Microsoft.Extensions.Configuration.Abstractions](https://github.com/dotnet/runtime) from 2.2.0 to 5.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](https://github.com/dotnet/runtime/commits/v5.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-08 02:58:52 +00:00
ed4577a130 Merge pull request #11940 from frenzibyte/migrate-country-rank 2021-03-08 11:57:35 +09:00
2b1ab3576b Merge branch 'master' into migrate-country-rank 2021-03-08 11:07:25 +09:00
0ad3073c1a Use MathF utility class instead
Co-authored-by: Berkan Diler <b.diler@gmx.de>
2021-03-07 21:21:44 +03:00
fbfaa378fc Move spinner top offset constant outside 2021-03-07 20:47:16 +03:00
418f33dc17 Merge pull request #11977 from Joehuu/fix-legacy-combo-counter-depth 2021-03-07 16:49:13 +01:00
95902dfb8e Merge branch 'master' into fix-legacy-combo-counter-depth 2021-03-07 16:15:31 +01:00
503f29609a Also set additive mode to match stable 2021-03-07 23:40:09 +09:00
f5a80e6269 Merge branch 'master' into taiko-judgement-pooling 2021-03-07 13:35:25 +01:00
fb19890d1d Merge pull request #11970 from bdach/taiko-legacy-judgement-leftovers 2021-03-07 13:34:46 +01:00
413cbb30a0 Reword playfield shift counteract comment
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-03-07 13:39:46 +03:00
3e4dfdb675 Fix pop out count being above displayed count on legacy combo counter 2021-03-06 20:37:27 -08:00
ad1b86e33a Change LifetimeEnd idiom to Expire() for readability 2021-03-06 18:54:25 +01:00
30f07aa9fc Add legacy spinner bonus counter piece 2021-03-06 20:27:56 +03:00
3f1d36ee6b Add default spinner bonus counter piece 2021-03-06 20:27:56 +03:00
c441e993ff Separate "gained bonus" to a read-only bindable 2021-03-06 20:27:56 +03:00
1841a4d1c9 Extract legacy spinner presence to lazy field 2021-03-06 20:27:56 +03:00
e4afe717d5 Publicize legacy coordinates container and sprite scale 2021-03-06 20:27:56 +03:00
97f56340af Add legacy score font to testing old skin 2021-03-06 20:27:56 +03:00
8f4dadb06a Enable pooling for taiko judgements 2021-03-06 17:38:04 +01:00
1525480e73 Demonstrate value of SPINNER_TOP_OFFSET to being more sensible 2021-03-06 19:18:40 +03:00
06e42b4b4c Fix taiko leaving behind empty judgements on legacy skins 2021-03-06 16:02:20 +01:00
12b7d9e06d Simplify custom filter criteria retrieval 2021-03-06 12:16:01 +01:00
f00089846b Merge branch 'master' into ruleset-filter-v3 2021-03-06 12:14:53 +01:00
b241749119 Merge pull request #11928 from smoogipoo/fix-test-multiplayer-beatmap 2021-03-04 23:43:55 +09:00
a0ccfa8129 Merge pull request #11961 from frenzibyte/fix-sensitivity-globally-disabled 2021-03-04 23:38:36 +09:00