Commit Graph

49592 Commits

Author SHA1 Message Date
5b6b8d1fa9 Remove GetStandardisedScore() proxy method 2022-03-08 21:49:41 +09:00
6654977a7b Add GetScore() overload with total hitobject count 2022-03-08 21:49:41 +09:00
2c382bd1d9 Rename GetImmediateScore() as overload of GetScore() 2022-03-08 21:49:40 +09:00
c867068cae Update framework 2022-03-08 21:15:14 +09:00
da7c6f1772 Merge branch 'master' into chat-mention-highlight 2022-03-08 21:15:12 +09:00
a352a140bc Merge pull request #17157 from peppy/fix-statistics-json-serialisation
Fix incorrect serialisation of submitted scores
2022-03-08 20:20:31 +09:00
d13a66a96c Rework test scene by only relying on OnlineID 2022-03-08 20:11:56 +09:00
960b6528ca Ensure the value used during realm async write is the same as whe compared for equality 2022-03-08 19:36:23 +09:00
daa42584f4 Fix feedback from realm writes causing offset slider to jump around 2022-03-08 19:36:08 +09:00
4603e082f5 Merge pull request #17160 from peppy/remove-unnecessary-user-submittable-score
Remove `user` from `SubmittableScore`
2022-03-08 19:34:47 +09:00
f5cd967635 Fix scores not being recalculated in beatmap listing 2022-03-08 19:07:39 +09:00
e0dc3a04f3 Merge pull request #17159 from smoogipoo/add-hitresult-helper
Add IsBasic() and IsTick() extensions on HitResult
2022-03-08 18:46:39 +09:00
b0f40d9e45 Remove user from SubmittableScore
This wasn't being used by osu-web, and included far too much unnecessary
data. Of note, `pp` and `ruleset_id` are also not strictly required, but
there's no harm in sending them so I've left them be for now.
2022-03-08 18:38:24 +09:00
6565c95b17 Remove unused variable 2022-03-08 18:19:54 +09:00
a172fc6cb8 Add IsBasic() and IsTick() extensions on HitResult 2022-03-08 18:19:12 +09:00
0718a55ad0 Add flow to allow recovery after running an older release (with a different realm database version)
As brought up in https://github.com/ppy/osu/discussions/17148
2022-03-08 18:15:28 +09:00
9a347af5c7 Add test coverage of SubmittableScore serialisation to (roughly) match spec 2022-03-08 17:58:52 +09:00
589a40ca2d Add EnumMember naming to HitResult to allow for correct json serialisation 2022-03-08 17:58:37 +09:00
719331420c Merge pull request #17155 from peppy/beatmap-leaderboard-dont-handle-offset-changes
Fix `BeatmapLeaderboard` refreshing on changes in local offset setting
2022-03-08 15:38:05 +09:00
622ec53130 Fix BeatmapLeaderboard refreshing on unrelated changes to a beatmap 2022-03-08 14:50:47 +09:00
2a55c5e02e Add extension method to detect and isolate realm collection-level changes 2022-03-08 14:50:47 +09:00
ae1c65c38d Add xmldoc 2022-03-08 12:07:10 +08:00
8cfeffc085 Extract a major part of ApplyToBeatmap to a new method 2022-03-08 11:50:30 +08:00
ded84cab3f Separate randomisation and object positioning logic 2022-03-08 11:45:16 +08:00
5e0882df8d Simplify message highlighting transforms 2022-03-08 04:00:11 +03:00
d74064b94b Use Equals instead of reference equality operator 2022-03-08 03:56:27 +03:00
f645869958 Update ChannelManager.CurrentChannel directly to handle non-loaded chat scenario
`currentChannel` gets instantiated once the chat overlay is open, while
`HighlightMessage` could be called while the chat overlay has never been
open.

This will all be rewritten with the new chat overlay design anyways, so
should be fine for now.
2022-03-08 03:42:18 +03:00
f8e5570e41 Fix Message equality not passing on equal references 2022-03-08 03:20:20 +03:00
7f47be4680 Refactor message highlighting logic to rely on a Channel data bindable 2022-03-08 03:19:37 +03:00
5764c53c17 OpenChannelNotification -> HighlightMessageNotification 2022-03-08 03:16:07 +03:00
22a2ef42c5 Check channel ID on message highlight using currentDrawableChannel 2022-03-08 01:22:47 +03:00
643f68e844 Better annotate initial rolling counter value set 2022-03-07 23:11:20 +01:00
019f4d965d Show two decimal digits on mod multiplier rather than one 2022-03-07 22:55:55 +01:00
c25d7a1c75 Use rolling counter for multiplier display 2022-03-07 22:50:51 +01:00
78a3b5961e Implement basic difficulty multiplier display 2022-03-07 22:50:51 +01:00
a02adfdbd4 Fix crash on super high bpm kiai sections 2022-03-07 20:36:09 +02:00
e0d2c8ca5e Merge pull request #17046 from peppy/clowd-squirrel
Replace squirrel fork with `Clowd.Squirrel`
2022-03-07 16:25:40 +09:00
51f6eb4028 Merge pull request #17075 from peppy/realm-property-watching
Add ability to watch properties via a `RealmAccess` helper method
2022-03-07 14:38:23 +09:00
31d6c75f40 Merge branch 'master' into realm-property-watching 2022-03-07 13:53:17 +09:00
b90a5864b1 Merge pull request #17138 from peppy/disallow-icon-interaction
Disallow interaction with carousel set difficulty icons unless selected
2022-03-07 13:00:18 +09:00
da29947ecd Disallow interaction with carousel set difficulty icons unless selected
I kinda liked this flow, but from multiple reports from users it
definitely seems in the way. We can revisit after the new design is
applied to song select.

Note that this means the tooltips also don't display. If it is preferred
that they should (arguable from a UX perspective, since I'd expect to be
able to click at that point) then the issue can be addressed using a
slightly different path (a few more lines - nothing too complex).
2022-03-07 11:34:08 +09:00
bd1adaf245 Merge pull request #17115 from frenzibyte/manual-channel-scroll
Refactor channel scrolling container to handle non-user scrolls
2022-03-07 11:26:23 +09:00
32d242dd62 Hook up message notifications to chat message highlighting logic 2022-03-07 05:10:49 +03:00
741702549b Add test coverage for chat overlay message highlighting 2022-03-07 05:10:49 +03:00
f4fa80c1e3 Add support to highlight messages in chat overlay 2022-03-07 05:10:49 +03:00
cb2133944d Add test coverage for channel message highlighting 2022-03-07 05:10:49 +03:00
30b38345aa Add ability to highlight chat lines 2022-03-07 05:08:36 +03:00
ba83db0229 Merge pull request #17134 from bdach/mod-overlay/popup-screen-title
Implement popup screen title component
2022-03-07 11:03:38 +09:00
3e73b8c78a Merge pull request #17059 from frenzibyte/fix-storyboard-sample-rate
Fix storyboard samples rate not adjusted from actual gameplay mods
2022-03-07 09:41:06 +09:00
e5a6564034 Merge branch 'master' into fix-storyboard-sample-rate 2022-03-07 03:12:40 +03:00