Commit Graph

58 Commits

Author SHA1 Message Date
ee13632375 Fix ogg beatmap/skin samples not loading 2020-02-18 13:21:55 +09:00
77fb632d44 Remove now unnecessary using 2020-01-03 17:57:01 +09:00
c07cfce3b3 Merge branch 'master' into resource-assembly 2020-01-03 17:56:25 +09:00
467fb0c3be Add archive resources for testing (#7421)
Add archive resources for testing
2020-01-02 16:59:25 +09:00
911816c282 Add archive test resources 2020-01-02 16:43:32 +09:00
878e9f182e Add storyboard sample test scene 2020-01-02 15:23:41 +09:00
1b33581667 Construct DllResourceStore with assemblies 2019-12-28 21:13:18 +08:00
0d49bc244e Fix test beatmap not being retrievable anymore 2019-12-13 21:30:28 +09:00
c976427206 Refactor test to be more complete 2019-12-13 19:00:28 +09:00
0407d2248c Merge remote-tracking branch 'refs/remotes/upstream/master' into add-access-to-skin-legacy-version 2019-11-20 01:10:32 +03:00
cf2d885099 Fix control points being flushed too late 2019-10-30 18:02:18 +09:00
7c6ccce3ba Add tests covering precision case 2019-10-29 18:02:30 +09:00
8df2e359c4 Fix tests on CI 2019-10-10 17:42:15 +09:00
d15db378ce Add tests for legacy skin decoding 2019-10-09 23:06:53 +03:00
86588778b1 Implement fallback decoder registration
After the preparatory introduction of LineBufferedReader, it is now
possible to introduce registration of fallback decoders that won't drop
input supplied in the first line of the file.

A fallback decoder is used when the magic in the first line of the file
does not match any of the other known decoders. In such a case,
the fallback decoder is constructed and provided a LineBufferedReader
instance. The process of matching magic only peeks the first non-empty
line, so it is available for re-reading in Decode() using ReadLine().

There can be only one fallback decoder per type; a second attempt of
registering a fallback will result in an exception to avoid bugs.

To address the issue of parsing failing on badly or non-headered files,
set the legacy decoders for Beatmaps and Storyboards as the fallbacks.

Due to non-trivial logic, several new, passing unit tests with possible
edge cases also included.
2019-09-15 01:28:07 +02:00
343af28ed5 Add extra legacy skin parsing tests 2019-09-03 18:59:23 +09:00
15a592e25e Just assert doesn't throw and don't catch at LegacyDecoder 2019-08-07 19:25:40 +09:00
497d2cb677 shorten tests and rename 2019-08-06 12:35:18 +09:00
cd6fe91882 Log error for invalid events 2019-08-06 10:05:21 +09:00
58efa7a177 Merge pull request #4729 from peppy/fix-control-point-ordering
Fix control points with same timestamp potentially being parsed incorrectly
2019-05-21 15:33:27 +09:00
f1c9073338 Fix commented line check not working with whitespace 2019-05-14 16:16:55 +09:00
19bc6b72cc More tests to showcase failures 2019-05-14 10:13:42 +09:00
7aa10956b5 Add unit test 2019-05-14 09:46:42 +09:00
a08086cc8a Fix volume not being considered for file samples 2019-03-05 18:21:29 +09:00
a6b2e9eb0b Remove unused pieces of ini 2019-02-05 18:08:27 +09:00
2f8f4fac64 Fix combo colour fallbacks when skin is not providing any 2019-02-05 17:54:14 +09:00
8d4faafdbe Rename file to match class 2019-01-28 18:41:57 +09:00
628b3e1119 Move osu-resources to nuget 2019-01-28 18:33:39 +09:00
8617aaa2a7 Update licence header (and remove year) 2019-01-24 17:43:03 +09:00
eb88768bd0 Fix incorrect controlpoint being applied to samples 2018-12-03 17:21:27 +09:00
ace1dce281 Merge remote-tracking branch 'origin/master' into fix-slider-samples
# Conflicts:
#	osu.Game.Tests/Beatmaps/Formats/LegacyBeatmapDecoderTest.cs
2018-11-05 18:10:22 +09:00
92d570342c Fix sample additions not falling back to non-addition bank 2018-11-05 17:35:24 +09:00
a4caaf56ef Merge remote-tracking branch 'origin/master' into fix-slider-samples
# Conflicts:
#	osu.Game.Tests/Beatmaps/Formats/LegacyBeatmapDecoderTest.cs
#	osu.Game/Rulesets/Objects/Legacy/Catch/ConvertHitObjectParser.cs
#	osu.Game/Rulesets/Objects/Legacy/ConvertHitObjectParser.cs
#	osu.Game/Rulesets/Objects/Legacy/Mania/ConvertHitObjectParser.cs
#	osu.Game/Rulesets/Objects/Legacy/Osu/ConvertHitObjectParser.cs
#	osu.Game/Rulesets/Objects/Legacy/Taiko/ConvertHitObjectParser.cs
2018-11-05 16:38:28 +09:00
8a2a6a3ecb Preserve the beatmap's version 2018-10-23 14:59:21 +09:00
47be95ce0b Fix slider nodes using the wrong samples 2018-10-16 17:10:24 +09:00
cb1703c6e2 Fix colours with alpha components not being parsed 2018-10-05 11:19:01 +09:00
557a2ee39d Add more comprehensive tests 2018-08-17 10:04:00 +09:00
05b5144dac Add parsing test 2018-08-15 13:36:22 +09:00
e360985d73 Replace variables into the entire line 2018-08-14 18:15:09 +09:00
c087a73f40 Implement per-hitobject custom sample banks 2018-07-20 15:12:44 +09:00
967d0c3c72 Adjust testcase 2018-07-20 15:12:04 +09:00
c1b8799253 Add simple testcase 2018-07-02 14:40:43 +09:00
3a9a82c80c Add back legacy custom sample banks 2018-06-28 18:29:12 +09:00
32a74f95a5 Normalize all the line endings 2018-04-13 18:26:38 +09:00
37d393bca0 Update licence headers 2018-01-05 20:21:19 +09:00
c99ea32574 Merge branch 'master' into beatmap-serialization 2017-12-21 13:39:39 +09:00
b0684cb194 Add storyboard test case but disable for now 2017-12-07 12:02:34 +09:00
499ecb4edd Add parity checking OsuJsonDecoder test cases 2017-12-07 11:11:38 +09:00
2bbfe0dda1 expanded BeatmapDecoder tests, added StoryboardDecoder tests 2017-12-02 15:28:00 +01:00
1e6c480791 Add back missing tests 2017-09-25 11:58:37 +08:00