Commit Graph

2217 Commits

Author SHA1 Message Date
2881ce0f5a Merge branch 'master' into remove-stupid-weak-reference-bindable-events 2021-11-06 14:08:39 +09:00
54f72d68ca Revert weird event flow in model manager/importers 2021-11-05 19:12:49 +09:00
6c385ccd29 Move second generic to abstract model downloader rather than interface type 2021-11-05 17:37:05 +09:00
1fe9bca819 Change ModelDownloader's requirement to an IModelImporter rather than IModelManager 2021-11-05 16:47:18 +09:00
b90f44493c Remove importer inheritance from IModelManager
Now only exists in legacy implementations, to reduce inheritance
complexity of interfaces which are going to be used going forwards.
2021-11-05 16:45:38 +09:00
4b1b92cde6 Stop BeatmapInfo from implementing IBeatmapOnlineInfo and remove all usages 2021-11-04 15:23:04 +09:00
9c926e5514 Remove BeatmapSetInfo.OnlineInfo and all usages 2021-11-04 15:23:04 +09:00
0d0eab90bc Merge branch 'beatmap-refactor/playlist-use-api-beatmap-extended' into beatmap-refactor/remove-online-info 2021-11-04 15:23:02 +09:00
84d36cbae7 Add fallback for cases where BeatmapSet may be null
Seems to only happen in tests, but better safe than sorry.
2021-11-04 15:22:33 +09:00
a49366ff84 Remove nullability from IBeatmapInfo.Metadata 2021-11-04 14:28:39 +09:00
1e73b09e57 Fix another couple of cases of incorrect string null/empty checking 2021-11-04 14:22:28 +09:00
41854f2e16 Fix incorrect check on AudioFile presence 2021-11-04 14:02:09 +09:00
67d9590a79 Fix new inspections 2021-11-04 14:02:09 +09:00
772b6c6dcd Enable nullable support on BeatmapMetadata 2021-11-04 12:11:42 +09:00
ca438a102d Fix beatmap paths including invalid slash/backslash characters 2021-11-03 16:46:05 +09:00
cf7545e36c Merge branch 'master' into beatmap-card-basics 2021-11-03 00:11:03 +01:00
1813681fac Move private method below protected 2021-11-03 00:10:50 +01:00
75e89f17ad Rewrite BeatmapCardContentBackground 2021-11-03 00:07:03 +01:00
5ea901da2e Merge pull request #15429 from peppy/fix-beatmap-download-notifications
Fix beatmap download notifications not showing beatmap name correctly
2021-11-03 04:36:59 +09:00
392559ae3e Fix beatmap download notifications not showing beatmap name correctly 2021-11-03 03:23:41 +09:00
6efd3d3115 Don't perform background difficulty calculation for multiplayer panels
There are cases these are shown in a long list. They shouldn't be
running calculations.
2021-11-03 03:12:52 +09:00
08b0ffad50 Fix incorrect check for local beatmap in BeatmapDifficultyCache
This was correct in the WIP branch I have, but pulled out alone (where
usages of `ToBeatmapInfo` still exist) it was not enough.
2021-11-03 03:12:52 +09:00
15c770e155 Remove no longer used Section.None 2021-11-02 14:01:41 +09:00
ab28948744 Default legacy decoder to General section, rather than none
This is mainly to reach parity with how stable handles such cases for
skins specifically. It was brought to our attention after finding a skin
with a malformed `\[General]` tag which did not break further parsing of
the file on stable, but did on lazer.

Note that stable defaults to an "unknown" section for beatmaps, but
functionally I can't think of a regression case from changing this to a
"general" default.
2021-11-02 13:59:13 +09:00
f671ee28c5 Use buffered container to eliminate gaps near foreground border 2021-11-01 20:17:27 +01:00
a59f2d7b83 Implement basic hover card state 2021-11-01 19:41:11 +01:00
5962f16b1c Implement basic card appearance 2021-11-01 19:41:11 +01:00
9e633a1b17 Merge pull request #15321 from peppy/beatmap-refactor/download-tracker
Replace `DownloadTrackingComposite` with instantiable `DownloadTracker` components
2021-11-01 15:48:12 +09:00
10a9266956 Fix beatmap creator showing twice in tournament map pool panels 2021-11-01 14:33:24 +09:00
19feae4a8e Merge branch 'master' into beatmap-refactor/download-tracker 2021-11-01 13:15:36 +09:00
b0c4fa662d Merge branch 'master' into long-online-id-score-info 2021-10-30 14:35:30 +02:00
07e3ced315 Fix test scene and remove "impossible" nullable coalesce 2021-10-29 18:22:23 +09:00
7db8bdfb7c Fix fallback logic not considering case where ruleset is not available
Occurs only in tests.
2021-10-29 18:16:54 +09:00
be0564f732 Update DifficultyIcon classes to use IBeatmapInfo 2021-10-29 17:05:06 +09:00
7583435901 Refactor BeatmapDifficultyCache to work with IBeatmapInfo 2021-10-29 16:45:10 +09:00
3b095e1626 Merge branch 'master' into beatmap-refactor/download-tracker 2021-10-29 11:50:54 +09:00
34d4715220 Allow for long online IDs and implement in ScoreInfo 2021-10-29 11:48:36 +09:00
65a7b6776e Add note regarding OnlineInfo being temporary 2021-10-28 05:50:22 +09:00
7245baba69 Remove IBeatmapSetOnlineInfo implementation from BeatmapSetInfo to avoid null cases 2021-10-28 00:50:45 +09:00
617e6febb6 Refactor ModelDownloader to allow for different OnlineID matching 2021-10-27 21:00:46 +09:00
f268363924 Update UpdateableBeatmapBackgroundSprite to accept IBeatmapInfo 2021-10-27 16:38:48 +09:00
6944151486 Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
3de994449d Add support for changing dimensions of difficulty spectrum display 2021-10-26 23:06:52 +02:00
1a77e98537 Implement difficulty spectrum display 2021-10-26 23:06:52 +02:00
e92def0ba2 Fix LegacyBeatmapEncoder using incorrect path length value 2021-10-26 17:34:52 +09:00
efe6763226 Merge branch 'master' into move-online-beatmap-metrics 2021-10-26 14:24:40 +09:00
5a03e1736e Merge branch 'master' into update-beatmap-set-status-pill-appearance 2021-10-25 20:26:49 +02:00
6802e9ec10 Remove FixedWidth and add AutoSizeAxes specs to all usages 2021-10-25 20:24:48 +02:00
6adb0f068b Fix multiple issues with json serialisation of online info (causing tournament failures) 2021-10-25 16:52:50 +09:00
2c308f3008 Rename BeatmapMetrics to APIFailTimes 2021-10-25 15:34:41 +09:00