97204b6f27
Reduce unnecessary background changes via IEquatable implementation
2021-06-08 22:37:18 +02:00
f628ec25ef
Add test coverage for keeping same background instance
2021-06-08 22:31:09 +02:00
a98c302211
Bring back skin background source
2021-06-08 22:04:59 +02:00
d86ace4d11
Add test coverage for skin background source
2021-06-08 22:03:59 +02:00
5bf4dd6358
Move skin background to separate file
2021-06-08 21:57:08 +02:00
2484ccd50c
Ensure scale x or y does not go below zero in SkinSelectionHandler.HandleScale
2021-06-08 11:49:25 -04:00
410cb16340
Apply fixed label width to setup screen items
2021-06-08 17:18:00 +02:00
88266eac63
Add option to fix label width of a LabelledDrawable
2021-06-08 16:57:32 +02:00
04cc788627
Merge pull request #13380 from smoogipoo/fix-multi-spec-dt-doubling-2
...
Fix DT being doubled in multiplayer spectator
2021-06-08 23:31:56 +09:00
10b6b72909
Add guard clause to applyOrigins and rename parameter
2021-06-08 10:29:45 -04:00
d212918d67
Rename applyCustomAnchors to applyFixedAnchors for consistency with UsesFixedAnchor
2021-06-08 10:14:07 -04:00
00efed2c39
Add colours for tick judgements
2021-06-08 23:10:21 +09:00
2c88e6df8d
Simplify applyClosestAnchor to one line by moving another guard clause
2021-06-08 10:09:48 -04:00
c8e14d7710
Ignore non-scorable and bonus judgements
2021-06-08 23:09:23 +09:00
c3ea1b26e1
Fix DT being doubled in multiplayer spectator
2021-06-08 22:51:42 +09:00
f22cc981d1
Move guard clause from checkAndApplyClosestAnchor to applyAnchor
2021-06-08 09:51:39 -04:00
529a80871b
Rename some methods for clarity
...
Methods which operate on a collection of `ISkinnableDrawable`s are now
plural; ones which take a single item are singular.
This also allows cutting down the name of `getClosestAnchorForDrawable`
to just `getClosestAnchor`.
2021-06-08 09:44:42 -04:00
01da73daf2
Refactor updateDrawableAnchorIfUsingClosest
2021-06-08 09:25:49 -04:00
6b127f50f2
Inline updateDrawableAnchorIfUsingClosest
2021-06-08 09:14:04 -04:00
7df971a970
ICatcherPiece -> ICatcherSprite
2021-06-08 22:10:13 +09:00
194c78f67a
Make current state bindable protected
2021-06-08 22:08:54 +09:00
109a366722
Use separate classes for old and new catcher legacy skin element
...
- Fix catcher texture animation is reset for legacy old catcher skin
2021-06-08 21:59:09 +09:00
0192549d6c
Refactor catcher sprite to use skinned piece pattern
2021-06-08 21:29:41 +09:00
dc50ae40b9
Rename OverridesClosestAnchor to UsesFixedAnchor
2021-06-08 08:28:42 -04:00
475788041a
Merge pull request #13337 from Pasi4K5/fix-sliders-out-of-screen
...
Fix sliders sometimes being outside of the playfield with osu! random mod enabled
2021-06-08 21:18:21 +09:00
25af4dfa8a
Merge pull request #13375 from smoogipoo/fix-multi-nullref
...
Fix possible nullref when exiting song select too fast
2021-06-08 20:47:40 +09:00
5a8cde7e6f
Merge pull request #13377 from peppy/fix-lazer-replays-getting-classic
...
Move legacy `ScoreInfo` to be completely based on presence of classic mod
2021-06-08 19:15:13 +09:00
d9ac9f641a
Merge pull request #12970 from peppy/fix-skin-sample-lookup
...
Fix default skin sample fallback logic existing within `PoolableSkinnableSample`
2021-06-08 19:10:04 +09:00
f1bef989b7
Refactor DifficultyAttributes to use auto properties over public fields
2021-06-08 19:43:59 +10:00
0b9916b266
Add parens to declare operator precedence
2021-06-08 18:39:52 +09:00
4ee7721c51
Extract first version out to constant
2021-06-08 18:38:47 +09:00
d31e3e8f1c
Fix nullref
2021-06-08 18:23:03 +09:00
b287366c8b
Remove forgotten classic mod addition
2021-06-08 18:09:57 +09:00
061e3d7f26
Move legacy ScoreInfo to be completely based on presence of classic mod
2021-06-08 18:00:09 +09:00
4d9fffc01b
Update score encoder version to be higher than any existing stable version
2021-06-08 17:59:43 +09:00
6e28c1b29a
Move default catcher sprite to its own file
2021-06-08 17:54:57 +09:00
ab9290772b
Fix a similar case with online play sub-screens
2021-06-08 17:54:54 +09:00
860f1aebb3
Only call OnBackButton() if the screen has finished loading
2021-06-08 17:38:12 +09:00
6017ef3825
Merge branch 'master' into fix-skin-sample-lookup
2021-06-08 17:37:36 +09:00
e5e3509c87
Merge pull request #13264 from peppy/legacy-skin-default-fallback
...
Allow fallback to legacy defaults from legacy skins
2021-06-08 17:30:27 +09:00
c0fdbfba04
Merge pull request #13374 from peppy/update-framework
...
Update framework
2021-06-08 17:09:20 +09:00
490ab9e96a
Fix typo
2021-06-08 17:09:03 +09:00
7fa0ac6ed7
Fix possible nullref when exiting song select too fast
2021-06-08 17:03:50 +09:00
791855dfa0
Merge branch 'master' into legacy-skin-default-fallback
2021-06-08 16:54:26 +09:00
e3cb6f45f5
Merge pull request #13371 from peppy/fix-poolable-sample-disposal-skin-change
...
Clean up previous sample immediately on skin source change to avoid `Play` after disposal
2021-06-08 16:52:59 +09:00
751a5e7cf3
Merge pull request #13373 from peppy/catch-no-visibility-increase
...
Don't apply visibility increase to first object in osu!catch
2021-06-08 16:39:21 +09:00
89895f6ce4
Update framework
2021-06-08 16:24:00 +09:00
67135ce3db
Add null check
2021-06-08 16:15:17 +09:00
e388a896e8
Don't apply visibility increase to first object in osu!catch
...
The goal of the visibility increase is to help in cases where timing is
an issue (by showing the approach circle etc.). This doesn't need to
apply to catch.
@smoogipoo interested as to whether you agree with this one. Visually it
looks better to me but it does change the behaviour for only osu!catch,
so I'm not 100% confident on it.
Closes #13367 .
2021-06-08 16:02:26 +09:00
e2fdc23d98
Merge branch 'fix-skin-sample-lookup' into results-screen-sfx
2021-06-08 15:20:11 +09:00
