f04add6d9e
Add bracket handling to Markdown link format
...
Allow users to put both balanced brackets, as well as unbalanced
escaped ones, in Markdown link text. The implementation is the exact
same as in the case of new format links.
For completion's sake, tests also included.
2019-09-04 00:07:00 +02:00
24d4f0372c
Refactor link parsing regexes to use named groups
...
For the sake of readability, consistency and to make further changes
easier, introduce named groups (?<text>) and (?<url>) to all link
parsing regexes which have parts containing the desired link text
and (optionally) URL.
The introduction of the named groups additionally simplifies
handleMatches() and makes all calls to it consistent.
2019-09-04 00:06:52 +02:00
a8f16503e2
Add backslash escaping to new link format
...
For users to be able to add square brackets inside of links using
the new format, the regular expression used for parsing those links
contained a balancing group, which can be used for matching pairs
of tokens (in this case, opening and closing brackets, in that order).
However, this means that users could not post links with unmatched
brackets inside of them (ie. ones that contain single brackets, or
a closing bracket and then an opening one). Allow for escaping opening
and closing brackets using the backslash character.
The change substitutes this old fragment of the regex in the display
text group:
[^\[\]]* // any character other than closing/opening bracket
for this one:
(((?<=\\)[\[\]])|[^\[\]])*
The second pattern in the alternative remains the same; the first one
performs the escaping, as follows:
(
(?<=\\) // positive lookbehind expression:
// this match will succeed, if the next expression
// is preceded by a single backslash
[\[\]] // either an opening or closing brace
)
Since the entire display group is matched, unfortunately the lookbehind
expression does not actually strip the backslashes, so they are
manually stripped in handleMatches.
As demonstrated in the unit tests attached, this also allows balanced
brackets to be mixed with escaped ones.
2019-09-03 23:18:39 +02:00
f8c1afa539
Fix two more cases of judgements appearing on hit error display when they shouldn't
2019-09-03 20:17:39 +09:00
8d52d282e9
Merge pull request #5928 from bdach/consistent-mod-button-sounds
...
Fix inconsistent sound effects on mod buttons
Co-authored-by: Dean Herbert <pe@ppy.sh >
2019-09-03 19:42:21 +09:00
4b2cb8854e
Fix storyboard samples not stopping on exit
2019-09-03 19:28:10 +09:00
e98059267d
Improve xmldoc
2019-09-03 19:21:24 +09:00
299d528654
Simplify implementation
2019-09-03 19:20:23 +09:00
e88965b433
Merge remote-tracking branch 'upstream/master' into consistent-mod-button-sounds
2019-09-03 19:18:59 +09:00
609adf4b59
Fix catch catcher lookups ( #5964 )
...
Fix catch catcher lookups
Co-authored-by: null <27856297+dependabot-preview[bot]@users.noreply.github.com>
2019-09-03 19:08:49 +09:00
343af28ed5
Add extra legacy skin parsing tests
2019-09-03 18:59:23 +09:00
f58ca82398
Don't include section for now
2019-09-03 18:56:01 +09:00
312e12e3b4
Add spacing to difficulty icons on direct panels ( #5957 )
...
Add spacing to difficulty icons on direct panels
2019-09-03 18:44:58 +09:00
858828d4ef
Merge remote-tracking branch 'upstream/dependabot/nuget/ppy.osu.Game.Resources-2019.903.1' into fix-catch-catcher
2019-09-03 18:31:19 +09:00
002de80c30
Add xmldoc to ISkin
2019-09-03 18:30:22 +09:00
2f74ef5131
Add test for changing of a source
2019-09-03 18:22:51 +09:00
352fd3efda
Bump ppy.osu.Game.Resources from 2019.903.0 to 2019.903.1
...
Bumps [ppy.osu.Game.Resources](https://github.com/ppy/osu-resources ) from 2019.903.0 to 2019.903.1.
- [Release notes](https://github.com/ppy/osu-resources/releases )
- [Commits](https://github.com/ppy/osu-resources/compare/2019.903.0...2019.903.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-09-03 09:18:24 +00:00
097012dc95
Move slider ball colouring to DefaultLegacySkin for now
2019-09-03 18:05:16 +09:00
bebc3309ce
Refactor skin configuration to be infinitely extensible
2019-09-03 17:57:34 +09:00
976f5020c0
Fix ring glow lookup being incorrect ( #5963 )
...
Fix ring glow lookup being incorrect
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me >
2019-09-03 16:31:12 +09:00
3854bc68e0
Merge branch 'master' into fix-ring-glow-lookup
2019-09-03 16:14:07 +09:00
953ea83cb6
Merge pull request #5956 from Joehuu/center-icon-and-text-correctly
...
Center icon and text using anchor and origin instead of margin
2019-09-03 15:30:12 +09:00
b7f1efbf38
Merge branch 'master' into center-icon-and-text-correctly
2019-09-03 14:51:59 +09:00
d1cdf49dd5
Revert SkinnableSprite lookups to old behaviour
2019-09-03 14:21:54 +09:00
10862f40c6
Don't display hit errors for non-timed hitobjects ( #5952 )
...
Don't display hit errors for non-timed hitobjects
Co-authored-by: Dean Herbert <pe@ppy.sh >
2019-09-03 13:29:35 +09:00
05ed9d3802
Merge remote-tracking branch 'upstream/master' into non-timeoffset-judgements
2019-09-03 13:07:58 +09:00
4cad55cee6
Move hit windows lookup to DrawableRuleset
2019-09-03 13:05:03 +09:00
4f3511e8e9
Fix ring glow lookup being incorrect
2019-09-03 12:32:10 +09:00
93c3e5a072
Merge pull request #5893 from peppy/play-to-gameplay
...
Rename "play" resources to "gameplay"
2019-09-03 12:26:42 +09:00
de2d3121f7
Merge remote-tracking branch 'upstream/dependabot/nuget/ppy.osu.Game.Resources-2019.903.0' into play-to-gameplay
2019-09-03 12:06:10 +09:00
11dfdc33d5
Bump ppy.osu.Game.Resources from 2019.830.0 to 2019.903.0
...
Bumps [ppy.osu.Game.Resources](https://github.com/ppy/osu-resources ) from 2019.830.0 to 2019.903.0.
- [Release notes](https://github.com/ppy/osu-resources/releases )
- [Commits](https://github.com/ppy/osu-resources/compare/2019.830.0...2019.903.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-09-03 03:05:45 +00:00
444419b2e6
Update resources
2019-09-03 12:04:49 +09:00
4a8bdbd014
Merge remote-tracking branch 'upstream/master' into play-to-gameplay
2019-09-03 12:04:46 +09:00
6a3f210766
Merge pull request #5961 from jorolf/background-beat
...
Add a 60bpm beat when no beatmap is playing
2019-09-03 11:49:19 +09:00
0261456d5a
Merge branch 'master' into play-to-gameplay
2019-09-03 11:42:15 +09:00
eab06995d0
Add some whitespace
2019-09-03 11:37:56 +09:00
ec8726e163
Merge remote-tracking branch 'origin/master' into background-beat
2019-09-03 11:35:20 +09:00
97b824d7d2
Merge pull request #5892 from peppy/iskincomponent
...
Introduce the concept of SkinComponents
2019-09-03 11:31:36 +09:00
3b769128a8
Add a 60bpm beat when no beatmap is playing
2019-09-03 00:57:29 +02:00
de6dba9716
Use float type for chat overlay height
2019-09-03 01:50:52 +03:00
cb55159b28
Use float types for cursor sizes
2019-09-03 01:28:51 +03:00
3d1f051437
Move hover tests after key tests
2019-09-02 11:13:34 -07:00
ce446826e8
Match web's max diff icon number
2019-09-02 11:00:12 -07:00
5d3f3b7cc2
Add spacing to diff icons on direct panels
2019-09-02 10:59:43 -07:00
6ca17bdfd5
Center icon and text using anchor and origin instead of margin
2019-09-02 10:42:21 -07:00
53c254c6a5
Replace Array.IndexOf() with Contains()
2019-09-02 19:01:36 +02:00
09097f7680
Merge branch 'master' into iskincomponent
2019-09-02 22:38:57 +09:00
3443a9517f
Merge pull request #5953 from peppy/fix-direct-panel-unbind-nullref
...
Fix potential null reference on DirectPanel unbind
2019-09-02 21:35:17 +09:00
d688aee258
Add other sample functions to SkinnableSound ( #5728 )
...
Add other sample functions to SkinnableSound
Co-authored-by: Dean Herbert <pe@ppy.sh >
2019-09-02 19:14:45 +09:00
0ee0184e01
Remove unnecessary usings
2019-09-02 19:13:06 +09:00
