Commit Graph

318 Commits

Author SHA1 Message Date
1aa0e40f2f Add "Component" prefix to lookup naming 2022-11-09 17:46:43 +09:00
c908969d9b Rename ISkinComponent to ISkinLookup 2022-11-09 17:46:43 +09:00
92ab39f5c2 Fix hold note disappear instantly 2022-10-25 19:16:23 +09:00
f060e6a780 Implement hold "sliding" samples in osu!mania 2022-10-11 16:31:37 +09:00
52ad766f86 Remove manual binding of nested objects in DrawableManiaHitObject
This is now handled by `Column` itself. Leaving the logic here as well
will cause a circular bindable flow and stack overflow.
2022-10-07 18:25:55 +09:00
ea4dbc8c0f Fix mania hold note head disappears 2022-10-06 19:46:10 +09:00
15d159a97e Fix tests 2022-10-04 16:10:18 +09:00
2aa4d21c75 Remove code that is not needed anymore 2022-10-04 15:17:14 +09:00
0cffbb7562 Clamp LifetimeStart of HitObject's to their judgement windows 2022-09-27 16:54:24 +02:00
a52fa8eb8b Rename const 2022-08-09 13:20:20 +09:00
1f4b87d233 Adjust visuals of osu!mania barlines to be less present
Roughly matches the new design. Metrics adjusted to fit with the existing design.

Closes #19611 maybe?
2022-08-08 17:39:14 +09:00
1051009827 Change bindable properties in all HitObjects to be lazily initialised 2022-07-19 05:39:10 +03:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
5c7623e68e Merge pull request #15255 from goodtrailer/node-samples-ilist
Change IHasRepeats.NodeSamples to IList from List
2021-10-28 14:24:26 +09:00
6944151486 Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
4440b9ca11 Change IHasRepeats.NodeSamples to IList from List 2021-10-23 01:59:07 -07:00
a92d499d7a Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo 2021-10-01 16:55:50 +09:00
f9d5abff8a Update with keybinding changes 2021-09-16 18:26:12 +09:00
922fa96d41 Fix notes not updating snap colour on application 2021-09-12 18:18:55 +02:00
6aa894e55e Split out separate component 2021-08-25 16:56:44 +09:00
6252b8aa42 Fix hold notes handling all input ever 2021-08-24 19:08:04 +09:00
05234d6c30 Fix mania hitobjects not appearing early enough 2021-07-16 19:33:34 +09:00
a4f362dca6 Remove lifetime override of DrawableManiaHitObject
The `AlwaysAlive` logic is now in all DHOs and it is now not necessary (and potentially conflicting).
2021-06-17 10:15:24 +09:00
f992b59b4f Fix DrawableHoldNote retaining hit states through applications 2021-05-12 17:07:42 +09:00
1af3bbf400 Fix base.OnLoadComplete() not being called 2021-05-12 17:06:44 +09:00
4e7551d50e Fix crashes 2021-05-12 16:40:46 +09:00
5692cecaa4 Initial implementation of DHO pooling 2021-05-12 16:35:05 +09:00
713c169332 Fix mania crashing on playing samples after skin change 2021-05-11 16:21:21 +09:00
db815f7930 Tidy up implementation in DrawableNote 2021-05-01 20:39:10 +09:00
fdf8c12947 Replace BeatDivisorFinder with GetClosestBeatDivisor 2021-05-01 11:57:47 +08:00
ecb053b0de Merge branch 'master' of https://github.com/ppy/osu into justusft/mania-color-snap 2021-05-01 11:20:28 +08:00
c4d28110d6 Add visual tests for timing based note coloring 2021-04-27 19:02:57 +08:00
a3570e18dd Add concurrent objects check
Here we use `IHasColumn` to support rulesets with columns, and so I moved that interface out into `osu.Game` from `osu.Game.Rulesets.Mania`.

We also use the same threshold as the unsnap check to ensure that no problems slip through. Specifically where an object is simultaneously not concurrent and not unsnapped but still on the same tick.
2021-04-26 20:17:18 +02:00
559d403abe Rename ColourCodedNotes to TimingBasedNoteColouring 2021-04-26 19:05:12 +08:00
58ebec4803 Move BindValueChanged hooks to LoadComplete() 2021-04-26 19:00:40 +08:00
e14255f395 Rename {Snap -> BeatDivisor}Finder 2021-04-25 17:44:26 +02:00
afb67726f0 Reduce casting 2021-04-25 17:41:23 +02:00
f9e228d6bf Use null-permitting BDL to reduce number of fields 2021-04-25 17:40:23 +02:00
211bff6a8f Fix cake errors 2021-04-25 09:21:25 +08:00
8b9d2a6cff Remove caching for ConfigColourCodedNotes 2021-04-25 08:32:49 +08:00
d3db19c3ce Simplify DrawableNote 2021-04-25 08:11:44 +08:00
e0ca44c908 Move SnapFinder from mania ruleset to osu.Game 2021-04-25 07:35:53 +08:00
bedabc1ddf Fix cake errors 2021-04-24 22:12:07 +08:00
8b01082cbb Fix visual tests missing dependency for ColourCodedNotes 2021-04-24 21:28:48 +08:00
3103fd8343 Move snapping logic into SnapFinder 2021-04-24 21:28:35 +08:00
a8b401522b Remove ManiaColourCode in favor for boolean 2021-04-24 20:39:22 +08:00
d6d81fb8e5 Move color snap logic from Note to DrawableNote 2021-04-24 19:53:21 +08:00
f9905ebe68 Remove beatmap argument in Note 2021-04-24 19:37:10 +08:00
7e3a611f95 Add snap color option for osu!mania 2021-04-24 16:23:52 +08:00
4148d473e3 Fix hold note crashing with 0 length 2021-04-22 19:51:33 +09:00