fa710ae1b0
Rename ScrollToTopButton to ScrollBackButton
2023-02-26 14:39:34 -08:00
d98d330da2
Add expected behavior test for scroll back to previous position
2023-02-26 14:30:46 -08:00
dd9748a25c
Adjust DrawNodes to use UBOs
2023-02-25 01:42:55 +09:00
6307b3948a
style: use Trigger initialisation
2023-02-22 17:59:39 +00:00
d679703fa2
Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection
...
Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play
2023-02-22 18:56:59 +01:00
1beec71037
refactor(KeyCounterDisplay): apply suggestions
...
I also took the freedom to add type checking, as we can't limit the
usage of `Add()` since it's a Container. The exception thrown also
advises of using the suggested `AddTrigger()` instead.
2023-02-22 14:58:27 +00:00
a8c692a215
Merge pull request #22635 from peppy/use-overlays-container-more
...
Use `Overlays` container rather than `KeyBindingInputManager` for flashlight
2023-02-22 18:30:21 +09:00
32a9c066df
Add test coverage of bring-to-front / send-to-back operations
2023-02-22 18:17:20 +09:00
90ca635a17
Fix weird nullability in TestSceneSkinEditor
2023-02-22 18:17:20 +09:00
f61fbcf3fc
Update assertion to also check GameplayClockContainer's current time
2023-02-22 15:26:09 +09:00
a511e64fa5
Seek using GameplayClockContainer
2023-02-22 14:41:20 +09:00
d59d153654
Fix test compile failures from Audio hoisting
2023-02-21 21:03:00 +01:00
3d2fcb0cca
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-21 20:53:06 +01:00
ec1bf7b0b2
Merge branch 'master' into skin-editor-clipboard
2023-02-21 19:35:58 +01:00
1fa6864500
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-02-21 18:47:59 +03:00
90aa4288d0
Reduce the allowed length by 5 to account for (99) suffix. Move truncating logic to GetFilename. Update tests.
2023-02-21 18:35:53 +03:00
9321ec29dc
Update slider sample source asserts to match expected behaviour
...
As pointed out in review, if the current time is after the end of the
slider, the correct hit object to use for sample retrieval is the object
itself, not any nested object.
2023-02-21 14:04:38 +09:00
e686b4393e
Add wait steps to ensure frame-stable clock has caught up before checking state
2023-02-21 14:04:19 +09:00
5ba6059911
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-21 13:58:15 +09:00
c9999bdeb1
Merge branch 'master' into skin-per-ruleset-layouts
2023-02-20 20:14:38 +01:00
3183f5cee2
Merge branch 'master' into revert-result-in-playfield
2023-02-19 16:33:10 +01:00
5fa75805cc
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-02-18 15:52:17 +03:00
704dddf14b
Merge branch 'master' into skin-editor-clipboard
2023-02-17 22:59:18 +01:00
6b9472c367
Merge branch 'master' into skin-per-ruleset-layouts
2023-02-17 22:58:38 +01:00
6afa65bd3d
Merge branch 'master' into skinnable-clean-up-documentation
2023-02-17 20:59:18 +01:00
9793774377
Update SkinDeserialisationTest to work with new serialisation structure
2023-02-17 16:22:48 +09:00
6b3652f567
Change serialisation format of skin layouts to allow more flexibility
...
Also adds per-ruleset storage for each container type.
2023-02-17 14:19:19 +09:00
372b6b794c
I don't know what .ots is but let's not use random file extension that make no sense
2023-02-17 13:46:27 +09:00
8ef3fb26e0
More constants and assert fixes
2023-02-17 13:46:27 +09:00
86d110e893
Simplify test storage by removing nested storage
2023-02-17 13:43:42 +09:00
4560ae6b02
Mark test as fixture
2023-02-17 13:39:31 +09:00
99236f0ae8
Move long filename to fixture level
2023-02-17 13:39:24 +09:00
96b1498932
Rename max length variable to make sense (it's a filename limit, not path)
2023-02-17 13:33:22 +09:00
415220a447
Tidy up new test method code quality
2023-02-17 13:30:00 +09:00
810712386d
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-02-17 01:51:24 +03:00
f4038a49a1
Fix inspectCode issues
2023-02-17 01:50:24 +03:00
1d8b348e4c
Improve naming
2023-02-17 01:46:15 +03:00
6cb00cd42f
Add more test cases
2023-02-17 01:44:45 +03:00
ddd6c1a1c6
refactor(KeyCounter): address bindables issues
...
`IsCounting` is back being an auto-property.
`countPresses` is now encapsulated and being exposed as an
`IBindable<int>` via `CountPresses`
2023-02-16 22:20:34 +00:00
3ee046000e
Merge branch 'master' into revert-result-in-playfield
2023-02-16 21:54:29 +01:00
2fdf1fd876
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-16 19:43:02 +01:00
5bdc5dfadd
Add one more assert to keep coverage from previous implementation
2023-02-16 19:02:51 +01:00
6819a45a1b
Improve code slightly
2023-02-16 16:42:07 +03:00
f1da213bea
Add tests
2023-02-16 16:26:57 +03:00
b59ec551f6
Add test coverage of GameplaySampleTriggerSource not considering nested objects
2023-02-16 18:21:33 +09:00
979c079f8b
Refactor GameplaySampleTriggerSource test to not be realtime dependent
2023-02-16 17:58:44 +09:00
9d02a2ef0e
Apply NRT to GamepleSampleTriggerSource tests
2023-02-16 17:58:44 +09:00
2fbaf88a3c
Add clipboard dependency to SkinEditor specific tests
...
This is usually provided by the `SkinEditorOverlay`, which is not always
present in tests.
2023-02-16 15:24:38 +09:00
74e7cc2056
feat: implement new design of key counter
2023-02-15 22:18:02 +00:00
076eb81b21
refactor: rename trigger classes
...
Makes it better to understand their purpose
2023-02-15 21:46:13 +00:00
