bfd3d0cce9
Implement custom enumerator for ReverseQueue to avoid allocations
2021-04-10 01:16:54 +10:00
37e30b00bf
Refactor to keep a consistent API
2021-04-06 16:39:02 +09:00
5cd43b3a7f
Set default history retention to 0 for Skill and override in StrainSkill
...
Some skills might not even require history retention, so why waste the allocations?
2021-04-06 11:53:31 +10:00
4f614a703e
Merge branch 'master' into diffcalc/dynamic-history
2021-04-06 11:34:33 +10:00
65f93d6f9d
Add more descriptive xmldoc for ReverseQueue
2021-04-06 11:30:58 +10:00
ffe7edc16a
Update xmldocs
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me >
2021-04-06 11:06:10 +10:00
9d8a26f373
Merge branch 'master' into diffcalc/refactor-strain-skill
2021-04-06 08:21:38 +09:00
5bdd15f746
Refactor Skill.Process() to not require calling base.Process()
2021-04-05 22:14:59 +10:00
57983ae61f
Fix whitespace
2021-04-05 22:14:59 +10:00
6bcbef9f25
Merge pull request #12294 from smoogipoo/mania-scoring-adjustments
...
Adjust scoring values to better fit osu!mania expectations
2021-04-05 17:19:28 +09:00
97820e0ea5
Merge branch 'master' into diffcalc/refactor-strain-skill
2021-04-05 15:09:52 +09:00
5bf0889379
Merge branch 'master' into diffcalc/refactor-strain-logic
2021-04-05 14:16:34 +09:00
3acc612a67
Adjust scoring values to better fit osu!mania
2021-04-05 13:28:46 +09:00
d4724f4494
Fix crash
2021-04-04 09:44:45 +08:00
4df7ff21c7
Fix editor arrow seek snapping not updating after control point changes
...
The editor clock, which is responsible for performing the seek, was not
aware of changes in control points due to reading from the wrong
beatmap. `loadableBeatmap` is not actually changed by any of the editor
components; `playableBeatmap` and `editorBeatmap` are.
For now this is changed to use `playableBeatmap`. A better follow-up
would be to use `editorBeatmap`, but it would probably be best to move
the beat snap bindable into `EditorBeatmap` first.
2021-04-03 14:02:46 +02:00
85d2b1232a
Refactor to abstract out strain logic into StrainSkill class
...
While it is the case for the existing official Skills, Skill implementations shouldn't be required to conform to a strain based approach.
There are other valid approaches to calculating skill difficulty that can be supported by abstracting the strain logic into its own StrainSkill class.
2021-04-03 20:52:39 +11:00
5b2dcea8a8
Refactor to encapsulate strain logic into Skill class
...
As strains are an implementation detail of the current Skill calculations, it makes sense that strain related logic should be encapsulated within the Skill class.
2021-04-03 20:47:43 +11:00
fe66b84bed
Implement dynamic previous hitobject retention for Skill class
...
There is no reason we should be limiting skills to knowing only the previous 2 objects. This originally existed as an angle implementation detail of the original pp+ codebase which made its way here, but didn't get used in the same way.
2021-04-03 20:28:51 +11:00
eb1e850f99
Merge pull request #12254 from smoogipoo/spectator-refactor
...
Move frame-handling spectator logic into abstract base class
2021-04-03 17:23:33 +09:00
dc3163ccf2
Merge pull request #12271 from hbnrmx/filechooser-preselect-folder
...
Open editor file selector in the directory of the previous selection
2021-04-03 14:31:19 +09:00
f0e656fb12
Merge pull request #12276 from PercyDan54/beatmap-info-unicode
...
Make beatmap listing use unicode title & artist name
2021-04-03 14:30:27 +09:00
dde255980b
Fix formatting
2021-04-03 12:45:42 +08:00
bd7da9eb39
Make beatmap title use unicode
2021-04-03 12:43:17 +08:00
0dce4b8894
Update framework
2021-04-03 13:01:08 +09:00
67f0c0ceb9
Merge branch 'master' into spectator-refactor
2021-04-03 12:55:11 +09:00
824fb9f398
reopen FileSelector in the directory of the previous selection
2021-04-02 18:01:26 +02:00
438f3e6349
move fallback text to PlaceholderText
2021-04-02 17:57:21 +02:00
cd53074941
Schedule spectator callbacks
2021-04-02 21:27:20 +09:00
345779b19a
Merge branch 'master' into diffcalc/fix/clockrate-adjusted-decay
2021-04-02 20:58:29 +09:00
d2950105fb
Add comment explaining use of lock
2021-04-02 20:31:34 +09:00
143b8c422c
Merge pull request #12259 from frenzibyte/fix-ruleset-file-loading
...
Guard against same ruleset file with filenames of loaded assembly location instead
2021-04-02 19:21:33 +09:00
45d16fb916
Rename event parameter for clarity
2021-04-02 16:56:47 +09:00
6d4d574a65
Fix exported replay filenames not having full metadata
2021-04-02 14:10:25 +09:00
e1aa927827
Add dropdown option to export score
2021-04-02 13:20:15 +09:00
5b1dc7d2b4
Remove unused using directive
2021-04-02 02:45:26 +03:00
fcd56dba44
Guard against same ruleset file with loaded assembly filenames instead
2021-04-02 02:12:25 +03:00
9bc2a486e0
Make SoloSpectator use the new SpectatorScreen class
2021-04-01 22:10:17 +09:00
9e95441aa6
Rename Spectator -> SoloSpectator
2021-04-01 22:08:52 +09:00
af478fb2eb
Add abstract spectator screen class
2021-04-01 22:02:32 +09:00
f8c1dfe57f
Merge branch 'master' into editor-fix-speed-multiplier-precision
2021-03-31 17:17:25 +09:00
ef1f133fb1
Merge pull request #12238 from peppy/fix-mass-drag-drop-imports
...
Group large drag drop imports into a single operation
2021-03-31 16:15:26 +09:00
30cae46cbd
Group large drag drop imports into a single operation
2021-03-31 14:57:28 +09:00
0c53b4eb93
Fix wrong counting and add test
2021-03-31 14:09:39 +09:00
e0c61f4dc5
Fix retry count not updating correctly
...
Regressed with changes to player reference retention logic. Could add a
test but the logic is so local now it seems quite redundant.
2021-03-31 13:57:58 +09:00
fb0079fb9f
Fix accuracy displaying incorrectly in online contexts
...
Closes #12221 .
2021-03-30 22:42:32 +09:00
633e6130bf
Update framework
2021-03-30 19:46:22 +09:00
de394f3d14
Merge branch 'master' into tablet-rotation-configuration
2021-03-30 19:46:19 +09:00
90c75a64cf
Fix legacy control point precision having an adverse effect on the editor
2021-03-30 15:24:11 +09:00
d2ef0ba644
Merge branch 'master' into add-editor-nudging-support
2021-03-30 14:34:43 +09:00
1dfd08eded
Add tablet rotation configuration
2021-03-30 13:01:48 +09:00
