Commit Graph

550 Commits

Author SHA1 Message Date
aa15e84bea Adjust rounding in mod select difficulty multiplier to match song select footer
The 0.01 `Precision` spec on `DifficultyMultiplierDisplay.Current` would
cause the difficulty multiplier to use a different midpoint rounding
strategy than `double.ToString()`, which is the one that the song select
footer relies on. For example, a value of 0.015 would be rounded down
to 0.01 by `double.ToString()`, but rounded up to 0.02
by `BindableDouble`.

Fix the discrepancy by just deleting the `Precision` spec. Since the
value of the bindable would go through `ToLocalisableString(@"N2")`
anyway, it was redundant as is.

Fixes #19889.
2022-08-21 23:15:49 +02:00
76fea25668 Merge pull request #19646 from its5Q/settings-localisation
Add missing localisation for settings enums
2022-08-10 18:51:52 +09:00
abca3d1b2a Prefix common strings for context 2022-08-10 00:35:19 +10:00
f74fb3491e Use alternative implementation of preset panel cleanup 2022-08-08 21:08:54 +02:00
a0a6e1faee Fix spurious sample playbacks from already-removed panels 2022-08-08 20:30:55 +02:00
f21a51aa24 Simplify mirror copy of task logic in ModColumn 2022-08-08 19:20:50 +02:00
00333fb0d2 Change ?? false test to == true for legibility 2022-08-08 19:19:13 +02:00
5080d62e77 Add missing localisation for settings enums 2022-08-08 21:51:23 +10:00
070d156e89 Simplify task logic in ModPresetColumn 2022-08-08 16:13:52 +09:00
839409d7ac Add preset column to solo mod select overlay 2022-08-07 16:20:31 +02:00
b318bbd5e6 Allow non-homogenous column types in mod select overlay 2022-08-07 16:20:31 +02:00
0287c49ca8 Implement user selection logic for mod presets 2022-08-07 16:20:20 +02:00
b1dcd7821c Automatically toggle preset panels if selected mods match 2022-08-07 15:30:20 +02:00
9b3183b2b4 Implement mod preset deletion flow 2022-08-06 21:58:55 +02:00
ca1b4689cb Automatically focus name textbox upon add preset popover open 2022-08-03 21:26:35 +02:00
159d3b032c Rename locals for legibility 2022-08-03 21:23:31 +02:00
82d3fbd51b Split AddPresetPopover to separate file 2022-08-03 21:22:55 +02:00
add2971eb4 Implement preset creation flow with test coverage 2022-08-02 22:05:54 +02:00
7251389e43 Add localisations for add preset button 2022-08-02 22:05:34 +02:00
059a465fe8 Add border to popover for better visual contrast 2022-08-02 22:03:33 +02:00
1b3074d098 Implement popover for creating mod presets 2022-08-02 22:03:33 +02:00
085080576a Add button for creating new mod presets 2022-08-02 22:03:32 +02:00
85f77abee1 Fix code quality inspection about ambiguous equality 2022-07-31 23:53:46 +02:00
345f103119 Migrate mod preset column to use realm 2022-07-31 23:53:45 +02:00
446485f804 Move localisation string to common location 2022-07-24 23:30:52 +02:00
8af9cfbe40 Add readonly modifier 2022-07-24 23:29:18 +02:00
6a67d76d7c Add basic mod preset column implementation 2022-07-24 16:39:04 +02:00
b2f8934117 Extract base mod select column presentation logic 2022-07-24 16:39:03 +02:00
f3ceabc53f Rename ModSelect{Overlay -> }Panel 2022-07-22 19:17:22 +02:00
a3090003de Add tooltip showing contents of mod preset 2022-07-21 23:29:21 +02:00
bdff7f1ef4 Implement basic appearance of mod preset panels 2022-07-21 23:29:21 +02:00
6cd18fad99 Fix code inspections after base panel class extraction 2022-07-21 23:29:08 +02:00
d796b7d53c Extract base mod select overlay panel presentation logic 2022-07-21 22:37:00 +02:00
89653b74c7 Only add setting tracker when customisation is permitted 2022-07-19 19:21:16 +03:00
eddae7b143 Fix mod overlay and footer not updating multiplayer on settings change 2022-07-18 07:38:56 +03:00
a03abc747b Tidy up comments and simplify bounding box centre logic 2022-07-02 12:58:34 +09:00
9d28d5f8ee Update SFX for mod overlay show/hide 2022-07-01 20:43:12 +09:00
31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
f71f6302fd Remove unnecessary null casts 2022-06-24 14:50:11 +09:00
7013909322 Remove unnecessary protected virtual 2022-06-21 16:43:04 +02:00
f564ed589f Alter sequential hotkey style to always use visible index
Previous behaviour was once mentioned off-hand as unintuitive.
2022-06-21 15:22:18 +02:00
9e5cc89edb Fix classic hotkeys toggling filtered mods 2022-06-21 15:01:33 +02:00
da1814e7c3 Restructure everything to fix free mod overlay issue 2022-06-21 14:48:41 +02:00
7b7b8c1892 Implement behaviour for classic selection style 2022-06-21 14:24:30 +02:00
234120ff43 Forward entire event to IModHotkeyHandler
Required for shift handling in the classic implementation.
2022-06-21 13:37:17 +02:00
658f5341c7 Set up flow for switching between hotkey styles 2022-06-21 13:34:58 +02:00
5abd8a07d2 Add setting for changing mod select hotkey style 2022-06-21 13:33:17 +02:00
73124d2b1f Encapsulate mod hotkey selection logic in strategy pattern 2022-06-21 12:49:01 +02:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
a1b8fa0992 Disable "select all mods" button if all are selected 2022-05-25 23:06:12 +02:00