4f4f60248f
Add failing test case
2022-01-30 01:46:10 +03:00
b434e29a7c
Move loading hide operation inside early return to ensure not hidden too early
...
It should only be hidden after the async load completes.
2022-01-30 03:10:15 +09:00
dad9cc9315
Ensure Reset/Scores_Set run inline where possible
2022-01-30 03:06:29 +09:00
06660ff960
Fix null beatmap in test scene
2022-01-30 03:02:56 +09:00
9b573fbc2b
Add missing entries to switch statement and guard against out of range
2022-01-30 02:58:53 +09:00
d21464ea61
Fix assertions to work in both directions
2022-01-30 02:54:51 +09:00
d3cb910cf8
Convert inline math to not so inline to make operation more explicit
2022-01-30 02:37:01 +09:00
3d771c0fc7
Remove unnecessary loading hide call from PlaceholderState_Set and add more assertiveness
2022-01-30 02:34:31 +09:00
51acf79935
Change test exposure to property instead of method
2022-01-30 02:29:51 +09:00
40f43344f1
remove unused using
2022-01-29 23:31:26 +08:00
535216a0d3
rename CanIntercept to ShouldAlternate
2022-01-29 23:20:31 +08:00
e408d8ef0e
rename Frames to ReplayFrames
2022-01-29 23:19:51 +08:00
9861c50b33
Remove pointless tests that no longer show anything valid
2022-01-30 00:03:22 +09:00
a915b9cd30
Fix occasional failures in TestSceneDeleteLocalScore
2022-01-29 23:58:57 +09:00
6f54f8ad78
Add more safety around CancellationToken usage
2022-01-29 23:58:57 +09:00
d0b74a91fb
Fix edge cases with score drawable loading
2022-01-29 23:58:57 +09:00
0293d95f82
Simplify IsOnlineScope usage
2022-01-29 23:58:57 +09:00
daea13f491
Simplify flow of cancellation token
2022-01-29 23:58:57 +09:00
3d59bab7c6
Remove fetch callback logic completely
2022-01-29 23:58:57 +09:00
13f445ddd5
Move score update code into own method
2022-01-29 23:58:57 +09:00
c48e9f2bbd
Remove more unnecessary schedule/cancel logic
2022-01-29 23:58:57 +09:00
a700ad3849
Remove scoresLoadedOnce weirdness
2022-01-29 23:58:57 +09:00
661fec7c8a
Make score setter private
2022-01-29 23:58:57 +09:00
b85b2c01fb
Reorder based on accessibility and add regions
2022-01-29 23:58:57 +09:00
c548658662
Remove move unused pieces
2022-01-29 23:58:57 +09:00
17aa9f3040
Remove pointless level of schedule/cancel logic
2022-01-29 23:58:57 +09:00
64925b3fea
Remove unused Content override
2022-01-29 23:58:57 +09:00
b9dac6c3b2
Reorder and tidy up bindable flows
2022-01-29 23:58:57 +09:00
aee93934d5
Rename methods to make more sense (and always run through AddOnce)
2022-01-29 23:58:57 +09:00
c6d303a5b4
Add xmldoc to Leaderboard class
2022-01-29 23:58:57 +09:00
a8eb3f95df
add readonly modifier
2022-01-29 22:54:17 +08:00
4132f67629
Merge pull request #16702 from peppy/fix-ef-migrations
...
Run EF migrations before migrating to realm
2022-01-29 15:40:26 +01:00
1087d8b1ce
add tests
2022-01-29 22:31:31 +08:00
b4e516c535
allow test scenes to specify replays manually
2022-01-29 22:31:24 +08:00
24f9ef4005
make xmldoc more verbose
2022-01-29 22:31:04 +08:00
1a14ccc7ee
Run EF migrations before migrating to realm
...
Turns out that there are more than zero users that are upgrading from
old databases. I think we probably want to support this for now.
Tested against database in https://github.com/ppy/osu/discussions/16700
and one other I had locally, both work correctly.
2022-01-29 23:13:23 +09:00
d48fae1100
Revert "Remove all EF migrations"
...
This reverts commit bb5b9458e8
2022-01-29 23:13:23 +09:00
98d8b26a9c
move ModAlternate to OsuModAlternate and check if intro has ended
2022-01-29 21:49:40 +08:00
2326c36836
remove unused method and fix description
2022-01-29 21:09:36 +08:00
aa582fb0e1
add Alternate Mod
2022-01-29 20:38:12 +08:00
0fc29c0e08
Merge pull request #16697 from peppy/fix-score-import-wrong-ruleset
...
Fix `SongSelect` incorrectly exposing decoupled ruleset to child screens
2022-01-29 13:31:35 +01:00
e7823982d8
Fix ruleset value not being transferred when FinaliseSelection is not called
2022-01-29 18:44:48 +09:00
4c97ed676f
Fix score presentation tests not correctly entering song select before running
2022-01-29 14:46:24 +09:00
c7580a5177
Fix inspections in test scene
2022-01-29 14:06:43 +09:00
035a84e75c
Rename function and make public again for test usage
2022-01-29 14:05:23 +09:00
c75ffe9b07
Apply code style changes
2022-01-29 13:47:04 +09:00
b2ebcabdd5
Fix potential crash during stable install migration due to multiple configuration files
...
Apparently this can be a thing on windows.
Closes https://github.com/ppy/osu/discussions/16689 .
2022-01-29 13:30:07 +09:00
a4aa501bb5
Change threshold from ms to beat-based, add tests
2022-01-28 21:59:53 +00:00
1253e1ecc1
Replace LINQ Count() invocation with count property access
2022-01-28 20:25:12 +01:00
3037a3a769
Purge final spectator frames before ending play
2022-01-28 22:26:05 +09:00
