Commit Graph

517 Commits

Author SHA1 Message Date
c271d17557 Remove useless field 2020-03-14 14:07:52 +03:00
74c9d5fc93 Use AccentColour 2020-03-14 13:45:55 +03:00
7e9d28b1b1 Fix slider ball colour affects follow circle 2020-03-13 13:42:33 +03:00
ed837d3115 Use framework extension method for FromHex 2020-03-11 10:18:41 +09:00
77fd748035 Fix incorrect circle piece hitbox
Hitboxes of circle pieces in osu! have regressed with commit 8592335.
The reason for the regression was that hit detection was moved from
DrawableHitCircle itself to a newly-introduced private HitArea class
(now named HitReceptor).

As HitArea inherited from Drawable, it would return IsHovered == true
over its entire bounding box. This meant that the hit area could wrongly
pick up actions that are not within circle radius and make them into
hits.

To resolve, make HitReceptor a CompositeDrawable and set its corner
radius to match the circle piece. This fixes the invalid hitbox, as
IsHovered takes radius into account.
2020-03-06 21:21:20 +01:00
5e218697c5 Use stacked positions 2020-03-04 09:46:53 +09:00
e6cfafffe9 Fix incorrect LifetimeStart and add todo regarding Expire usage 2020-02-24 12:24:15 +09:00
090d9d9350 Make FollowPointRenderer a LifetimeManagementContainer 2020-02-23 04:37:04 +09:00
cb9a7ee0bb Give FollowPointConnections a valid lifetime 2020-02-23 04:36:50 +09:00
00b4fc1e1f Add fill to default skin slider ball when tracking 2020-02-21 17:38:23 +09:00
84fcf45aae Make slider tracking match what is on screen 2020-02-03 11:55:14 +09:00
cf4788d7ef Merge branch 'master' into fix-follow-circle 2020-02-03 09:58:12 +09:00
35032e2ddd Make variables private 2020-02-02 14:34:06 +01:00
f7abfdb40e Remove unnecessary parameter 2020-02-02 14:33:48 +01:00
e2589b2dcb Rename drawable 2020-02-02 11:24:28 +01:00
434c0d92e4 Use Bindable{Float,Double}s everywhere
To avoid further floating-point comparison bugs, remove all usages of
Bindable<{float,double}>, replacing them with their
Bindable<Float,Double> counterparts.
2020-02-01 22:50:29 +01:00
9f4261111b Match osu-stable behaviour and size 2020-02-01 16:55:30 +01:00
7b2f58eb30 Apply OnRelease method signature refactorings 2020-01-22 13:22:34 +09:00
92daf9b8f1 Cleanup 2020-01-14 18:14:31 +09:00
fe09e34f1b Remove limiting clause 2020-01-14 01:48:20 +09:00
ab4f31639d Remove weird time clause 2020-01-14 01:47:44 +09:00
210d06b75e Remove default value 2020-01-14 01:45:32 +09:00
c5085aea24 Use Child, not InternalChild 2020-01-14 01:45:10 +09:00
619fe29871 Make reverse arrow animate faster via divisor specification
Adds MinimumBeatLength to BeatSyncedContainer to make sure things don't get out of hand.
2020-01-14 01:39:45 +09:00
45cf65a28a Merge remote-tracking branch 'upstream/master' into reverse-arrows 2020-01-13 14:15:37 +01:00
87645f6a41 Remove excess namespace specification 2020-01-10 01:13:42 +08:00
3be2fc27f3 Merge branch 'master' into Remove_osuTK.MathHelper 2020-01-10 00:28:46 +08:00
91735ff367 Update MathUtils namespace usages 2020-01-09 13:43:44 +09:00
ed2bf5154d Use tuple deconstruction to swap values 2020-01-08 20:46:17 +01:00
34d8740ec4 Remove remaining usage of osuTK.MathHelper 2020-01-08 20:21:13 +01:00
21468eb070 Remove settings related to reverse arrow 2020-01-07 04:55:05 +01:00
3194658998 Fix repeat point pulsing when it is in fade out state 2020-01-04 13:12:37 +01:00
46271ccbc8 Add slider reverse arrow pulse settings 2020-01-04 13:01:42 +01:00
fc0b622a69 Change reverse arrow pulse easing to OutQuad 2020-01-04 10:35:10 +01:00
9da7eec0d9 Add pulse to slider reverse arrows 2020-01-04 08:21:48 +01:00
f150d22eaf Fix SPM calculation logic not handling paused clocks (#7253)
Fix SPM calculation logic not handling paused clocks

Co-authored-by: Dean Herbert <pe@ppy.sh>
2019-12-18 16:30:18 +09:00
1fe0e45a9c Implement legacy slider border shadow 2019-12-18 13:37:37 +09:00
cbfbbf9999 Make SpmCounter public 2019-12-18 03:04:37 +03:00
7e58b4a948 Early-return on potential division by zero in SPM calculation 2019-12-18 03:03:12 +03:00
35276c3739 Prevent test scene failures through casting softly 2019-12-17 21:26:23 +09:00
7c2884700e Fix various display issues by abstracting further 2019-12-17 19:29:27 +09:00
9caed9e98a Add legacy slider body support 2019-12-17 18:16:25 +09:00
1e798a8dbe Add abstract implementation of slider path 2019-12-17 17:54:05 +09:00
4905709ea4 Remove unused usings 2019-12-09 13:19:21 +09:00
3ebbf62b2a Initial game-wide update with the new SliderPath 2019-12-05 19:53:36 +09:00
c0fe91a84c Merge branch 'master' into sharpen 2019-11-26 18:21:50 +08:00
709ec1404f Centralise End/StartTime retrieval to extension method 2019-11-25 19:09:14 +09:00
fccdbffa93 Use MathF instead of Math- functions when possible
MathF-functions are faster than the Math-counterpart and it looks cleaner, so use MathF when we cast to float or int anyway.
2019-11-25 00:45:42 +01:00
c2e85a2057 Apply CornerExponent fixes 2019-11-22 19:49:20 +09:00
818553027b Merge branch 'master' into sharpen 2019-11-21 23:42:46 +08:00