Commit Graph

33577 Commits

Author SHA1 Message Date
c27e5d1216 Fix editor still playing back sound when exiting with confirmation 2022-06-15 18:44:02 +09:00
be2b4e68b9 Don't play player exit sound when restarting 2022-06-15 17:49:18 +09:00
713cff3403 Don't play editor exit sound when changing difficulties 2022-06-15 17:49:09 +09:00
fd4529aa7c Play editor exit sound if no confirmation buttons were shown during exit process 2022-06-15 17:37:54 +09:00
7ac5019c08 Fix intro screens playing exit sounds 2022-06-15 17:37:30 +09:00
6136e4e27a Don't play exit sound if screen is in a non-resumable state when exiting 2022-06-15 17:37:25 +09:00
b3aa4fcf02 Adjust a channel rather than the overall sample 2022-06-15 17:33:07 +09:00
94aa2248ca Move filter reset to more appropriate location 2022-06-15 17:32:21 +09:00
1f1633ddc2 Remove Update method processing of samples in PopupDialogDangerousButton 2022-06-15 16:50:23 +09:00
eac0ca4db6 Update resources 2022-06-15 16:14:46 +09:00
5e3ccf7087 Don't play 'back' sample when exiting Editor 2022-06-15 15:41:28 +09:00
6b744a14b0 Move 'back' sample playback from OnResuming to OnExiting 2022-06-15 15:41:28 +09:00
af87722be8 Add audio feedback for 'Dangerous' dialog buttons 2022-06-15 15:41:27 +09:00
930ec2a197 Add specific samples for dialog 'Ok' and 'Cancel' buttons 2022-06-15 15:41:27 +09:00
d3feb07bc1 Split zoom updating to named method with value as optional 2022-06-15 07:57:16 +03:00
268a7e1334 Fix ZoomableScrollContainer attempting to update zoom with overlapping range 2022-06-15 05:43:41 +03:00
36599d1174 Merge branch 'master' into fix-hit-error-when-not-visible 2022-06-14 22:47:11 +03:00
49ec2572b8 Allow scrolling overflow of ruleset buttons in the toolbar 2022-06-15 01:43:10 +09:00
d89c11e49e Allow Toolbar to block scroll input from passing through 2022-06-14 19:10:13 +03:00
6be4209458 Fix AlwaysPresent specification in wrong container 2022-06-15 01:04:43 +09:00
cf2238f683 Merge pull request #18688 from peppy/too-many-import-methods
Various clean-up on model managers / importer classes
2022-06-15 00:12:33 +09:00
cc7943dfb1 Merge pull request #18687 from peppy/editor-repeat-behaviour-change-collapsing
Fix timing adjustment repeat buttons firing one change per repeat invocation
2022-06-14 20:24:13 +09:00
94ba71aa13 Remove one more usage of lowPriority 2022-06-14 20:21:28 +09:00
6250caca29 Remove duplicate implementation of same thing 2022-06-14 20:01:11 +09:00
e96c5ce703 Move and correct xmldoc to interfaces 2022-06-14 20:00:16 +09:00
84e526a2d9 Move methods around to make more sense 2022-06-14 20:00:08 +09:00
9f599a5ab4 Remove unused lowPriority flag from one Import method 2022-06-14 19:52:30 +09:00
ca0765a932 Tidy up various delegation implementations 2022-06-14 19:46:59 +09:00
d73c0ca659 Remove unused methods from IModelImporter
All the xmldoc is already present in `RealmArchiveModelImporter` so
nothing is lost here.
2022-06-14 19:42:11 +09:00
c30644328c Fix timing adjustment repeat buttons firing one change per repeat invocation 2022-06-14 19:21:02 +09:00
aeca138930 Fix ctrl-z in editor also seeking to start in addition to undo 2022-06-14 18:48:57 +09:00
a20e43c2ae Ensure containers which are being used to hide HUD elements still update for now
I don't think this is necessarily a final solution (as this means all
HUD elements are adding overhead even when not visible), but this will
make the implementations much easier for the time being.

I've checked and can't notice any perceivable overhead in profiling so
we should be fine for now.
2022-06-14 18:22:25 +09:00
bd9ea9bd6f Revert most unnecessary changes
Turns out `AlwaysPresent` at top level is actually enough.

This reverts commit 86163d2225.
2022-06-13 23:58:14 +09:00
336df62a1f Remove unnecessary file existence check
This is not required due to `createFileInfos` always being run before we
get to this point (I believe this was added after the initial code to
check existence was added).

This flow is covered in
`BeatmapImportTests.TestImportThenReimportAfterMissingFiles`, which
still passes with the change.

While this check isn't doing any harm, as I'm going through the flow for
import-skipping, less checks are appreciated.
2022-06-13 18:57:30 +09:00
b88461b3c9 Merge pull request #18671 from peppy/latency-scrolling-gameplay
Add scrolling gameplay visualisation mode to latency certifier
2022-06-13 18:46:46 +09:00
7ac8ba0a74 Merge pull request #18368 from apollo-dw/dho
Move object history in difficulty calculation to the object itself
2022-06-13 17:31:08 +09:00
f997886142 Add scrolling gameplay visualisation mode to latency certifier 2022-06-13 17:18:32 +09:00
86163d2225 Fix hit error meters not updating visual state when hidden
It is an expectation of users that when the HUD is shown after a period
of being hidden, it will visually reflect the state based on recent
judgements.

To achieve this, I've added `AlwaysPresent` and moved the transform
application to the meter level, rather than at a child level. If this is
seen as a bad direction, `AlwaysPresent` can be applied to the drawable
children and the transforms can be moved back.

Also of note, `ColourHitErrorMeter` is pretty weird. The flow class
could potentially be removed and reduce `AlwaysPresent` usage by one.
Can do that refactor as part of this PR if preferred.

Closes #18624.
2022-06-13 16:38:57 +09:00
17eaf7bb5c Add failing test coverage showing hit meters don't update when not visible 2022-06-13 16:36:22 +09:00
77fcf35d1d Remove unlimited frame limiter warning
This should not be required now that we have a 1,000 Hz limiter in
place.
2022-06-13 15:40:27 +09:00
dfc643fd8c Match family string via GetFamilyString() 2022-06-13 12:35:10 +09:00
3aec0fe9b6 Fix torus alternate not mapping "medium" weight to "regular" 2022-06-13 04:45:07 +03:00
7971355660 Fix torus "medium" weight not mapped to "regular" when using With 2022-06-13 04:44:44 +03:00
051aa8f028 Mark family strings as verbatim 2022-06-13 04:43:14 +03:00
12ff98001d Merge pull request #18635 from peppy/latency-comparer-more-modes
Add multiple display modes (including circle gameplay) to latency certification
2022-06-12 00:59:36 +09:00
486f762f44 Fix inspection by removing unstable rate code 2022-06-12 00:13:36 +09:00
af353c37c0 Don't show UR for now 2022-06-11 23:54:11 +09:00
52c8cea27d Update spectator/multiplayer endpoint in line with new deployment 2022-06-11 22:31:01 +09:00
419b5791c9 Move circle duration to constant 2022-06-11 16:08:24 +03:00
8d53ed64a3 Fix mode cycling and add test coverage 2022-06-11 21:36:43 +09:00