Commit Graph

512 Commits

Author SHA1 Message Date
b5746f5f20 Merge pull request #20602 from peppy/mania-fix-object-colouring
Fix osu!mania not colours not always updating when switching skins
2022-10-07 19:22:55 +09:00
4b772643e9 Use bindable flow for transfer of accent colour from columns to hit objects
This fixes the case where changing a skin during gameplay runtime does
not correctly convey colour information to off-screen `DrawableHitObject`s.
2022-10-07 18:25:08 +09:00
721189b23a Merge branch 'master' into argon-mania-note 2022-10-07 17:34:11 +09:00
c7405d1c1c Add missing immediate application of AccentColour in DefaultKeyArea
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2022-10-07 17:00:10 +09:00
a543222a2b Add ability to pad stage vertically 2022-10-07 15:45:35 +09:00
f1ea61b1a2 Remove unused colour code 2022-10-07 15:24:37 +09:00
9a92ff1681 Fix SourceChanged unbind directionality and add null check 2022-10-07 15:24:37 +09:00
dee01abab1 Add method to get stage from column index 2022-10-07 15:24:37 +09:00
0d21c0e49c Remove StageDefinition from configuration lookups
I added this for future usage, but it turns out I can get the
definitions directly from `ManiaBeatmap`.
2022-10-07 15:24:36 +09:00
6b79f16461 Make Column.AccentColour bindable 2022-10-07 15:24:36 +09:00
532d101080 Remove unused class 2022-10-07 15:24:36 +09:00
276395f1af Fix column colour not updating on skin change 2022-10-07 15:24:36 +09:00
5c48d8931a Add StageDefinition to ManiaSkinConfigurationLookup and make column background colour lookup work 2022-10-07 15:24:36 +09:00
9c979044dc Move AccentColour assignment to inside Column 2022-10-07 15:24:36 +09:00
46c3cfe54d Remove StageDefinition flow in ManiaSkinComponent 2022-10-07 15:24:36 +09:00
7796a4c109 Cache StageDefinition for consumption (and remove ColumnType) 2022-10-07 15:24:36 +09:00
df3ad618e1 Move ColumnType to constructor 2022-10-07 15:24:36 +09:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
e4028b8fc1 Remove index ctor param from ColumnHitObjectArea
No longer used since 5692cecaa4.
2022-02-01 21:49:52 +01:00
2f88efd3c3 Pass column in rather than accessing parent 2022-02-01 00:53:56 +09:00
0e764538e0 Retrieve KeyBindingContainer via DI rather than traversal lookup 2022-01-31 17:05:04 +09:00
cc7fb0e559 Add mouse click support and increase area to full column height 2022-01-31 16:37:02 +09:00
b0d61a18b0 Load keyBindingContainer once on LoadComplete() & make touch area height to const 2022-01-07 15:57:30 +09:00
4cb8272d14 Column Touch area & highlighting on start 2021-12-30 17:37:19 +09:00
dec1f31749 Make KeyBindingContainer public 2021-12-28 22:43:07 +09:00
9ed7139582 Merge branch 'master' into master 2021-12-28 22:36:55 +09:00
62d6bb8c2e Trigger touch on click key area 2021-12-28 22:35:45 +09:00
59b4aea5f9 Make method and property name to match class name 2021-12-28 21:52:46 +09:00
0bd928b5cd Fix incorrect naming / apply review 2021-12-27 21:44:19 -08:00
7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
98524d60a4 Fix clear identifier typos 2021-12-27 20:26:28 -08:00
58994b790c Get key binding container once instead of getting on every touch 2021-12-27 21:20:52 +09:00
327822de5b Add touchscreen support for osu!mania ruleset 2021-12-27 19:41:36 +09:00
1eed2436e6 Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
bc37cb6f43 Merge branch 'master' into no-more-difficulty-control-points-info 2021-10-08 18:41:17 +09:00
b339c149d8 Copy BaseDifficulty to Beatmap<T> and move all write operations across 2021-10-06 15:10:45 +09:00
46bafb6252 Merge branch 'master' into no-more-difficulty-control-points-info 2021-09-28 13:53:56 +09:00
f9d5abff8a Update with keybinding changes 2021-09-16 18:26:12 +09:00
d587dc6203 Populate new approach rate where required 2021-09-03 17:11:12 +09:00
b907c2f4f6 Fix osu! judgements getting scaled twice over different durations 2021-09-02 16:31:43 +09:00
6aa894e55e Split out separate component 2021-08-25 16:56:44 +09:00
3ac58d6838 Fix min/max values not being passed to inner time range 2021-07-16 19:32:31 +09:00
fa8e5013c5 Adjust mania speed range 2021-07-16 18:22:34 +09:00
70a844ac10 Remove allowFallback parameters completely 2021-05-27 14:50:42 +09:00
cc5c702a92 Apply all properties after cast (looks cleaner) 2021-05-19 17:31:47 +09:00
98e77a30d3 Move column changing logic to ManiaSelectionHandler 2021-05-13 20:13:50 +09:00
0fa3027ab9 Increase pool sizes a bit 2021-05-12 17:37:59 +09:00
7913189aa9 Turn on pooling 2021-05-12 16:56:23 +09:00
789025a7ce Update playfield/stage/column implementations for pooling 2021-05-12 16:56:07 +09:00
5692cecaa4 Initial implementation of DHO pooling 2021-05-12 16:35:05 +09:00