Commit Graph

51983 Commits

Author SHA1 Message Date
970e0cc85a Merge branch 'master' into beatmap-background-with-storyboard-stopping 2022-01-11 21:39:49 +01:00
7a25fe79b7 Fix sample control point time being calculated before defaults applied
In editor contexts, the `StartTimeBindable` subscription in `HitObject`
was firing before defaults were applied, which in the case of sliders
manifested in an infinite end time. `ApplyDefaults()` also did not
always set the time of the control point to the correct value, which
matters when the beatmap is encoded.

Ensure that the control points receive the correct time values during
default application, and only register the `StartTimeBindable` change
callback after defaults have been successfully applied.
2022-01-11 21:38:59 +01:00
e91d3dd8b4 Add failing test for incorrect sample control point time after paste 2022-01-11 21:34:22 +01:00
c328b26de1 Merge pull request #16414 from r00ster91/patch-1 2022-01-11 21:58:08 +03:00
82722cd804 Merge branch 'master' into patch-1 2022-01-11 21:31:13 +03:00
81f24a54a0 Merge pull request #16413 from smoogipoo/improve-blur-quality
Improve quality of beatmap background blurs
2022-01-12 00:11:44 +09:00
a8c3fdd383 Update outdated OpenTabletDriver FAQ links 2022-01-11 16:11:07 +01:00
60e42bf45e Add lenience to fix test failures 2022-01-11 23:01:17 +09:00
e6368fd6b2 Merge branch 'master' into fix-mania-normalised-scroll-speed 2022-01-11 21:24:32 +09:00
906e700b60 Improve quality of beatmap background blurs 2022-01-11 21:22:16 +09:00
01a3cf3849 Merge pull request #16412 from smoogipoo/fix-chatlink-test
Fix incorrect action returned for wiki links in DEBUG mode
2022-01-11 20:52:08 +09:00
ef66ec4622 Also fix MessageFormatter tests 2022-01-11 17:55:43 +09:00
3cb5f43f77 Fix incorrect action returned for wiki links in DEBUG mode 2022-01-11 17:46:49 +09:00
269df08fc9 Make ChatLink tests into proper unit test methods 2022-01-11 17:42:02 +09:00
892374b50b Merge pull request #16411 from peppy/update-framework
Update framework
2022-01-11 16:09:42 +09:00
070903f5e6 Merge pull request #16409 from smoogipoo/fix-most-common-beatlength
Ensure first control point starts at 0 in most common beat length calculation
2022-01-11 15:16:58 +09:00
797d3f5d65 Update framework 2022-01-11 15:09:51 +09:00
38c32d5c3f Merge branch 'master' into fix-most-common-beatlength 2022-01-11 14:49:00 +09:00
38a51b9ce0 Add comment 2022-01-11 13:54:12 +09:00
81fed4c6bf Use time=0 as for the first control point 2022-01-11 12:55:17 +09:00
a09563a7d9 Fix calculation of most common beat length for mania scroll speed 2022-01-11 11:00:30 +09:00
261b8ecad6 Merge pull request #16405 from smoogipoo/fix-pp-counter-underflow
Fix PP counter underflow with SpunOut mod
2022-01-11 10:55:47 +09:00
b88a65166e Fix pp counter underflow with SpunOut mod 2022-01-11 10:22:16 +09:00
90558f809f Merge branch 'master' into slider-snapping 2022-01-10 22:42:16 +09:00
e333831c45 Merge pull request #16371 from bdach/angle-of-rotation-display
Add tooltip with relative rotation in degrees to rotation handles
2022-01-10 22:19:50 +09:00
9756c0ab5c Merge pull request #16309 from peppy/async-deadlock-safety
Apply osu! side fixes for usage of `Task.Wait` and `Task.Result`
2022-01-10 16:39:33 +09:00
af9fad00c3 Merge branch 'master' into async-deadlock-safety 2022-01-10 16:11:09 +09:00
928023fabb Merge pull request #16362 from bdach/multiplayer-wrong-ruleset
Fix multiplayer starting gameplay using last picked item ruleset rather than actual current item ruleset
2022-01-10 15:10:27 +09:00
5aaf5953f4 Merge pull request #16393 from peppy/detach-already-detached
Add mention to detach methods of only running once
2022-01-10 13:42:50 +09:00
c2843249e8 Merge pull request #16359 from peppy/fix-legacy-score-decoer-test
Fix `LegacyScoreDecoderTest` incorrectly comparing unset beatmap IDs
2022-01-10 13:10:58 +09:00
6f18db2136 Merge pull request #16390 from peppy/fix-filter-matching-tests
Update `FilterMatchingTest` and filter code to use ruleset's `OnlineID`
2022-01-10 13:10:51 +09:00
d072f1d08d Add mention to detach methods of only running once 2022-01-10 13:09:26 +09:00
3c3210e8ef Merge pull request #16389 from peppy/update-resources
Update resources
2022-01-10 12:47:25 +09:00
02d8a6359a Update FilterMatchingTest and filter code to use ruleset's OnlineID
The tests were relying on the `RulesetID` being set to 0 in the example
beatmap, even though the ruleset *instance* was set to ID 5.

This explicitly adds that 0 value to show intent, and also removes the
incorrect specification of 5 (which would cause the convert filter tests
to fail).

Also updates the filter code to use `OnlineID`, which is required in
realm changes.
2022-01-10 12:30:34 +09:00
3d14511286 Remove MD5 comparison also 2022-01-10 12:17:32 +09:00
ca162ed09a Update resources 2022-01-10 11:36:26 +09:00
ed992eed64 Merge pull request #16382 from bdach/rankings-table-inactive
Fade out inactive player rows on user ranking table
2022-01-10 00:30:06 +09:00
2e9ba40ae2 Add references to web implementation wrt property used 2022-01-09 14:46:15 +01:00
12c8243a9b Fade out inactive player rows on user ranking table 2022-01-09 14:42:26 +01:00
82d6639a3b Decouple rankings table test from online API 2022-01-09 14:42:19 +01:00
d76c674abc Add tooltip with relative rotation in degrees to rotation handles 2022-01-08 20:24:15 +01:00
24d377fddb Move implementation of drag handle operations to concrete classes 2022-01-08 20:24:00 +01:00
dcbeca2407 Merge pull request #16366 from bdach/fix-editor-text-box-precision
Fix effect point multiplier text box displaying too much decimal digits
2022-01-09 00:58:44 +09:00
9370e84460 Fix effect point multiplier text box displaying too much decimal digits 2022-01-08 16:12:52 +01:00
c5ac996e3f Restore ruleset using current playlist item on resuming room sub screen
Ensures that the ruleset selected at the multiplayer song selection
screen does not overwrite the current playlist item's ruleset.
2022-01-08 14:56:01 +01:00
446962446e Add test coverage for correct revert of mods when play starts at song select 2022-01-08 14:50:58 +01:00
3dd5705a81 Add test coverage for correct revert of mods after new item is queued 2022-01-08 14:50:58 +01:00
50077f05bd Add test coverage for correct revert of ruleset when play starts at song select 2022-01-08 14:50:57 +01:00
f026973b19 Add failing test for ruleset incorrectly applying from latest picked item 2022-01-08 14:50:54 +01:00
34135138b6 Merge pull request #16355 from bdach/scoreboard-time
Add basic "time ago" display to leaderboards on beatmap overlay
2022-01-08 17:11:43 +09:00