Commit Graph

3713 Commits

Author SHA1 Message Date
547b3d8bed Fix speed change calculation in time ramp mods 2021-01-31 20:34:56 +01:00
81b052b866 Add failing test cases 2021-01-31 20:34:22 +01:00
2c08ce05fa Remove game-local enum [Order] attribute
In favour of the newly-added framework one.
2021-01-27 22:29:52 +01:00
7d06af916c Merge branch 'master' into add-messagepack 2021-01-27 13:00:46 +09:00
a5f3418e56 Avoid tooltip display 2021-01-26 19:11:19 +09:00
9537090d28 Setup all spectator model classes for MessagePack 2021-01-26 16:39:35 +09:00
dee0d3c33a Merge branch 'master' into apply-sv-to-taiko-hr-ez 2021-01-25 14:28:06 +09:00
04095cd5b9 Merge branch 'master' into fix-editor-scroll-interruption 2021-01-21 17:46:18 +09:00
1d9aaac2c2 Fix HOC not propagating DHO results applied on kill
`DrawableHitObject.OnKilled()` calls `UpdateResult()` to clean up a
hitobject's state definitively with regards to the judgement result
before returning the DHO back to the pool.

As it turns out, if a consumer was relying on this code path (as taiko
was in the case of nested strong hit objects), it would not work
properly with pooling, due to `HitObjectContainer` unsubscribing from
`On{New,Revert}Result` *before* calling the DHO's `OnKilled()`.

This in turn would lead to users potentially getting stuck in gameplay,
due to `ScoreProcessor` not receiving all results via that event path.

To resolve, change the call ordering to allow hit result changes applied
in `OnKilled()` to propagate normally.
2021-01-21 00:05:37 +01:00
de9d075f94 Initial sample + samplechannel rework 2021-01-19 17:11:40 +09:00
ced7a36788 Update namespaces 2021-01-18 21:24:10 +09:00
04fa32bc34 Rename and add xmldoc for smooth seeking method 2021-01-15 16:14:21 +09:00
d5878db615 Fix default judgement text mispositioned for one frame 2021-01-14 12:33:33 +09:00
4b4adc927c Rename param to match method body 2021-01-10 15:35:53 +01:00
0aad0c7c6c Target logic at this and adjust variables 2021-01-09 00:31:18 +03:00
375ecf92ed Merge remote-tracking branch 'upstream/master' into fix-mod-buttons-not-copying-settings 2021-01-09 00:26:18 +03:00
05ba5d4c31 Merge pull request #11438 from bdach/difficulty-adjust-defaults
Fix difficulty adjust mod treating default values as user overrides
2021-01-09 01:18:34 +09:00
303cc62ee7 Transfer flags indicating if settings were changed 2021-01-06 22:46:46 +01:00
68352782db Change .StartsWith() to .Equals()
In line with planned-but-delayed breaking change.
2021-01-06 18:38:24 +01:00
9cc63e8dce Remove obsoleted IHasEndTime 2021-01-06 18:38:24 +01:00
539785e422 Remove obsoleted IHasCurve 2021-01-06 18:38:24 +01:00
09742998cd Fix mistaken obsoletion notice
It was added in c9f38f7bb6, which
specified 2021 in another place (and was committed in October of 2020
anyway). Update the year so that it doesn't get culled prematurely.
2021-01-06 18:38:24 +01:00
b3f08b29ca Ensure that all changes to screen backgrounds are on the correct thread 2021-01-05 15:22:50 +09:00
9e4a925ab1 Clarify & cleanup comments some 2021-01-03 13:44:29 +01:00
a3e29b9154 Rename parameters for readability 2021-01-03 13:25:44 +01:00
2501707d7d Copy values using Bind to also copy defaults 2021-01-03 20:45:03 +09:00
29dbb1cc0d Add internal pathway for ensuring correct application of bindable mods 2021-01-03 15:48:28 +09:00
23e216fa0b Simplify some default value checks (we are sure the return is an IBindable) 2021-01-03 15:47:15 +09:00
c1a1e3acc5 Revert drive-by changes 2021-01-01 15:40:40 +03:00
a031c8e0b6 Apply documentation suggestions
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-01-01 15:34:09 +03:00
b4df2d6d43 Add method for copying properties from another mod 2021-01-01 03:46:09 +03:00
013b9b62a1 add SV multipliers to taiko difficulty mods 2020-12-29 20:22:56 +06:00
41b79d938b Fix wrong checks.. 2020-12-28 15:30:52 +03:00
5efcdbd431 Fix IMod now using reference equality as well 2020-12-28 15:19:28 +03:00
43f8f3638a Fix mod using reference equality unless casted to IMod 2020-12-27 02:42:13 +03:00
d66e218318 Source display accuracy from header and remove from ScoreProcessor function 2020-12-24 14:57:23 +09:00
64095307de Merge branch 'master' into realtime-leaderboard 2020-12-23 09:56:47 +01:00
be427a4ec0 Fix realtime leaderboard showing accuracy based on final base score, not rolling 2020-12-23 14:20:35 +09:00
d229fbba6e Merge branch 'master' into present-recommended 2020-12-22 13:52:29 +09:00
f96d2f4ba4 Merge branch 'master' into fix-texture-loader-usages 2020-12-21 18:35:34 +01:00
bc212b2538 Merge branch 'master' into fix-texture-loader-usages 2020-12-21 13:51:55 +09:00
a8569fe15c Fix a couple of simple cases of incorrect TextureLoaderStore initialisation 2020-12-21 13:35:46 +09:00
a31e8d137f Add guard when clearing samples 2020-12-20 15:42:24 +01:00
ee33c0be93 Extract combo & accuracy ratio calculation helpers 2020-12-19 19:08:29 +01:00
2babb7ecb0 Fix CI 2020-12-18 18:33:38 +08:00
560a0174df Make auto restart toggleable 2020-12-18 17:54:09 +08:00
f13683dc90 Correctly account for max combo of the input, rather than the global 2020-12-17 16:05:41 +09:00
41d8b84bd7 Revert MaxBaseScore to being a private field (no longe required to be public) 2020-12-17 15:47:20 +09:00
2954218897 Add method to ScoreProcessor to calculate score and accuracy from statistics 2020-12-16 16:20:29 +09:00
64a2526678 Add header class and basic flow for propagating data updates 2020-12-14 17:33:23 +09:00