Commit Graph

82 Commits

Author SHA1 Message Date
06512e8bd9 Use const for minimum height specification in final usage location
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-03-06 01:01:22 +09:00
f8ef352306 Don't consider judgements beneath the minimum height as being applicable
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-03-06 01:00:47 +09:00
5a164e4520 Hide adjustment when no adjustment is applied 2022-03-04 15:19:55 +09:00
8c7b1e0aa8 Only construct the adjustment portion of bars when required 2022-03-04 15:01:54 +09:00
2785218b79 Only apply animation if the bar is going to be larger than the minimum height 2022-03-04 14:59:53 +09:00
540d7d0e2c Add the ability to set and show an offset value on timing distribution graph 2022-03-04 14:36:15 +09:00
d3e04fe594 Colour centre bin in distribution graph differently 2022-03-04 14:09:27 +09:00
c063a73742 Fix autosize weirdness by specifying a constant size for the x axis 2022-03-04 14:05:42 +09:00
010fa7ed01 Allow an offset to be shown on the timing distribution graph 2022-03-04 14:05:42 +09:00
835cb09537 Merge branch 'master' into fix-hit-distribution-rounding 2022-03-04 12:43:57 +09:00
8b504bb5ac Ensure rounding is still applied in non-midpoint cases 2022-03-04 12:42:07 +09:00
a06d806fb9 Fix hit distribution graph midpoint rounding not looking great around zero
Not sure this will be accepted and it's likely only ever going to show
in tests, but seems to be a better approach to midpoint rounding for
this case?
2022-03-03 15:43:02 +09:00
ab0ee26540 Remove padding from distribution graph bars to fix some bars becoming invisible at low sizes 2022-03-03 15:13:42 +09:00
a41e1c80f1 Show hit error on results screen
Leading up to implementation of "local offset", this feels like a good
thing to have visible first and foremost.
2022-02-28 19:11:06 +09:00
10bdb7240f Pre-check for divisor zero and add explanation 2022-02-08 14:36:29 +08:00
0b1fef38af Use the playable beatmap provided in CreateStatisticsForScore 2022-02-05 21:36:34 +08:00
2e1a9f1379 Add performance breakdown as statistic item in extended statistics panel 2022-02-05 21:13:16 +08:00
47d577ec9c Add back constructor for ruleset compatibility 2022-02-03 19:17:56 +09:00
6974c2d255 Remove weird panelIsComplete flag and replace LINQ with simple foreach 2022-02-03 19:00:03 +09:00
aff36d4e16 Refactor populateStatistics to avoid disposing 2022-02-03 11:52:37 +08:00
19eb9ad8a7 Reorder StatisticsItem constructor to make a touch more sense 2022-02-02 23:02:38 +09:00
3c2a6fe208 Don't prompt for a replay if no item requires hit events 2022-02-02 19:07:14 +08:00
1e19c7046a Use spacing instead of bottom margin 2022-02-02 19:02:29 +08:00
b0023b9809 Also dispose rows 2022-02-02 19:00:46 +08:00
36bfef4f54 Dispose container before replacing 2022-02-02 17:32:16 +08:00
042574660c Rename "Content" to "CreateContent" 2022-02-02 17:29:03 +08:00
90e30bc9e8 Remove useless null checks 2022-02-02 17:26:17 +08:00
5e3d124eef Add scrolling to the extended statistics panel 2022-02-02 17:20:22 +08:00
3ba5d88914 Update statistics item display logic 2022-02-02 13:41:51 +08:00
c5c4c85006 Lazily create content of StatisticItem 2022-02-02 13:29:18 +08:00
51251e3204 Fix CI reported warnings 2022-01-12 22:39:00 +09:00
53792811b2 more fixes (almost compiles, except ruleset and manager) 2022-01-12 16:57:27 +09:00
69809390d3 Fix HUD unstable rate counter not including judgements before load complete
Also unifies UR calculation logic with the results screen statistic item
to reduce duplication.
2021-11-11 13:36:05 +01:00
9e13c20bd4 Move spinner hiding before newScore null check 2021-11-07 19:35:30 -08:00
ac5d9853d3 Fix loading spinner potentially showing on statistics unavailable message 2021-11-07 17:25:33 -08:00
6944151486 Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
853cf6feaa Rename last remaining BeatmapInfo Beatmap usage 2021-10-04 17:35:53 +09:00
ff5a1937f5 Fix test logic and stabilise rounding direction 2020-10-09 05:04:03 +09:00
a5b2c4195e Fix incorrect timing distribution display due to lack of rounding 2020-10-09 04:41:45 +09:00
2b1ef16f89 Replace comparison references to HitResult.Miss with IsHit 2020-10-02 23:31:24 +02:00
02d8355321 Merge pull request #10224 from peppy/results-statistics-replay-button
Add more descriptive description and download button when statistics not available
2020-09-24 14:31:38 +09:00
fda6e88dd3 Fix braces style 2020-09-24 12:39:08 +09:00
cb903ec9e2 Fix extended statistics not being vertically centered 2020-09-24 12:21:46 +09:00
f4d2c2684d Add more descriptive description and download button when statistics not available 2020-09-24 12:21:08 +09:00
3ca2a7767a Exclude misses and empty window hits from UR calculation 2020-08-31 14:29:37 +02:00
3b22b891d1 Add failing test cases 2020-08-31 14:29:18 +02:00
abdb991923 Hide misses from timing distribution graph 2020-08-31 14:15:47 +09:00
6846a245f4 Reapply lost anchoring fix 2020-08-27 20:51:28 +02:00
ea1f07e311 Simplify/rename SimpleStatisticRow mess 2020-08-27 20:37:10 +02:00
ce013ac9b4 Make statistic header optional 2020-08-27 20:18:53 +02:00