Commit Graph

254 Commits

Author SHA1 Message Date
608fa3cc73 Merge remote-tracking branch 'upstream/master' into sample-control-points 2023-04-30 19:47:03 +02:00
07efa7d660 Merge branch 'master' into fix-storyboard-loop-end-time 2023-04-26 21:53:26 +02:00
c6fc180659 remove all test usages of SampleControlPoint 2023-04-26 14:21:52 +02:00
e330052852 Add second definition of EndTime for storyboard elements to account for loops in lifetime 2023-04-25 15:22:11 +09:00
dce0c5fac8 Add test coverage of expected behaviour for playback of loops with no explicit end time 2023-04-25 15:14:32 +09:00
3166f88c17 Removed unneccessary using directive 2023-04-21 10:11:47 +02:00
e9fb836e9c Added tests for video backgrounds 2023-04-21 03:24:11 +02:00
c35c81293a Add test coverage ensuring images specified as videos are used as background image instead 2023-03-13 18:24:16 +09:00
3aea058c98 Add test coverage ensuring images are not read as videos 2023-03-13 18:24:16 +09:00
12f240e11a Apply simple NRT changes to touched test scenes 2023-03-13 18:24:16 +09:00
1250c1f0c1 Update test assertions to match stable expectations
These changes were taken from https://github.com/ppy/osu/pull/22582.

Minor adjustments were applied to match stable expectations, which is to
say there cannot be an inherited control point with omit barline
specification (in the editor the setting is greyed out when inheritance
is turned on).
2023-02-28 19:28:21 +09:00
679ec986d5 Fix storyboard outro time potentially running too long 2023-02-06 16:39:44 +09:00
49df05dd07 Add test 2022-12-07 15:07:39 +09:00
d9d48516fc Add test coverage of getting last object time 2022-12-01 18:05:15 +09:00
ab458320c4 Fix some lingering inspections 2022-11-09 17:46:24 +09:00
992441b9de Disable alpha component parsing in beatmap / skin colour sections 2022-09-21 16:11:41 +09:00
cf25ee8e84 Add test coverage of storyboard animation start time 2022-09-12 14:17:15 +09:00
5b758afd09 Merge branch 'master' into taiko-geki-katu 2022-09-07 16:22:47 +09:00
7c0e99c5a8 Decode Geki/Katu from legacy taiko scores into LargeBonus 2022-09-07 00:12:34 +09:00
fa0a4614f8 Add failing test for second incorrect case of start time handling 2022-09-06 16:40:59 +09:00
abf0242686 Add failing test for incorrect start time of storyboard elements 2022-09-06 16:16:58 +09:00
adea29c106 Fix test failures 2022-08-24 03:37:33 -04:00
c7d4c739aa Add a basic NaN control point test for LegacyBeatmapDecoder 2022-08-24 02:53:55 -04:00
e8d4bc4497 Allow NaN during beatmap parsing if desired 2022-08-22 21:04:26 -04:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
9259aa94f1 Fix Catmull slider parsing with duplicate initial point 2022-05-24 11:47:42 +09:00
fe49a7e678 Add failing tests 2022-05-18 17:10:19 +09:00
478174dd58 Merge pull request #17416 from peppy/skin-fuck
Refactor skin construction
2022-03-25 15:36:06 +09:00
d6fc53579e Split out shared code for encode-decode cycle (and remove unrelated culture set) 2022-03-24 17:00:49 +09:00
a7554dcdf7 Use a constant for the early version timing offset 2022-03-24 16:43:41 +09:00
2efae031c9 Add test coverage of decode specifically 2022-03-24 16:39:56 +09:00
59a7eb5322 Add test coverage ensuring offsets are correct before and after legacy replay encode 2022-03-24 16:34:21 +09:00
7a1909bf97 Change parameter order of LegacySkin to put IStorageResourceProvider first
The optional resource store should not be before the (basically)
required resource provider.
2022-03-23 15:02:04 +09:00
bda3cdc9a7 Add tests 2022-01-28 19:29:30 +09:00
7dc3940dee Add test coverage for preserving legacy beatmap info defaults 2022-01-27 21:49:26 +01:00
5288eedd31 Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID 2022-01-27 15:38:03 +09:00
735414bc49 Replace TimeSignatures enum with struct for storage of arbitrary meter 2022-01-22 20:50:31 +01:00
bb6f40d16e Add test coverage of all mod storages containing classic mod post-import 2022-01-19 14:34:27 +09:00
7f65f3a47f Remove all usage of BaseDifficulty (and access Difficulty instead) 2022-01-18 22:57:39 +09:00
b2d09b7b10 Fix further warnings 2022-01-12 23:42:12 +09:00
51251e3204 Fix CI reported warnings 2022-01-12 22:39:00 +09:00
3d14511286 Remove MD5 comparison also 2022-01-10 12:17:32 +09:00
f6f24220c2 Fix LegacyScoreDecoderTest incorrectly comparing unset beatmap IDs
This has been wrong from the outside, but hidden by the fact that the
default values are equal. I've changed to MD5Hash which actually asserts
that the correct beatmap has likely arrived.

Found this in my realm changes, where it fails due to the beatmap ID
being a differing Guid in each case.
2022-01-08 15:28:13 +09:00
b0d14526ea Move test ScoreInfo creation to TestResources
The main goal here is to remove the inheritance, since realm doesn't
like that. Unfortunate that we can't use object initialisers in a few of
these places, but no real way around that.
2021-12-13 16:34:50 +09:00
ea6766d940 Add failing test case 2021-12-04 17:13:43 +01:00
bbd3ea5b77 Update all actual usages of RulesetInfo.ID to use OnlineID instead 2021-11-24 15:50:26 +09:00
692e846acd Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface 2021-11-12 17:52:44 +09:00
6a098a8634 Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface 2021-11-12 17:46:24 +09:00
51a353e12d Rename BeatmapInfo.Version to DifficultyName to match underlying interface 2021-11-11 17:20:53 +09:00
ed07ee8c61 Update all existing usages of AuthorString/AuthorId
Unfortunately the getters need to be left in place else EF breaks.
2021-11-04 18:59:37 +09:00