Commit Graph

62 Commits

Author SHA1 Message Date
5375af7820 Remove other Equals(object) calls. 2019-12-03 20:23:27 +08:00
8d1b11d4bd Add storyboard lead-in tests 2019-11-21 18:50:54 +09:00
ccc8aa6fa4 Apply brace style. 2019-11-11 20:13:13 +08:00
a06cb54732 Merge branch 'master' into beatmap-parsing-fallback-v2 2019-09-20 15:28:08 +09:00
a407e267a2 Fix PF/SD legacy mod conversion
Upon investigating an user report in #6091 that indicated that viewing
replays using the Perfect mod would also display the Sudden Death mod
icon despite Perfect being the more restrictive of the two, it turned
out that the logic of importing legacy scores was missing that corner
case. A similar case of Double Time/Nightcore mutual exclusion was
handled, but PF/SD was missed.

Add analogous handling of PF/SD legacy mods for all four rulesets,
and additionally cover a tiny fraction of all cases with unit tests.
The most problematic cases (NC+HD and PF+SD) are covered in all four
basic rulesets.
2019-09-15 22:55:25 +02:00
11eda44d34 Migrate decoding to line-buffered reader
Migrate all usages of StreamReader in the context of decoding beatmaps,
storyboards or skins to the new LineBufferedReader.
2019-09-15 01:28:07 +02:00
6e5cb8a318 implement video parsing 2019-08-30 23:19:34 +03:00
ed4dda1936 Support beatmap conversion tests with mods 2019-08-01 12:49:01 +09:00
0108700793 Make beatmap conversion test use WorkingBeatmap 2019-08-01 12:44:10 +09:00
f33a5bc54c Centralise and update WorkingBeatmap creation in test cases 2019-05-31 14:40:53 +09:00
d7c09e7dbd Merge remote-tracking branch 'origin/master' into fix-new-inspections
# Conflicts:
#	osu.Game.Rulesets.Catch/Judgements/CatchDropletJudgement.cs
#	osu.Game.Rulesets.Catch/Judgements/CatchJudgement.cs
#	osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs
#	osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs
#	osu.Game.Rulesets.Osu/UI/Cursor/CursorTrail.cs
#	osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs
#	osu.Game/Graphics/OsuFont.cs
#	osu.Game/Online/API/Requests/Responses/APILegacyScoreInfo.cs
#	osu.Game/Overlays/Profile/Header/BadgeContainer.cs
#	osu.Game/Overlays/Profile/ProfileHeader.cs
#	osu.Game/Screens/Select/PlaySongSelect.cs
#	osu.Game/Skinning/LegacySkinDecoder.cs
2019-05-07 13:20:17 +09:00
32e71a6314 Fix incorrect seeking behaviour of TrackVirtualManual 2019-04-26 16:15:42 +09:00
612db31c38 Apply newline additions 2019-04-01 12:16:32 +09:00
83076e32c7 Fix TestWorkingBeatmap not running for times below zero 2019-03-26 16:35:34 +09:00
e73cef5f94 Prefill some more properties of TestWorkingBeatmap 2019-03-05 17:14:24 +09:00
26d53d06a9 Fix remaining issues 2019-02-28 13:31:40 +09:00
7e41fbc29b Remove LegacyDifficultyCalculator 2019-02-21 13:12:37 +09:00
f6d70e687b Use correct local variable
Co-Authored-By: peppy <pe@ppy.sh>
2019-02-20 12:27:25 +09:00
b4bb87fee3 Make TrackVirtualTracking more accurate on seeks/stops 2019-02-20 12:08:30 +09:00
f2ad2931c7 Merge remote-tracking branch 'upstream/master' into test-working-beatmap-clock 2019-02-20 11:37:33 +09:00
0fce23a36b Fix test regression 2019-02-19 12:38:45 +09:00
62fe5ad481 Nest class 2019-02-19 12:35:52 +09:00
f8033a3b35 Give TestWorkingBeatmap a reference clock 2019-02-19 12:27:30 +09:00
a8faa942a6 Implement new difficulty calculator structure 2019-02-18 14:49:43 +09:00
280081d589 Fix beatmap ruleset not being set 2019-02-15 14:42:42 +09:00
f50a0be29d Add osu! difficulty calculator test 2019-02-14 16:22:14 +09:00
8617aaa2a7 Update licence header (and remove year) 2019-01-24 17:43:03 +09:00
290812cf65 Merge branch 'master' into more-mania-conversion-fixes 2018-07-06 13:29:16 +09:00
c0c94e24b9 Use VirtualBeatmapTrack in testcases 2018-06-28 11:45:48 +09:00
47ae962099 Output only one mapping failure per mapping 2018-06-15 18:36:22 +09:00
e945186978 Expose the beatmap converter 2018-06-15 17:59:52 +09:00
a4d2364083 Add one more newline 2018-06-14 21:29:08 +09:00
b99b520656 Allow convertmapping to be extended 2018-06-14 21:25:33 +09:00
024d2abfe0 Always generate mappings/convert values as soon as objects are converted
# Conflicts:
#	osu.Game.Rulesets.Catch.Tests/CatchBeatmapConversionTest.cs
2018-06-14 21:25:23 +09:00
8d0e7abdd6 Some rulesets don't have a beatmap processor 2018-06-14 21:23:11 +09:00
5e66b02108 Process beatmap before generating mappings 2018-06-14 21:22:56 +09:00
8d8b7e6fa2 Fix conversion tests for ruleset-specific beatmaps not working
TRuleset was a mistake. This resulted in cases that checked whether the beatmap was for the current ruleset (TaikoBeatmapConverter and ManiaBeatmapConverter) failing due to TestXRuleset != XRuleset...
2018-05-16 13:09:48 +09:00
6867886f4c Give conversion-tested beatmaps a ruleset 2018-05-07 14:04:37 +09:00
794418432f Fix incorrect method name 2018-05-07 11:22:25 +09:00
db3e48c194 Rename GetBeatmap() to GetPlayableBeatmap() 2018-05-07 10:40:30 +09:00
9128e64c9a Rename OriginalBeatmap back to Beatmap 2018-05-07 10:29:38 +09:00
03a5df84c6 Initial rework of beatmap conversion process 2018-04-19 22:04:12 +09:00
66b3b295e7 Use IBeatmap wherever possible 2018-04-19 20:44:38 +09:00
b5a55a0dce Make an interface for beatmaps 2018-04-19 18:58:40 +09:00
32a74f95a5 Normalize all the line endings 2018-04-13 18:26:38 +09:00
e32eec9259 No more caching 2018-03-13 15:22:46 +09:00
706c26c32b Remove extra whitespace 2018-03-13 09:27:33 +09:00
13c20438ef Fix build issues 2018-03-12 19:41:51 +09:00
b91524dbba Give TestWorkingBeatmap's track a valid length 2018-03-12 19:41:15 +09:00
7406cb290f Split out test beatmap from TestCasePlayer into instantiable class 2018-03-12 19:41:09 +09:00