Commit Graph

3159 Commits

Author SHA1 Message Date
0ccf691c97 Remove unnecessary interpolation 2020-03-06 18:00:07 +09:00
3b0e3cd71a Remove using statements 2020-03-06 17:55:57 +09:00
40074f10db Remove unnecessary override 2020-03-06 17:55:05 +09:00
90dbb90470 Merge branch 'master' into disable-keycounter-breaks 2020-03-06 17:53:10 +09:00
aafdfbca1f Merge pull request #8129 from peppy/fix-dummy-track-completion-feedback
Fix DummyWorkingBeatmap's track completion attempting to change game-wide beatmap
2020-03-05 17:57:57 +09:00
0c1775b522 Fix incorrect condition and add test 2020-03-05 17:12:14 +09:00
f7777ecb01 Merge pull request #8142 from peppy/add-star-difficulty-max-migration
Fix song select max displayable star difficulty getting stuck at wrong maximum
2020-03-05 17:10:10 +09:00
646c8fe077 Add note about version override 2020-03-05 15:40:48 +09:00
a311ace626 Add migration test 2020-03-05 15:07:00 +09:00
5200633f9f Centralise TestPlayer implementations as much as possible 2020-03-05 11:25:07 +09:00
b8889318db Pass rulesets to solo game status 2020-03-04 22:13:31 +01:00
afa3ce494d Set online status in activity test
The test would check nothing otherwise.
2020-03-04 22:07:02 +01:00
5fa2638e81 Rename tests to adhere to convention 2020-03-04 22:05:48 +01:00
1bd49d50c7 Remove unnecessary raw string prefixes 2020-03-04 22:05:08 +01:00
5b25b5dfab Change brace style 2020-03-04 22:04:49 +01:00
e3e66991b0 Move initialisation logic to [SetUp] 2020-03-04 22:02:36 +01:00
3d344a076d Add test for disabled keycounter, don't discard change event values 2020-03-03 06:17:25 +05:30
1ce972dd5b Remove unused variable 2020-02-29 21:53:49 +05:30
bca58ddb42 Make KeyCounter stop counting during breaks 2020-02-29 21:18:43 +05:30
54d83eff94 Use OverlayColourProfider for VotePill component 2020-02-26 19:35:20 +03:00
37e9c2a683 Merge branch 'master' into user-list-toolbar 2020-02-26 10:11:21 +09:00
ff063b229b Merge pull request #7973 from peppy/fix-dho-lifetimes-via-judgements
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
2020-02-25 20:38:29 +09:00
61af80c1af Merge pull request #7982 from EVAST9919/comments-crash-fix
Fix potential crash when clicking on show more button in comments
2020-02-25 20:14:58 +09:00
29e2e17144 Merge branch 'master' into fix-dho-lifetimes-via-judgements 2020-02-25 19:07:57 +09:00
a047456354 Revert changes to make HitObject abstract 2020-02-25 19:07:15 +09:00
c1455be855 Add tests 2020-02-25 10:29:03 +03:00
7bc9a9b3d8 Implement OverlayPanelDisplayStyleControl and UserListToolbar components 2020-02-24 07:28:33 +03:00
0cfe1ac823 Implement UserSortTabControl component 2020-02-24 05:47:21 +03:00
ffc7eaa3f2 Fix hitobjects with unknown lifetimes by enforcing non-null judgement
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
e8ebb31517 Expire old judgement lines if too many exist 2020-02-23 03:53:51 +09:00
a512226036 Use attribute instead of CreateChildDependencies 2020-02-22 13:47:42 +01:00
f248c0a98e Fix regressed direct panel test scene
Due to unnoticed past changes TestSceneDirectPanel has regressed in that
clicking the preview track button would crash due to an unregistered
IPreviewTrackOwner dependency.

Make the test scene itself implement that empty interface and cache
itself as IPreviewTrackOwner so that preview tracks lower down can
resolve the dependency.

As the test is purely visual and has no assertions, and the important
logic in that area (preview track playing logic) is already well-covered
enough elsewhere, no further changes were made.
2020-02-22 00:58:33 +01:00
db1e5abad7 Merge pull request #7786 from EVAST9919/subcomments-alter-new
Add ability to load long comment trees in CommentsContainer
2020-02-21 21:18:33 +09:00
41c6d2f2e7 Merge remote-tracking branch 'origin/master' into subcomments-alter-new 2020-02-21 17:02:58 +09:00
7d145a7470 Add test for loading spinner with box 2020-02-21 16:21:44 +09:00
bbac95958c Fix incorrect test scene name 2020-02-21 16:20:55 +09:00
38d9a46ffb Add test for relative sizing scenarios 2020-02-21 16:20:17 +09:00
92f6f0207c Rename LoadingAnimation to LoadingSpinner 2020-02-21 15:33:31 +09:00
623b78d675 Combine all loading animation implementations 2020-02-21 15:32:46 +09:00
2cb218c9c4 Merge remote-tracking branch 'origin/master' into comment-editor 2020-02-21 12:27:34 +09:00
cd666166d5 Merge pull request #7809 from voidedWarranties/proposal-difficulty-icon-select
Allow selecting/playing a specific difficulty using the beatmapset difficulty icons
2020-02-21 10:24:12 +09:00
3380dbbd71 Improve visual appearance of ProcessingOverlay 2020-02-20 19:49:22 +09:00
927115a085 Merge branch 'master' into room-inspector-redesign 2020-02-20 17:41:16 +09:00
e48166858c Merge branch 'master' into overlined-display-refactor 2020-02-20 17:38:04 +09:00
5c16dbbea9 Merge pull request #7919 from smoogipoo/null-leaderboard-position
Support null leaderboard position
2020-02-20 16:27:24 +09:00
d79ca97fe9 Make beatmap scores also support null position 2020-02-20 15:04:12 +09:00
eb8a56055f Merge pull request #7910 from EVAST9919/rankings-clickable-countries
Make country names in RankingsOverlay clickable
2020-02-20 15:00:01 +09:00
1a689231c2 Support null leaderboard position 2020-02-20 14:51:25 +09:00
177935d644 Remove unused using 2020-02-20 14:45:35 +09:00
0cf0099fd5 Merge pull request #7917 from smoogipoo/fix-drawableroom-async-test
Fix possible test failures due to async loads
2020-02-20 14:37:51 +09:00