47a4a07024
Split out animation triggering of MainCirclePiece to be interface driven
2021-04-21 19:15:10 +09:00
ac0ed72d04
Keep hitcircles aligned with view in "Barrel Roll" mod
2021-04-20 18:36:11 +09:00
e2470d757e
Merge branch 'master' into legacy-spm-counter
2021-04-12 12:52:52 +09:00
f2e811928b
Rework slider hackery to not overwrite Samples
2021-04-09 15:28:08 +09:00
8efa381d3a
Actually use whistle sample for sliderwhistle
2021-04-08 23:13:16 +09:00
7713c8a45f
Add support for sliderwhistle
2021-04-08 20:20:09 +09:00
9c3d15171c
Reword xmldoc slightly
2021-04-02 18:00:28 +09:00
5ac36a2462
Switch AlwaysPlaySample to SamplePlaysOnlyOnHit in DrawableSliderTail for conformity
2021-04-02 03:56:23 -05:00
5063cd957f
Force hit sample to play when Classic mod is enabled
2021-04-02 02:54:35 -05:00
9504fe3f3c
Inline add of spm calculation (no need for it to be a separate call)
2021-03-30 13:43:05 +09:00
0bf84e473d
Refactor spinner SPM counter for skinning purposes
2021-03-30 04:19:23 +03:00
c715b9b89e
Merge branch 'master' into legacy-spinner-bonus
2021-03-25 18:09:25 +09:00
64e85ba995
Always fade out approach circles at a HitObject's start time to better match stable
2021-03-23 19:19:07 +09:00
098005393e
Remove unnecessary null checks and debug code
2021-03-23 10:38:37 +09:00
c4d08463ad
Fix spinners playing looping sound too long in the editor
...
The `OnComplete` event was never being run due to the transform playing
out longer than the spinner's lifetime. I've matched the durations, but
also moved the `Stop()` call to what I deem a safer place to run it (I
did notice that without this it would still potentially never fire).
Note that this is more noticeable in the editor because of lifetime
extension. In gameplay, the returning of a spinner to the pool will
clean things up (but in the editor that can take longer, depending on
timeline zoom level).
Another thing worth mentioning is that the fade doesn't actually work.
This is due to https://github.com/ppy/osu-framework/pull/4212 .
Closes #12119 .
2021-03-22 16:04:51 +09:00
98f6e16113
Move default spinner bonus counter to new DefaultSpinner
2021-03-13 05:59:42 +03:00
8fdab5a7de
Revert legacy spinner presence changes and bonus counter component
...
No longer necessary, after inlining legacy coordinates logic to `LegacySpinner` and limiting precisely-positioned legacy components there
2021-03-13 05:57:47 +03:00
020a03e01e
Use sensible "score per tick" constant
2021-03-13 05:56:28 +03:00
c4048c9831
Merge branch 'master' into legacy-spinner-bonus
2021-03-13 05:54:34 +03:00
1591d593e2
Move spin start time to inside result and switch to standard state handling
2021-03-11 12:58:15 +09:00
4e8bcc9265
Fix SPM counter decreasing after spinner has already been completed
2021-03-09 16:54:46 +09:00
5a6864eb78
Fix SPM counter immediately disappearing on completion of spinners
2021-03-09 16:54:46 +09:00
3f1d36ee6b
Add default spinner bonus counter piece
2021-03-06 20:27:56 +03:00
c441e993ff
Separate "gained bonus" to a read-only bindable
2021-03-06 20:27:56 +03:00
d3f0c0730d
Merge branch 'master' into non-concurrent-sample-playback
2021-02-12 17:22:15 +09:00
4710a12774
Merge branch 'master' into classic-mode-flags
2021-02-11 16:21:55 +09:00
5d1d6ec1cb
Fix inverted calculation
2021-02-10 22:09:24 +09:00
20a6405fd2
Add explanatory comments + const
2021-02-10 22:06:19 +09:00
bd2486e5a0
Fix grammatical error in comment
2021-02-10 21:27:12 +09:00
1d425b8322
Simplify case
2021-02-10 21:25:31 +09:00
4a391ce03d
Fix div-by-0 when 0 ticks are hit
2021-02-10 21:24:41 +09:00
be9b07a4cf
Merge branch 'master' into difficulty-adjustment-extension
2021-02-10 20:42:08 +09:00
0dcdad9839
Adjust comment for DrawableSliderHead
2021-02-10 19:04:23 +09:00
a16f4cee3a
Adjust DrawableSlider comment
2021-02-10 18:52:39 +09:00
2fcc4213e1
Rename IgnoreJudgement -> OnlyJudgeNestedObjects
2021-02-10 18:46:26 +09:00
cf06684ad1
Judge heads as slider ticks instead
2021-02-10 18:38:31 +09:00
d955200e07
Prevent invalid hit results for ignored slider heads
2021-02-08 11:10:14 +09:00
a5855f5d28
Move follow circle tracking to DrawableSliderHead
2021-02-05 17:33:48 +09:00
2f22dbe06b
Make sliders display judgements when not ignored
2021-02-03 22:42:50 +09:00
03b7817887
Add flags to return to classic slider scoring
2021-02-03 22:12:20 +09:00
623b47f9af
Add flag to toggle follow circle tracking for slider heads
2021-02-03 21:55:19 +09:00
d521bfc251
Don't directly update HandleUserInput (as it is used by mods)
2021-01-30 02:35:11 +09:00
5a306dfc2b
Fix unused using
2021-01-29 20:22:25 +09:00
f25809d35f
Ensure spinners only handle input during their hittable time
...
While this was already being enforced inside of `CheckForResult`, the
internal tracking values of rotation were still being incremented as
long as the `DrawableSpinner` was present. This resulted in incorrect
SPM values being displayed if a user was to start spinning before the
object's `StartTime`.
Kind of annoying to write a test for (there's no setup for spinners yet)
but am willing to do so if that is deemed necessary.
Closes https://github.com/ppy/osu/issues/11600 .
2021-01-29 19:55:55 +09:00
de9d075f94
Initial sample + samplechannel rework
2021-01-19 17:11:40 +09:00
14b3323682
Use OnComplete instead of Finally to avoid potentially stopping on aborted transforms
2021-01-15 17:18:15 +09:00
311f8b7017
Only restart spinning sample if it was not already playing
2021-01-15 17:17:51 +09:00
767c76921f
Adjust transition time of spinner sound
2021-01-15 17:17:28 +09:00
47a93d8614
Adjust osu! hitobject fade-ins to support AR>10
2020-12-10 00:37:19 +09:00
626956febd
Move some files from Drawables to Skinning.Default namespace
2020-12-04 20:25:12 +09:00
