Commit Graph

1658 Commits

Author SHA1 Message Date
c871f07d2e Use CarouselBeatmap action to select beatmap 2020-02-13 17:14:46 -08:00
ad0de27964 Safer dependency injection and accessibility levels 2020-02-12 22:11:26 -08:00
f8b69fe632 Remove unnecessary carousel variable, fix code formatting 2020-02-12 20:11:39 -08:00
b126c00292 Use dependency loader to get SongSelect instance 2020-02-12 19:05:08 -08:00
2901ec9f26 Select specific difficulties using their icons 2020-02-11 20:05:26 -08:00
81cadb7875 Simplify the way multiple subscreens handle their disable states via a custom stack 2020-02-06 14:22:01 +09:00
79bb476f4c Merge branch 'master' into display-accuracy 2020-02-04 11:39:47 +07:00
3600b0daf0 Merge branch 'master' into fix-mod-select-overflowing 2020-02-04 11:57:54 +09:00
22e3150f68 Fix comment and remove magic numbers 2020-02-03 17:21:06 -08:00
9898a926b2 Use ScoreInfo.DisplayAccuracy everywhere 2020-02-03 22:11:36 +07:00
c6e7603e5e Merge branch 'master' into safe-screen-lease 2020-02-03 18:18:13 +09:00
93952d438f Merge pull request #7677 from peppy/decouple-mod-select-bindable
Decouple ModSelectOverlay from global SelectedMods
2020-02-03 16:27:47 +09:00
9183c78319 Fix crash on exiting song select with ctrl-enter autoplay 2020-02-03 16:04:32 +09:00
aa1daa0ad5 Merge pull request #7703 from bdach/beatmap-stats-precision
Apply precision when determining bar colour in difficulty statistics
2020-02-02 22:31:52 +09:00
e894acf53c Make star filter range bindables BindableDoubles
Due to using Bindable<double>s previously, song select's filter control
would not apply tolerance when checking IsDefault, therefore wrongly
hiding maps with star ratings above 10.1.
2020-02-01 22:48:46 +01:00
609ee26030 Fix mod select overlay not showing up in test 2020-02-01 11:41:41 -08:00
2d42a83bb9 Fix mod select overlay overflowing toolbar at max ui scale 2020-02-01 11:24:29 -08:00
0bfadfbbf1 Apply precision when comparing adjusted values
In some cases, applying the Difficulty Adjust mod without actually
changing any of the settings previously caused the bar in song select
beatmap details to appear red/blue instead of staying white.

This was caused by not accounting for floating-point imprecisions when
determining bar colour in AdvancedStats. To resolve, first check
equality with tolerance, and only then apply blue/red colours if that
equality check does not hold.
2020-02-01 16:16:15 +01:00
a74d22d9e5 Extract beatmap stats test to separate scene 2020-02-01 15:50:33 +01:00
ed368e44ea Merge branch 'master' into safe-screen-lease 2020-02-01 02:11:18 +09:00
c5422743e2 Merge branch 'master' into decouple-mod-select-bindable 2020-02-01 02:06:23 +09:00
19f516e710 Ensure OsuScreen level leases are taken out synchronously 2020-01-31 19:10:44 +09:00
2f61d3f5ad Fix song select remaining issue locally 2020-01-31 17:35:53 +09:00
7bf2e9b369 Decouple ModSelectOverlay from global SelectedMods 2020-01-30 17:38:15 +09:00
09f6c57b0f Merge branch 'master' into fix-import-different-ruleset 2020-01-30 15:08:25 +09:00
c18b1b302c Merge branch 'master' into editor-match-accessibility 2020-01-30 13:49:56 +09:00
c158570249 Fix typo in comment
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-01-30 11:31:34 +09:00
f72de235cc Remove unnecessary length specifications 2020-01-30 11:00:14 +09:00
37ecf8a060 Remove commented line 2020-01-30 10:50:48 +09:00
bea20efb64 Merge branch 'master' into mod_content_centering 2020-01-30 10:34:46 +09:00
f130e48c9e Remove leftover negative margin 2020-01-29 19:17:07 +01:00
c9dda78ded Refactor drawable hierarchy to center properly
* Use FillFlowContainer.Spacing instead of manually applying margins.
* Use Update() for calculating button padding to preserve it after
  mod button expansion and adjust FooterButtonRandom to use this method
  while avoiding flickering.
* Expose mod display margin to clear it in the footer button.
2020-01-29 18:59:51 +01:00
da6952407e Allow null DI 2020-01-29 23:01:57 +09:00
13eb32fea2 Fix editor being accessible for multiplayer song select 2020-01-29 22:20:34 +09:00
76af8bea5d Fix percentage-formatted displays containing a space 2020-01-29 19:51:24 +09:00
7588c574a2 Fix presenting a beatmap from a different ruleset not working 2020-01-29 19:37:54 +09:00
77c06b1c6e Fix beatmap carousel potentially missing beatmap imports 2020-01-29 17:09:12 +09:00
12ff51f686 Fix key count being incorrectly adjusted by hard/easy mods 2020-01-28 17:21:50 +09:00
7aa5e8c23e Limit input propagation correctly 2020-01-27 14:55:47 +09:00
1c64b70b06 Revert "Fix crash due to misordered selection events"
This reverts commit 2d74609f50.
2020-01-27 14:53:24 +09:00
2d74609f50 Fix crash due to misordered selection events 2020-01-26 19:06:50 +09:00
92a5fbe948 Merge branch 'master' into star-filtering 2020-01-24 23:28:36 +09:00
45a25214ab Make upper and lower bounds inclusive 2020-01-24 19:39:21 +09:00
9e0e7be8d0 Modernise filter implementation 2020-01-24 18:57:17 +09:00
12cc97ca31 Merge remote-tracking branch 'origin/master' into star-filtering
# Conflicts:
#	osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs
#	osu.Game/Screens/Select/Carousel/CarouselBeatmap.cs
#	osu.Game/Screens/Select/FilterControl.cs
#	osu.Game/Screens/Select/FilterCriteria.cs
2020-01-24 18:30:52 +09:00
fdde4a6858 Tidy up song select hierarchy to be more readable 2020-01-24 15:44:31 +09:00
c0a233e8bb Align background wedge with carousel 2020-01-24 15:00:10 +09:00
f8cb898516 Improve song select display on ultrawide displays (or when UI scale is set low) 2020-01-23 20:03:52 +09:00
8a7f7c5e46 Merge remote-tracking branch 'smoogipoo/void-key-up-returns' into update-framework 2020-01-22 22:57:56 +09:00
7c62cc3ac3 Merge remote-tracking branch 'smoogipoo/void-mouse-up-returns' into update-framework 2020-01-22 22:57:52 +09:00