0bc6a026eb
Merge branch 'master' into skin-components-bind-outwards-accuracy
2021-05-08 21:08:53 +02:00
c3bf6a0287
Remove weird vestigial Current reimplementation
...
Has no functional purpose anymore since the changes in the HUD element
data binding flow.
2021-05-08 21:01:37 +02:00
dec5400c0a
Merge branch 'master' into skin-components-bind-outwards-score-display
2021-05-08 19:58:19 +02:00
9e0ea494fd
Merge branch 'master' into skin-components-bind-outwards
2021-05-08 19:04:56 +02:00
25312b3e88
Don't restart completion delegate on exit, revert exit behavior to lazer
2021-05-08 11:47:44 -04:00
fe86ee629e
Fix temp files from beatmap listing imports not being cleaned up
...
As reported in #12718 , it turns out that temporary files from beatmap
set downloads performed via the beatmap listing overlay could remain in
the user's filesystem even after the download has concluded.
The reason for the issue is a failure in component integration.
In the case of online downloads, files are first downloaded to a
temporary directory (`C:/Temp` or `/tmp`), with a randomly generated
filename, which ends in an extension of `.tmp`.
On the other side, `ArchiveModelManager`s have a `ShouldDeleteArchive()`
method, which determines whether a file should be deleted after
importing. At the time of writing, in the case of beatmap imports the
file is only automatically cleaned up if the extension of the file is
equal to `.osz`, which was not the case for temporary files.
As it turns out, `APIDownloadRequest` has a facility for adjusting the
file's extension, via the protected `FileExtension` property. Therefore,
use it in the case of `DownloadBeatmapSetRequest` to specify `.osz`,
which then will make sure that the `ShouldDeleteArchive()` check in
`BeatmapManager` picks it up for clean-up.
2021-05-08 17:09:14 +02:00
8c564a69ed
Fix InvalidOperationException when exiting a map at the end
2021-05-07 21:11:03 -04:00
495eb04e2f
Merge pull request #12488 from Denrage/add-missing-author-links
...
Add missing author links in Beatmap Details
2021-05-08 05:41:40 +09:00
5b2f786f97
Update framework
2021-05-07 19:16:00 +09:00
a1aeac5677
Remove remaining cruft from SkinnableAccuracyCounter
2021-05-07 18:12:18 +09:00
68de870986
Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces
2021-05-07 18:11:14 +09:00
9fe6e1096a
Remove cruft from SkinnableHealthDisplay
2021-05-07 18:11:08 +09:00
111b501ced
Revert accidental removal of UTF-8 BOM
2021-05-07 18:04:38 +09:00
1cb10c2a22
Remove unnecessary binding logic from HUDOverlay
2021-05-07 17:51:46 +09:00
a7acecc52b
Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces
2021-05-07 17:51:41 +09:00
04d35826a3
Merge branch 'skin-components-bind-outwards-accuracy' into remove-hud-overlay-unused-pieces
2021-05-07 17:25:39 +09:00
755588258e
Update HealthDisplay components to use DI to attach data source
2021-05-07 17:22:45 +09:00
22677cfeaf
add CreateBorder method in markdown table cell
2021-05-07 14:54:46 +07:00
d92e593ddd
extract out table head and body border into separate component
2021-05-07 14:47:46 +07:00
64e9c5e9ba
add return xmldoc in markdown unordered list
2021-05-07 14:41:27 +07:00
79a1d7b2b3
simplify CreateEmphasisedSpriteText
2021-05-07 14:40:01 +07:00
17b8963cf8
simplify CreateSpriteText in markdown table cell
2021-05-07 14:38:19 +07:00
3524cb7924
simplify CreateSpriteText in markdown heading
2021-05-07 14:36:35 +07:00
01eff7f316
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display
2021-05-07 16:30:08 +09:00
93f10330e3
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy
2021-05-07 16:29:10 +09:00
ad398165a2
Update AccuracyCounter components to use DI to attach data source
2021-05-07 16:27:25 +09:00
17b93361d5
Merge branch 'master' into skin-components-bind-outwards
2021-05-07 16:20:24 +09:00
a2e4fb5b6b
Update ScoreCounter components to bind outwards
2021-05-07 16:16:48 +09:00
fc2a527e9d
Revert "Guard against potentially null track if ever"
...
This reverts commit b1134c3857
2021-05-07 09:57:08 +03:00
7c4e54a1d4
Unrevert null-colaescing/conditionals removal
2021-05-07 09:54:14 +03:00
5b003750f8
change CreateListItem method in OsuMarkdownContainer
2021-05-07 13:20:48 +07:00
9233248a0b
add OsuMarkdownUnorderedListItem
2021-05-07 13:20:20 +07:00
dfcf760b7b
add OsuMarkdownOrderedListItem
2021-05-07 13:20:06 +07:00
bdfe44ddca
change OsuMarkdownListItem to abstract class
2021-05-07 13:19:30 +07:00
165f443ab5
Merge branch 'master' into add-missing-author-links
2021-05-07 14:32:44 +09:00
b1134c3857
Guard against potentially null track if ever
2021-05-07 08:30:50 +03:00
37f44d2e37
Revert wrong not-null track changes
...
This reverts commit f9d99a988271547bece0
2021-05-07 08:28:44 +03:00
71547bece0
Remove any null-coalescing/conditionals in WorkingBeatmap.Track usages
2021-05-07 07:46:23 +03:00
f9d99a9882
Mark WorkingBeatmap.Track as not null
2021-05-07 07:25:14 +03:00
539643c72b
Set loadable beatmap track to clock immediately in BDL
...
This reverts commit 84da247002
2021-05-07 07:21:56 +03:00
84da247002
Fix editor clock using the wrong beatmap track on creation
2021-05-07 05:32:55 +03:00
207f7f1e56
Rename FramedAutoGenerator<T> -> AutoGenerator<T>
2021-05-07 00:31:12 +09:00
ea35b72436
Remove unused IAutoGenerator interface
2021-05-06 22:57:07 +09:00
9be36230f9
Introduce AutoGenerator subclass for frame based replay generation
2021-05-06 21:59:11 +09:00
92022f2cba
add Separator component in OsuMarkdownSeparator
2021-05-06 17:17:14 +07:00
7b43730fe6
add QuoteBackground in OsuMarkdownQuoteBlock
2021-05-06 17:13:46 +07:00
010f625870
use derived component in OsuMarkdownFencedCodeBlock
2021-05-06 17:05:41 +07:00
67f51959db
Merge branch 'master' into osu-markdown
2021-05-06 16:23:20 +07:00
fc04b88e1a
Merge pull request #12697 from peppy/update-framework
...
Update framework
2021-05-06 17:46:08 +09:00
ba634cbf11
change line spacing to 21
...
We use margin bottom in osu-web markdown paragraph[1] as reference for
this line spacing value.
The value from osu-web itself is 1.5em[2]. Because the base font size of
the paragraph is 14px[3][4], the actual value is 14 * 1.5 = 21px
[1] 376cac43a0/resources/assets/less/bem/osu-md.less (L230)376cac43a0/resources/assets/less/variables.less (L58)376cac43a0/resources/assets/less/bem/osu-md.less (L9)376cac43a0/resources/assets/less/variables.less (L161)
2021-05-06 15:15:50 +07:00
